head 1.1; access; symbols pkgsrc-2026Q1:1.1.0.12 pkgsrc-2026Q1-base:1.1 pkgsrc-2025Q4:1.1.0.10 pkgsrc-2025Q4-base:1.1 pkgsrc-2025Q3:1.1.0.8 pkgsrc-2025Q3-base:1.1 pkgsrc-2025Q2:1.1.0.6 pkgsrc-2025Q2-base:1.1 pkgsrc-2025Q1:1.1.0.4 pkgsrc-2025Q1-base:1.1 pkgsrc-2024Q4:1.1.0.2 pkgsrc-2024Q4-base:1.1; locks; strict; comment @// @; 1.1 date 2024.12.19.12.10.36; author bacon; state Exp; branches; next ; commitid 12R5YhwLGG0HH6CF; desc @@ 1.1 log @math/suitesparse: Unbreak build on Alma 8 Some versions of GCC error out with omp default(none) shared(X) when X is defined as const, stating that shared is predetermined. Since const is only a compile-time check, and the code is already build-tested with const, we can remove it without altering runtime behavior. @ text @$NetBSD$ # Fix build on Alma (RHEL) 8 --- ParU/Source/paru_init_rowFronts.cpp.orig 2024-08-24 17:13:32.000000000 +0000 +++ ParU/Source/paru_init_rowFronts.cpp @@@@ -34,7 +34,17 @@@@ ParU_Info paru_init_rowFronts ParU_Numeric *Num_handle, // inputs, not modified: cholmod_sparse *A, - const ParU_Symbolic Sym // symbolic analysis + // gcc on Alma 8 actually errors out on line 443: + // error: "Sym" is predetermined "shared" for "shared" + // It's dumb to error out when the programmer just restates a default, + // but some extant versions of gcc do this, while others (and clang) + // error out if Sym is not included in the shared list. Removing + // default(none) is risky, as behavior may differ with different + // compilers. Since the code is confirmed to build on most platforms + // with const Sym, we know that nothing is trying to modify Sym after, + // so removing the const should not cause any problems. + // const ParU_Symbolic Sym // symbolic analysis + ParU_Symbolic Sym // symbolic analysis ) { @