head 1.2; access; symbols pkgsrc-2016Q4:1.1.0.2 pkgsrc-2016Q4-base:1.1; locks; strict; comment @# @; 1.2 date 2017.03.20.18.17.13; author bouyer; state dead; branches; next 1.1; commitid d3qkVwbNTy4nKjKz; 1.1 date 2016.11.22.20.59.01; author bouyer; state Exp; branches; next ; commitid qR9uGyGaHvIrravz; desc @@ 1.2 log @Update xenkernel46 and xentools46 to 4.6.5. Changes since 4.6.3: various bug fixes. Includes all security patches up to and including XSA-209 @ text @$NetBSD: patch-XSA-195,v 1.1 2016/11/22 20:59:01 bouyer Exp $ From: Jan Beulich Subject: x86emul: fix huge bit offset handling We must never chop off the high 32 bits. This is XSA-195. Reported-by: George Dunlap Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper --- xen/arch/x86/x86_emulate/x86_emulate.c.orig +++ xen/arch/x86/x86_emulate/x86_emulate.c @@@@ -2549,6 +2549,12 @@@@ x86_emulate( else { /* + * Instructions such as bt can reference an arbitrary offset from + * their memory operand, but the instruction doing the actual + * emulation needs the appropriate op_bytes read from memory. + * Adjust both the source register and memory operand to make an + * equivalent instruction. + * * EA += BitOffset DIV op_bytes*8 * BitOffset = BitOffset MOD op_bytes*8 * DIV truncates towards negative infinity. @@@@ -2560,14 +2566,15 @@@@ x86_emulate( src.val = (int32_t)src.val; if ( (long)src.val < 0 ) { - unsigned long byte_offset; - byte_offset = op_bytes + (((-src.val-1) >> 3) & ~(op_bytes-1)); + unsigned long byte_offset = + op_bytes + (((-src.val - 1) >> 3) & ~(op_bytes - 1L)); + ea.mem.off -= byte_offset; src.val = (byte_offset << 3) + src.val; } else { - ea.mem.off += (src.val >> 3) & ~(op_bytes - 1); + ea.mem.off += (src.val >> 3) & ~(op_bytes - 1L); src.val &= (op_bytes << 3) - 1; } } @ 1.1 log @Backport upstream patches, fixing today's XSA 191, 192, 193, 195, 197, 198. Bump PKGREVISIONs @ text @d1 1 a1 1 $NetBSD: $ @