head 1.2; access; symbols pkgsrc-2026Q1:1.2.0.12 pkgsrc-2026Q1-base:1.2 pkgsrc-2025Q4:1.2.0.10 pkgsrc-2025Q4-base:1.2 pkgsrc-2025Q3:1.2.0.8 pkgsrc-2025Q3-base:1.2 pkgsrc-2025Q2:1.2.0.6 pkgsrc-2025Q2-base:1.2 pkgsrc-2025Q1:1.2.0.4 pkgsrc-2025Q1-base:1.2 pkgsrc-2024Q4:1.2.0.2 pkgsrc-2024Q4-base:1.2; locks; strict; comment @# @; 1.2 date 2024.11.30.11.39.02; author nros; state Exp; branches; next 1.1; commitid Jy1EFRo6cA1eaFzF; 1.1 date 2024.10.14.17.19.24; author nros; state Exp; branches; next ; commitid cCmoe7CoxVmEyEtF; desc @@ 1.2 log @www/libwebsockets: Remove PRIVATE from target_link_libraries to fix build All target_link_libraries must either set PRIVATE or PUBLIC or all must not set them. So remove PRIVATE to fix build where libdl exists. dl is added to INTERFACE_LINK_LIBRARIES even if PRIVATE is set since it is also added somewhere else in the build. @ text @$NetBSD: patch-lib_CMakeLists.txt,v 1.1 2024/10/14 17:19:24 nros Exp $ * Don't hardcode -ldl use CMAKE_DL_LIBS for compatabiblity --- lib/CMakeLists.txt.orig 2023-11-20 06:27:02.000000000 +0000 +++ lib/CMakeLists.txt @@@@ -228,12 +228,8 @@@@ if (LWS_WITH_SHARED) if (UNIX AND LWS_WITH_PLUGINS_API) set (CMAKE_POSITION_INDEPENDENT_CODE ON) - if (NOT((${CMAKE_SYSTEM_NAME} MATCHES "FreeBSD") OR - (${CMAKE_SYSTEM_NAME} MATCHES "OpenBSD") OR - (${CMAKE_SYSTEM_NAME} MATCHES "QNX"))) - if (LWS_WITH_SHARED) - target_link_libraries(websockets_shared dl) - endif() + if (LWS_WITH_SHARED) + target_link_libraries(websockets_shared ${CMAKE_DL_LIBS}) endif() endif() @ 1.1 log @libwebsockets: don't hardcode linking to libdl don't link to libdl directly use CMAKE_DL_LIBS instead pointed out by greg troxel on tech-pkg @ text @d1 1 a1 1 $NetBSD$ a3 2 * Link to dl privtely so that it is not in the list of libs that is linked to if linking to websockets_shared d18 1 a18 1 + target_link_libraries(websockets_shared PRIVATE ${CMAKE_DL_LIBS}) @