head 1.1; branch 1.1.1; access; symbols netbsd-11-0-RC4:1.1.1.5 netbsd-11-0-RC3:1.1.1.5 netbsd-11-0-RC2:1.1.1.5 netbsd-11-0-RC1:1.1.1.5 perseant-exfatfs-base-20250801:1.1.1.5 netbsd-11:1.1.1.5.0.10 netbsd-11-base:1.1.1.5 netbsd-10-1-RELEASE:1.1.1.5 perseant-exfatfs-base-20240630:1.1.1.5 perseant-exfatfs:1.1.1.5.0.8 perseant-exfatfs-base:1.1.1.5 netbsd-8-3-RELEASE:1.1.1.3 netbsd-9-4-RELEASE:1.1.1.4 netbsd-10-0-RELEASE:1.1.1.5 netbsd-10-0-RC6:1.1.1.5 netbsd-10-0-RC5:1.1.1.5 netbsd-10-0-RC4:1.1.1.5 netbsd-10-0-RC3:1.1.1.5 netbsd-10-0-RC2:1.1.1.5 netbsd-10-0-RC1:1.1.1.5 netbsd-10:1.1.1.5.0.6 netbsd-10-base:1.1.1.5 netbsd-9-3-RELEASE:1.1.1.4 cjep_sun2x:1.1.1.5.0.4 cjep_sun2x-base:1.1.1.5 cjep_staticlib_x-base1:1.1.1.5 netbsd-9-2-RELEASE:1.1.1.4 cjep_staticlib_x:1.1.1.5.0.2 cjep_staticlib_x-base:1.1.1.5 netbsd-9-1-RELEASE:1.1.1.4 phil-wifi-20200421:1.1.1.5 phil-wifi-20200411:1.1.1.5 phil-wifi-20200406:1.1.1.5 netbsd-8-2-RELEASE:1.1.1.3 netbsd-9-0-RELEASE:1.1.1.4 netbsd-9-0-RC2:1.1.1.4 netbsd-9-0-RC1:1.1.1.4 netbsd-9:1.1.1.4.0.2 netbsd-9-base:1.1.1.4 phil-wifi-20190609:1.1.1.4 netbsd-8-1-RELEASE:1.1.1.3 netbsd-8-1-RC1:1.1.1.3 pgoyette-compat-merge-20190127:1.1.1.3.24.1 pgoyette-compat-20190127:1.1.1.4 pgoyette-compat-20190118:1.1.1.4 pgoyette-compat-1226:1.1.1.4 pgoyette-compat-1126:1.1.1.4 pgoyette-compat-1020:1.1.1.4 pgoyette-compat-0930:1.1.1.4 pgoyette-compat-0906:1.1.1.4 netbsd-7-2-RELEASE:1.1.1.3 pgoyette-compat-0728:1.1.1.4 clang-337282:1.1.1.4 netbsd-8-0-RELEASE:1.1.1.3 phil-wifi:1.1.1.3.0.26 phil-wifi-base:1.1.1.3 pgoyette-compat-0625:1.1.1.3 netbsd-8-0-RC2:1.1.1.3 pgoyette-compat-0521:1.1.1.3 pgoyette-compat-0502:1.1.1.3 pgoyette-compat-0422:1.1.1.3 netbsd-8-0-RC1:1.1.1.3 pgoyette-compat-0415:1.1.1.3 pgoyette-compat-0407:1.1.1.3 pgoyette-compat-0330:1.1.1.3 pgoyette-compat-0322:1.1.1.3 pgoyette-compat-0315:1.1.1.3 netbsd-7-1-2-RELEASE:1.1.1.3 pgoyette-compat:1.1.1.3.0.24 pgoyette-compat-base:1.1.1.3 netbsd-7-1-1-RELEASE:1.1.1.3 clang-319952:1.1.1.3 matt-nb8-mediatek:1.1.1.3.0.22 matt-nb8-mediatek-base:1.1.1.3 clang-309604:1.1.1.3 perseant-stdc-iso10646:1.1.1.3.0.20 perseant-stdc-iso10646-base:1.1.1.3 netbsd-8:1.1.1.3.0.18 netbsd-8-base:1.1.1.3 prg-localcount2-base3:1.1.1.3 prg-localcount2-base2:1.1.1.3 prg-localcount2-base1:1.1.1.3 prg-localcount2:1.1.1.3.0.16 prg-localcount2-base:1.1.1.3 pgoyette-localcount-20170426:1.1.1.3 bouyer-socketcan-base1:1.1.1.3 pgoyette-localcount-20170320:1.1.1.3 netbsd-7-1:1.1.1.3.0.14 netbsd-7-1-RELEASE:1.1.1.3 netbsd-7-1-RC2:1.1.1.3 clang-294123:1.1.1.3 netbsd-7-nhusb-base-20170116:1.1.1.3 bouyer-socketcan:1.1.1.3.0.12 bouyer-socketcan-base:1.1.1.3 clang-291444:1.1.1.3 pgoyette-localcount-20170107:1.1.1.3 netbsd-7-1-RC1:1.1.1.3 pgoyette-localcount-20161104:1.1.1.3 netbsd-7-0-2-RELEASE:1.1.1.3 localcount-20160914:1.1.1.3 netbsd-7-nhusb:1.1.1.3.0.10 netbsd-7-nhusb-base:1.1.1.3 clang-280599:1.1.1.3 pgoyette-localcount-20160806:1.1.1.3 pgoyette-localcount-20160726:1.1.1.3 pgoyette-localcount:1.1.1.3.0.8 pgoyette-localcount-base:1.1.1.3 netbsd-7-0-1-RELEASE:1.1.1.3 clang-261930:1.1.1.3 netbsd-7-0:1.1.1.3.0.6 netbsd-7-0-RELEASE:1.1.1.3 netbsd-7-0-RC3:1.1.1.3 netbsd-7-0-RC2:1.1.1.3 netbsd-7-0-RC1:1.1.1.3 clang-237755:1.1.1.3 clang-232565:1.1.1.3 clang-227398:1.1.1.3 tls-maxphys-base:1.1.1.3 tls-maxphys:1.1.1.3.0.4 netbsd-7:1.1.1.3.0.2 netbsd-7-base:1.1.1.3 clang-215315:1.1.1.3 clang-209886:1.1.1.3 yamt-pagecache:1.1.1.2.0.4 yamt-pagecache-base9:1.1.1.2 tls-earlyentropy:1.1.1.2.0.2 tls-earlyentropy-base:1.1.1.3 riastradh-xf86-video-intel-2-7-1-pre-2-21-15:1.1.1.2 riastradh-drm2-base3:1.1.1.2 clang-202566:1.1.1.2 clang-201163:1.1.1.2 clang-199312:1.1.1.2 clang-198450:1.1.1.2 clang-196603:1.1.1.1 clang-195771:1.1.1.1 LLVM:1.1.1; locks; strict; comment @// @; 1.1 date 2013.11.28.14.14.49; author joerg; state Exp; branches 1.1.1.1; next ; commitid ow8OybrawrB1f3fx; 1.1.1.1 date 2013.11.28.14.14.49; author joerg; state Exp; branches; next 1.1.1.2; commitid ow8OybrawrB1f3fx; 1.1.1.2 date 2014.01.05.15.38.27; author joerg; state Exp; branches 1.1.1.2.2.1 1.1.1.2.4.1; next 1.1.1.3; commitid wh3aCSIWykURqWjx; 1.1.1.3 date 2014.05.30.18.14.39; author joerg; state Exp; branches 1.1.1.3.4.1 1.1.1.3.24.1 1.1.1.3.26.1; next 1.1.1.4; commitid 8q0kdlBlCn09GACx; 1.1.1.4 date 2018.07.17.18.31.26; author joerg; state Exp; branches; next 1.1.1.5; commitid wDzL46ALjrCZgwKA; 1.1.1.5 date 2019.11.13.22.19.19; author joerg; state dead; branches; next ; commitid QD8YATxuNG34YJKB; 1.1.1.2.2.1 date 2014.08.10.07.08.06; author tls; state Exp; branches; next ; commitid t01A1TLTYxkpGMLx; 1.1.1.2.4.1 date 2014.01.05.15.38.27; author yamt; state dead; branches; next 1.1.1.2.4.2; commitid WSrDtL5nYAUyiyBx; 1.1.1.2.4.2 date 2014.05.22.16.18.25; author yamt; state Exp; branches; next ; commitid WSrDtL5nYAUyiyBx; 1.1.1.3.4.1 date 2014.05.30.18.14.39; author tls; state dead; branches; next 1.1.1.3.4.2; commitid jTnpym9Qu0o4R1Nx; 1.1.1.3.4.2 date 2014.08.19.23.47.25; author tls; state Exp; branches; next ; commitid jTnpym9Qu0o4R1Nx; 1.1.1.3.24.1 date 2018.07.28.04.33.15; author pgoyette; state Exp; branches; next ; commitid 1UP1xAIUxv1ZgRLA; 1.1.1.3.26.1 date 2019.06.10.21.45.18; author christos; state Exp; branches; next 1.1.1.3.26.2; commitid jtc8rnCzWiEEHGqB; 1.1.1.3.26.2 date 2020.04.13.07.46.29; author martin; state dead; branches; next ; commitid X01YhRUPVUDaec4C; desc @@ 1.1 log @Initial revision @ text @//===--- TransUnbridgedCasts.cpp - Transformations to ARC mode ------------===// // // The LLVM Compiler Infrastructure // // This file is distributed under the University of Illinois Open Source // License. See LICENSE.TXT for details. // //===----------------------------------------------------------------------===// // // rewriteUnbridgedCasts: // // A cast of non-objc pointer to an objc one is checked. If the non-objc pointer // is from a file-level variable, __bridge cast is used to convert it. // For the result of a function call that we know is +1/+0, // __bridge/CFBridgingRelease is used. // // NSString *str = (NSString *)kUTTypePlainText; // str = b ? kUTTypeRTF : kUTTypePlainText; // NSString *_uuidString = (NSString *)CFUUIDCreateString(kCFAllocatorDefault, // _uuid); // ----> // NSString *str = (__bridge NSString *)kUTTypePlainText; // str = (__bridge NSString *)(b ? kUTTypeRTF : kUTTypePlainText); // NSString *_uuidString = (NSString *) // CFBridgingRelease(CFUUIDCreateString(kCFAllocatorDefault, _uuid)); // // For a C pointer to ObjC, for casting 'self', __bridge is used. // // CFStringRef str = (CFStringRef)self; // ----> // CFStringRef str = (__bridge CFStringRef)self; // // Uses of Block_copy/Block_release macros are rewritten: // // c = Block_copy(b); // Block_release(c); // ----> // c = [b copy]; // // //===----------------------------------------------------------------------===// #include "Transforms.h" #include "Internals.h" #include "clang/AST/ASTContext.h" #include "clang/AST/Attr.h" #include "clang/AST/ParentMap.h" #include "clang/Analysis/DomainSpecific/CocoaConventions.h" #include "clang/Basic/SourceManager.h" #include "clang/Lex/Lexer.h" #include "clang/Sema/SemaDiagnostic.h" #include "llvm/ADT/SmallString.h" using namespace clang; using namespace arcmt; using namespace trans; namespace { class UnbridgedCastRewriter : public RecursiveASTVisitor{ MigrationPass &Pass; IdentifierInfo *SelfII; OwningPtr StmtMap; Decl *ParentD; Stmt *Body; mutable OwningPtr Removables; public: UnbridgedCastRewriter(MigrationPass &pass) : Pass(pass), ParentD(0), Body(0) { SelfII = &Pass.Ctx.Idents.get("self"); } void transformBody(Stmt *body, Decl *ParentD) { this->ParentD = ParentD; Body = body; StmtMap.reset(new ParentMap(body)); TraverseStmt(body); } bool TraverseBlockDecl(BlockDecl *D) { // ParentMap does not enter into a BlockDecl to record its stmts, so use a // new UnbridgedCastRewriter to handle the block. UnbridgedCastRewriter(Pass).transformBody(D->getBody(), D); return true; } bool VisitCastExpr(CastExpr *E) { if (E->getCastKind() != CK_CPointerToObjCPointerCast && E->getCastKind() != CK_BitCast && E->getCastKind() != CK_AnyPointerToBlockPointerCast) return true; QualType castType = E->getType(); Expr *castExpr = E->getSubExpr(); QualType castExprType = castExpr->getType(); if (castType->isObjCRetainableType() == castExprType->isObjCRetainableType()) return true; bool exprRetainable = castExprType->isObjCIndirectLifetimeType(); bool castRetainable = castType->isObjCIndirectLifetimeType(); if (exprRetainable == castRetainable) return true; if (castExpr->isNullPointerConstant(Pass.Ctx, Expr::NPC_ValueDependentIsNull)) return true; SourceLocation loc = castExpr->getExprLoc(); if (loc.isValid() && Pass.Ctx.getSourceManager().isInSystemHeader(loc)) return true; if (castType->isObjCRetainableType()) transformNonObjCToObjCCast(E); else transformObjCToNonObjCCast(E); return true; } private: void transformNonObjCToObjCCast(CastExpr *E) { if (!E) return; // Global vars are assumed that are cast as unretained. if (isGlobalVar(E)) if (E->getSubExpr()->getType()->isPointerType()) { castToObjCObject(E, /*retained=*/false); return; } // If the cast is directly over the result of a Core Foundation function // try to figure out whether it should be cast as retained or unretained. Expr *inner = E->IgnoreParenCasts(); if (CallExpr *callE = dyn_cast(inner)) { if (FunctionDecl *FD = callE->getDirectCallee()) { if (FD->getAttr()) { castToObjCObject(E, /*retained=*/true); return; } if (FD->getAttr()) { castToObjCObject(E, /*retained=*/false); return; } if (FD->isGlobal() && FD->getIdentifier() && ento::cocoa::isRefType(E->getSubExpr()->getType(), "CF", FD->getIdentifier()->getName())) { StringRef fname = FD->getIdentifier()->getName(); if (fname.endswith("Retain") || fname.find("Create") != StringRef::npos || fname.find("Copy") != StringRef::npos) { // Do not migrate to couple of bridge transfer casts which // cancel each other out. Leave it unchanged so error gets user // attention instead. if (FD->getName() == "CFRetain" && FD->getNumParams() == 1 && FD->getParent()->isTranslationUnit() && FD->isExternallyVisible()) { Expr *Arg = callE->getArg(0); if (const ImplicitCastExpr *ICE = dyn_cast(Arg)) { const Expr *sub = ICE->getSubExpr(); QualType T = sub->getType(); if (T->isObjCObjectPointerType()) return; } } castToObjCObject(E, /*retained=*/true); return; } if (fname.find("Get") != StringRef::npos) { castToObjCObject(E, /*retained=*/false); return; } } } } // If returning an ivar or a member of an ivar from a +0 method, use // a __bridge cast. Expr *base = inner->IgnoreParenImpCasts(); while (isa(base)) base = cast(base)->getBase()->IgnoreParenImpCasts(); if (isa(base) && isa(StmtMap->getParentIgnoreParenCasts(E))) { if (ObjCMethodDecl *method = dyn_cast_or_null(ParentD)) { if (!method->hasAttr()) { castToObjCObject(E, /*retained=*/false); return; } } } } void castToObjCObject(CastExpr *E, bool retained) { rewriteToBridgedCast(E, retained ? OBC_BridgeTransfer : OBC_Bridge); } void rewriteToBridgedCast(CastExpr *E, ObjCBridgeCastKind Kind) { Transaction Trans(Pass.TA); rewriteToBridgedCast(E, Kind, Trans); } void rewriteToBridgedCast(CastExpr *E, ObjCBridgeCastKind Kind, Transaction &Trans) { TransformActions &TA = Pass.TA; // We will remove the compiler diagnostic. if (!TA.hasDiagnostic(diag::err_arc_mismatched_cast, diag::err_arc_cast_requires_bridge, E->getLocStart())) { Trans.abort(); return; } StringRef bridge; switch(Kind) { case OBC_Bridge: bridge = "__bridge "; break; case OBC_BridgeTransfer: bridge = "__bridge_transfer "; break; case OBC_BridgeRetained: bridge = "__bridge_retained "; break; } TA.clearDiagnostic(diag::err_arc_mismatched_cast, diag::err_arc_cast_requires_bridge, E->getLocStart()); if (Kind == OBC_Bridge || !Pass.CFBridgingFunctionsDefined()) { if (CStyleCastExpr *CCE = dyn_cast(E)) { TA.insertAfterToken(CCE->getLParenLoc(), bridge); } else { SourceLocation insertLoc = E->getSubExpr()->getLocStart(); SmallString<128> newCast; newCast += '('; newCast += bridge; newCast += E->getType().getAsString(Pass.Ctx.getPrintingPolicy()); newCast += ')'; if (isa(E->getSubExpr())) { TA.insert(insertLoc, newCast.str()); } else { newCast += '('; TA.insert(insertLoc, newCast.str()); TA.insertAfterToken(E->getLocEnd(), ")"); } } } else { assert(Kind == OBC_BridgeTransfer || Kind == OBC_BridgeRetained); SmallString<32> BridgeCall; Expr *WrapE = E->getSubExpr(); SourceLocation InsertLoc = WrapE->getLocStart(); SourceManager &SM = Pass.Ctx.getSourceManager(); char PrevChar = *SM.getCharacterData(InsertLoc.getLocWithOffset(-1)); if (Lexer::isIdentifierBodyChar(PrevChar, Pass.Ctx.getLangOpts())) BridgeCall += ' '; if (Kind == OBC_BridgeTransfer) BridgeCall += "CFBridgingRelease"; else BridgeCall += "CFBridgingRetain"; if (isa(WrapE)) { TA.insert(InsertLoc, BridgeCall); } else { BridgeCall += '('; TA.insert(InsertLoc, BridgeCall); TA.insertAfterToken(WrapE->getLocEnd(), ")"); } } } void rewriteCastForCFRetain(CastExpr *castE, CallExpr *callE) { Transaction Trans(Pass.TA); Pass.TA.replace(callE->getSourceRange(), callE->getArg(0)->getSourceRange()); rewriteToBridgedCast(castE, OBC_BridgeRetained, Trans); } void getBlockMacroRanges(CastExpr *E, SourceRange &Outer, SourceRange &Inner) { SourceManager &SM = Pass.Ctx.getSourceManager(); SourceLocation Loc = E->getExprLoc(); assert(Loc.isMacroID()); SourceLocation MacroBegin, MacroEnd; llvm::tie(MacroBegin, MacroEnd) = SM.getImmediateExpansionRange(Loc); SourceRange SubRange = E->getSubExpr()->IgnoreParenImpCasts()->getSourceRange(); SourceLocation InnerBegin = SM.getImmediateMacroCallerLoc(SubRange.getBegin()); SourceLocation InnerEnd = SM.getImmediateMacroCallerLoc(SubRange.getEnd()); Outer = SourceRange(MacroBegin, MacroEnd); Inner = SourceRange(InnerBegin, InnerEnd); } void rewriteBlockCopyMacro(CastExpr *E) { SourceRange OuterRange, InnerRange; getBlockMacroRanges(E, OuterRange, InnerRange); Transaction Trans(Pass.TA); Pass.TA.replace(OuterRange, InnerRange); Pass.TA.insert(InnerRange.getBegin(), "["); Pass.TA.insertAfterToken(InnerRange.getEnd(), " copy]"); Pass.TA.clearDiagnostic(diag::err_arc_mismatched_cast, diag::err_arc_cast_requires_bridge, OuterRange); } void removeBlockReleaseMacro(CastExpr *E) { SourceRange OuterRange, InnerRange; getBlockMacroRanges(E, OuterRange, InnerRange); Transaction Trans(Pass.TA); Pass.TA.clearDiagnostic(diag::err_arc_mismatched_cast, diag::err_arc_cast_requires_bridge, OuterRange); if (!hasSideEffects(E, Pass.Ctx)) { if (tryRemoving(cast(StmtMap->getParentIgnoreParenCasts(E)))) return; } Pass.TA.replace(OuterRange, InnerRange); } bool tryRemoving(Expr *E) const { if (!Removables) { Removables.reset(new ExprSet); collectRemovables(Body, *Removables); } if (Removables->count(E)) { Pass.TA.removeStmt(E); return true; } return false; } void transformObjCToNonObjCCast(CastExpr *E) { SourceLocation CastLoc = E->getExprLoc(); if (CastLoc.isMacroID()) { StringRef MacroName = Lexer::getImmediateMacroName(CastLoc, Pass.Ctx.getSourceManager(), Pass.Ctx.getLangOpts()); if (MacroName == "Block_copy") { rewriteBlockCopyMacro(E); return; } if (MacroName == "Block_release") { removeBlockReleaseMacro(E); return; } } if (isSelf(E->getSubExpr())) return rewriteToBridgedCast(E, OBC_Bridge); CallExpr *callE; if (isPassedToCFRetain(E, callE)) return rewriteCastForCFRetain(E, callE); ObjCMethodFamily family = getFamilyOfMessage(E->getSubExpr()); if (family == OMF_retain) return rewriteToBridgedCast(E, OBC_BridgeRetained); if (family == OMF_autorelease || family == OMF_release) { std::string err = "it is not safe to cast to '"; err += E->getType().getAsString(Pass.Ctx.getPrintingPolicy()); err += "' the result of '"; err += family == OMF_autorelease ? "autorelease" : "release"; err += "' message; a __bridge cast may result in a pointer to a " "destroyed object and a __bridge_retained may leak the object"; Pass.TA.reportError(err, E->getLocStart(), E->getSubExpr()->getSourceRange()); Stmt *parent = E; do { parent = StmtMap->getParentIgnoreParenImpCasts(parent); } while (parent && isa(parent)); if (ReturnStmt *retS = dyn_cast_or_null(parent)) { std::string note = "remove the cast and change return type of function " "to '"; note += E->getSubExpr()->getType().getAsString(Pass.Ctx.getPrintingPolicy()); note += "' to have the object automatically autoreleased"; Pass.TA.reportNote(note, retS->getLocStart()); } } Expr *subExpr = E->getSubExpr(); // Look through pseudo-object expressions. if (PseudoObjectExpr *pseudo = dyn_cast(subExpr)) { subExpr = pseudo->getResultExpr(); assert(subExpr && "no result for pseudo-object of non-void type?"); } if (ImplicitCastExpr *implCE = dyn_cast(subExpr)) { if (implCE->getCastKind() == CK_ARCConsumeObject) return rewriteToBridgedCast(E, OBC_BridgeRetained); if (implCE->getCastKind() == CK_ARCReclaimReturnedObject) return rewriteToBridgedCast(E, OBC_Bridge); } bool isConsumed = false; if (isPassedToCParamWithKnownOwnership(E, isConsumed)) return rewriteToBridgedCast(E, isConsumed ? OBC_BridgeRetained : OBC_Bridge); } static ObjCMethodFamily getFamilyOfMessage(Expr *E) { E = E->IgnoreParenCasts(); if (ObjCMessageExpr *ME = dyn_cast(E)) return ME->getMethodFamily(); return OMF_None; } bool isPassedToCFRetain(Expr *E, CallExpr *&callE) const { if ((callE = dyn_cast_or_null( StmtMap->getParentIgnoreParenImpCasts(E)))) if (FunctionDecl * FD = dyn_cast_or_null(callE->getCalleeDecl())) if (FD->getName() == "CFRetain" && FD->getNumParams() == 1 && FD->getParent()->isTranslationUnit() && FD->isExternallyVisible()) return true; return false; } bool isPassedToCParamWithKnownOwnership(Expr *E, bool &isConsumed) const { if (CallExpr *callE = dyn_cast_or_null( StmtMap->getParentIgnoreParenImpCasts(E))) if (FunctionDecl * FD = dyn_cast_or_null(callE->getCalleeDecl())) { unsigned i = 0; for (unsigned e = callE->getNumArgs(); i != e; ++i) { Expr *arg = callE->getArg(i); if (arg == E || arg->IgnoreParenImpCasts() == E) break; } if (i < callE->getNumArgs() && i < FD->getNumParams()) { ParmVarDecl *PD = FD->getParamDecl(i); if (PD->getAttr()) { isConsumed = true; return true; } } } return false; } bool isSelf(Expr *E) const { E = E->IgnoreParenLValueCasts(); if (DeclRefExpr *DRE = dyn_cast(E)) if (ImplicitParamDecl *IPD = dyn_cast(DRE->getDecl())) if (IPD->getIdentifier() == SelfII) return true; return false; } }; } // end anonymous namespace void trans::rewriteUnbridgedCasts(MigrationPass &pass) { BodyTransform trans(pass); trans.TraverseDecl(pass.Ctx.getTranslationUnitDecl()); } @ 1.1.1.1 log @Import Clang 3.4rc1 r195771. @ text @@ 1.1.1.2 log @Import clang 3.5svn r198450. @ text @d136 1 a136 1 if (FD->hasAttr()) { d140 1 a140 1 if (FD->hasAttr()) { d442 1 a442 1 if (PD->hasAttr()) { @ 1.1.1.2.2.1 log @Rebase. @ text @d63 1 a63 1 std::unique_ptr StmtMap; d66 1 a66 1 mutable std::unique_ptr Removables; d69 1 a69 2 UnbridgedCastRewriter(MigrationPass &pass) : Pass(pass), ParentD(nullptr), Body(nullptr) { d286 1 a286 1 std::tie(MacroBegin, MacroEnd) = SM.getImmediateExpansionRange(Loc); @ 1.1.1.3 log @Import Clang 3.5svn r209886. @ text @d63 1 a63 1 std::unique_ptr StmtMap; d66 1 a66 1 mutable std::unique_ptr Removables; d69 1 a69 2 UnbridgedCastRewriter(MigrationPass &pass) : Pass(pass), ParentD(nullptr), Body(nullptr) { d286 1 a286 1 std::tie(MacroBegin, MacroEnd) = SM.getImmediateExpansionRange(Loc); @ 1.1.1.3.26.1 log @Sync with HEAD @ text @d286 2 a287 1 CharSourceRange MacroRange = SM.getImmediateExpansionRange(Loc); d292 1 a292 1 Outer = MacroRange.getAsRange(); @ 1.1.1.3.26.2 log @Mostly merge changes from HEAD upto 20200411 @ text @@ 1.1.1.3.24.1 log @Sync with HEAD @ text @d286 2 a287 1 CharSourceRange MacroRange = SM.getImmediateExpansionRange(Loc); d292 1 a292 1 Outer = MacroRange.getAsRange(); @ 1.1.1.4 log @Import clang r337282 from trunk @ text @d286 2 a287 1 CharSourceRange MacroRange = SM.getImmediateExpansionRange(Loc); d292 1 a292 1 Outer = MacroRange.getAsRange(); @ 1.1.1.5 log @Mark old LLVM instance as dead. @ text @@ 1.1.1.3.4.1 log @file TransUnbridgedCasts.cpp was added on branch tls-maxphys on 2014-08-19 23:47:25 +0000 @ text @d1 469 @ 1.1.1.3.4.2 log @Rebase to HEAD as of a few days ago. @ text @a0 469 //===--- TransUnbridgedCasts.cpp - Transformations to ARC mode ------------===// // // The LLVM Compiler Infrastructure // // This file is distributed under the University of Illinois Open Source // License. See LICENSE.TXT for details. // //===----------------------------------------------------------------------===// // // rewriteUnbridgedCasts: // // A cast of non-objc pointer to an objc one is checked. If the non-objc pointer // is from a file-level variable, __bridge cast is used to convert it. // For the result of a function call that we know is +1/+0, // __bridge/CFBridgingRelease is used. // // NSString *str = (NSString *)kUTTypePlainText; // str = b ? kUTTypeRTF : kUTTypePlainText; // NSString *_uuidString = (NSString *)CFUUIDCreateString(kCFAllocatorDefault, // _uuid); // ----> // NSString *str = (__bridge NSString *)kUTTypePlainText; // str = (__bridge NSString *)(b ? kUTTypeRTF : kUTTypePlainText); // NSString *_uuidString = (NSString *) // CFBridgingRelease(CFUUIDCreateString(kCFAllocatorDefault, _uuid)); // // For a C pointer to ObjC, for casting 'self', __bridge is used. // // CFStringRef str = (CFStringRef)self; // ----> // CFStringRef str = (__bridge CFStringRef)self; // // Uses of Block_copy/Block_release macros are rewritten: // // c = Block_copy(b); // Block_release(c); // ----> // c = [b copy]; // // //===----------------------------------------------------------------------===// #include "Transforms.h" #include "Internals.h" #include "clang/AST/ASTContext.h" #include "clang/AST/Attr.h" #include "clang/AST/ParentMap.h" #include "clang/Analysis/DomainSpecific/CocoaConventions.h" #include "clang/Basic/SourceManager.h" #include "clang/Lex/Lexer.h" #include "clang/Sema/SemaDiagnostic.h" #include "llvm/ADT/SmallString.h" using namespace clang; using namespace arcmt; using namespace trans; namespace { class UnbridgedCastRewriter : public RecursiveASTVisitor{ MigrationPass &Pass; IdentifierInfo *SelfII; std::unique_ptr StmtMap; Decl *ParentD; Stmt *Body; mutable std::unique_ptr Removables; public: UnbridgedCastRewriter(MigrationPass &pass) : Pass(pass), ParentD(nullptr), Body(nullptr) { SelfII = &Pass.Ctx.Idents.get("self"); } void transformBody(Stmt *body, Decl *ParentD) { this->ParentD = ParentD; Body = body; StmtMap.reset(new ParentMap(body)); TraverseStmt(body); } bool TraverseBlockDecl(BlockDecl *D) { // ParentMap does not enter into a BlockDecl to record its stmts, so use a // new UnbridgedCastRewriter to handle the block. UnbridgedCastRewriter(Pass).transformBody(D->getBody(), D); return true; } bool VisitCastExpr(CastExpr *E) { if (E->getCastKind() != CK_CPointerToObjCPointerCast && E->getCastKind() != CK_BitCast && E->getCastKind() != CK_AnyPointerToBlockPointerCast) return true; QualType castType = E->getType(); Expr *castExpr = E->getSubExpr(); QualType castExprType = castExpr->getType(); if (castType->isObjCRetainableType() == castExprType->isObjCRetainableType()) return true; bool exprRetainable = castExprType->isObjCIndirectLifetimeType(); bool castRetainable = castType->isObjCIndirectLifetimeType(); if (exprRetainable == castRetainable) return true; if (castExpr->isNullPointerConstant(Pass.Ctx, Expr::NPC_ValueDependentIsNull)) return true; SourceLocation loc = castExpr->getExprLoc(); if (loc.isValid() && Pass.Ctx.getSourceManager().isInSystemHeader(loc)) return true; if (castType->isObjCRetainableType()) transformNonObjCToObjCCast(E); else transformObjCToNonObjCCast(E); return true; } private: void transformNonObjCToObjCCast(CastExpr *E) { if (!E) return; // Global vars are assumed that are cast as unretained. if (isGlobalVar(E)) if (E->getSubExpr()->getType()->isPointerType()) { castToObjCObject(E, /*retained=*/false); return; } // If the cast is directly over the result of a Core Foundation function // try to figure out whether it should be cast as retained or unretained. Expr *inner = E->IgnoreParenCasts(); if (CallExpr *callE = dyn_cast(inner)) { if (FunctionDecl *FD = callE->getDirectCallee()) { if (FD->hasAttr()) { castToObjCObject(E, /*retained=*/true); return; } if (FD->hasAttr()) { castToObjCObject(E, /*retained=*/false); return; } if (FD->isGlobal() && FD->getIdentifier() && ento::cocoa::isRefType(E->getSubExpr()->getType(), "CF", FD->getIdentifier()->getName())) { StringRef fname = FD->getIdentifier()->getName(); if (fname.endswith("Retain") || fname.find("Create") != StringRef::npos || fname.find("Copy") != StringRef::npos) { // Do not migrate to couple of bridge transfer casts which // cancel each other out. Leave it unchanged so error gets user // attention instead. if (FD->getName() == "CFRetain" && FD->getNumParams() == 1 && FD->getParent()->isTranslationUnit() && FD->isExternallyVisible()) { Expr *Arg = callE->getArg(0); if (const ImplicitCastExpr *ICE = dyn_cast(Arg)) { const Expr *sub = ICE->getSubExpr(); QualType T = sub->getType(); if (T->isObjCObjectPointerType()) return; } } castToObjCObject(E, /*retained=*/true); return; } if (fname.find("Get") != StringRef::npos) { castToObjCObject(E, /*retained=*/false); return; } } } } // If returning an ivar or a member of an ivar from a +0 method, use // a __bridge cast. Expr *base = inner->IgnoreParenImpCasts(); while (isa(base)) base = cast(base)->getBase()->IgnoreParenImpCasts(); if (isa(base) && isa(StmtMap->getParentIgnoreParenCasts(E))) { if (ObjCMethodDecl *method = dyn_cast_or_null(ParentD)) { if (!method->hasAttr()) { castToObjCObject(E, /*retained=*/false); return; } } } } void castToObjCObject(CastExpr *E, bool retained) { rewriteToBridgedCast(E, retained ? OBC_BridgeTransfer : OBC_Bridge); } void rewriteToBridgedCast(CastExpr *E, ObjCBridgeCastKind Kind) { Transaction Trans(Pass.TA); rewriteToBridgedCast(E, Kind, Trans); } void rewriteToBridgedCast(CastExpr *E, ObjCBridgeCastKind Kind, Transaction &Trans) { TransformActions &TA = Pass.TA; // We will remove the compiler diagnostic. if (!TA.hasDiagnostic(diag::err_arc_mismatched_cast, diag::err_arc_cast_requires_bridge, E->getLocStart())) { Trans.abort(); return; } StringRef bridge; switch(Kind) { case OBC_Bridge: bridge = "__bridge "; break; case OBC_BridgeTransfer: bridge = "__bridge_transfer "; break; case OBC_BridgeRetained: bridge = "__bridge_retained "; break; } TA.clearDiagnostic(diag::err_arc_mismatched_cast, diag::err_arc_cast_requires_bridge, E->getLocStart()); if (Kind == OBC_Bridge || !Pass.CFBridgingFunctionsDefined()) { if (CStyleCastExpr *CCE = dyn_cast(E)) { TA.insertAfterToken(CCE->getLParenLoc(), bridge); } else { SourceLocation insertLoc = E->getSubExpr()->getLocStart(); SmallString<128> newCast; newCast += '('; newCast += bridge; newCast += E->getType().getAsString(Pass.Ctx.getPrintingPolicy()); newCast += ')'; if (isa(E->getSubExpr())) { TA.insert(insertLoc, newCast.str()); } else { newCast += '('; TA.insert(insertLoc, newCast.str()); TA.insertAfterToken(E->getLocEnd(), ")"); } } } else { assert(Kind == OBC_BridgeTransfer || Kind == OBC_BridgeRetained); SmallString<32> BridgeCall; Expr *WrapE = E->getSubExpr(); SourceLocation InsertLoc = WrapE->getLocStart(); SourceManager &SM = Pass.Ctx.getSourceManager(); char PrevChar = *SM.getCharacterData(InsertLoc.getLocWithOffset(-1)); if (Lexer::isIdentifierBodyChar(PrevChar, Pass.Ctx.getLangOpts())) BridgeCall += ' '; if (Kind == OBC_BridgeTransfer) BridgeCall += "CFBridgingRelease"; else BridgeCall += "CFBridgingRetain"; if (isa(WrapE)) { TA.insert(InsertLoc, BridgeCall); } else { BridgeCall += '('; TA.insert(InsertLoc, BridgeCall); TA.insertAfterToken(WrapE->getLocEnd(), ")"); } } } void rewriteCastForCFRetain(CastExpr *castE, CallExpr *callE) { Transaction Trans(Pass.TA); Pass.TA.replace(callE->getSourceRange(), callE->getArg(0)->getSourceRange()); rewriteToBridgedCast(castE, OBC_BridgeRetained, Trans); } void getBlockMacroRanges(CastExpr *E, SourceRange &Outer, SourceRange &Inner) { SourceManager &SM = Pass.Ctx.getSourceManager(); SourceLocation Loc = E->getExprLoc(); assert(Loc.isMacroID()); SourceLocation MacroBegin, MacroEnd; std::tie(MacroBegin, MacroEnd) = SM.getImmediateExpansionRange(Loc); SourceRange SubRange = E->getSubExpr()->IgnoreParenImpCasts()->getSourceRange(); SourceLocation InnerBegin = SM.getImmediateMacroCallerLoc(SubRange.getBegin()); SourceLocation InnerEnd = SM.getImmediateMacroCallerLoc(SubRange.getEnd()); Outer = SourceRange(MacroBegin, MacroEnd); Inner = SourceRange(InnerBegin, InnerEnd); } void rewriteBlockCopyMacro(CastExpr *E) { SourceRange OuterRange, InnerRange; getBlockMacroRanges(E, OuterRange, InnerRange); Transaction Trans(Pass.TA); Pass.TA.replace(OuterRange, InnerRange); Pass.TA.insert(InnerRange.getBegin(), "["); Pass.TA.insertAfterToken(InnerRange.getEnd(), " copy]"); Pass.TA.clearDiagnostic(diag::err_arc_mismatched_cast, diag::err_arc_cast_requires_bridge, OuterRange); } void removeBlockReleaseMacro(CastExpr *E) { SourceRange OuterRange, InnerRange; getBlockMacroRanges(E, OuterRange, InnerRange); Transaction Trans(Pass.TA); Pass.TA.clearDiagnostic(diag::err_arc_mismatched_cast, diag::err_arc_cast_requires_bridge, OuterRange); if (!hasSideEffects(E, Pass.Ctx)) { if (tryRemoving(cast(StmtMap->getParentIgnoreParenCasts(E)))) return; } Pass.TA.replace(OuterRange, InnerRange); } bool tryRemoving(Expr *E) const { if (!Removables) { Removables.reset(new ExprSet); collectRemovables(Body, *Removables); } if (Removables->count(E)) { Pass.TA.removeStmt(E); return true; } return false; } void transformObjCToNonObjCCast(CastExpr *E) { SourceLocation CastLoc = E->getExprLoc(); if (CastLoc.isMacroID()) { StringRef MacroName = Lexer::getImmediateMacroName(CastLoc, Pass.Ctx.getSourceManager(), Pass.Ctx.getLangOpts()); if (MacroName == "Block_copy") { rewriteBlockCopyMacro(E); return; } if (MacroName == "Block_release") { removeBlockReleaseMacro(E); return; } } if (isSelf(E->getSubExpr())) return rewriteToBridgedCast(E, OBC_Bridge); CallExpr *callE; if (isPassedToCFRetain(E, callE)) return rewriteCastForCFRetain(E, callE); ObjCMethodFamily family = getFamilyOfMessage(E->getSubExpr()); if (family == OMF_retain) return rewriteToBridgedCast(E, OBC_BridgeRetained); if (family == OMF_autorelease || family == OMF_release) { std::string err = "it is not safe to cast to '"; err += E->getType().getAsString(Pass.Ctx.getPrintingPolicy()); err += "' the result of '"; err += family == OMF_autorelease ? "autorelease" : "release"; err += "' message; a __bridge cast may result in a pointer to a " "destroyed object and a __bridge_retained may leak the object"; Pass.TA.reportError(err, E->getLocStart(), E->getSubExpr()->getSourceRange()); Stmt *parent = E; do { parent = StmtMap->getParentIgnoreParenImpCasts(parent); } while (parent && isa(parent)); if (ReturnStmt *retS = dyn_cast_or_null(parent)) { std::string note = "remove the cast and change return type of function " "to '"; note += E->getSubExpr()->getType().getAsString(Pass.Ctx.getPrintingPolicy()); note += "' to have the object automatically autoreleased"; Pass.TA.reportNote(note, retS->getLocStart()); } } Expr *subExpr = E->getSubExpr(); // Look through pseudo-object expressions. if (PseudoObjectExpr *pseudo = dyn_cast(subExpr)) { subExpr = pseudo->getResultExpr(); assert(subExpr && "no result for pseudo-object of non-void type?"); } if (ImplicitCastExpr *implCE = dyn_cast(subExpr)) { if (implCE->getCastKind() == CK_ARCConsumeObject) return rewriteToBridgedCast(E, OBC_BridgeRetained); if (implCE->getCastKind() == CK_ARCReclaimReturnedObject) return rewriteToBridgedCast(E, OBC_Bridge); } bool isConsumed = false; if (isPassedToCParamWithKnownOwnership(E, isConsumed)) return rewriteToBridgedCast(E, isConsumed ? OBC_BridgeRetained : OBC_Bridge); } static ObjCMethodFamily getFamilyOfMessage(Expr *E) { E = E->IgnoreParenCasts(); if (ObjCMessageExpr *ME = dyn_cast(E)) return ME->getMethodFamily(); return OMF_None; } bool isPassedToCFRetain(Expr *E, CallExpr *&callE) const { if ((callE = dyn_cast_or_null( StmtMap->getParentIgnoreParenImpCasts(E)))) if (FunctionDecl * FD = dyn_cast_or_null(callE->getCalleeDecl())) if (FD->getName() == "CFRetain" && FD->getNumParams() == 1 && FD->getParent()->isTranslationUnit() && FD->isExternallyVisible()) return true; return false; } bool isPassedToCParamWithKnownOwnership(Expr *E, bool &isConsumed) const { if (CallExpr *callE = dyn_cast_or_null( StmtMap->getParentIgnoreParenImpCasts(E))) if (FunctionDecl * FD = dyn_cast_or_null(callE->getCalleeDecl())) { unsigned i = 0; for (unsigned e = callE->getNumArgs(); i != e; ++i) { Expr *arg = callE->getArg(i); if (arg == E || arg->IgnoreParenImpCasts() == E) break; } if (i < callE->getNumArgs() && i < FD->getNumParams()) { ParmVarDecl *PD = FD->getParamDecl(i); if (PD->hasAttr()) { isConsumed = true; return true; } } } return false; } bool isSelf(Expr *E) const { E = E->IgnoreParenLValueCasts(); if (DeclRefExpr *DRE = dyn_cast(E)) if (ImplicitParamDecl *IPD = dyn_cast(DRE->getDecl())) if (IPD->getIdentifier() == SelfII) return true; return false; } }; } // end anonymous namespace void trans::rewriteUnbridgedCasts(MigrationPass &pass) { BodyTransform trans(pass); trans.TraverseDecl(pass.Ctx.getTranslationUnitDecl()); } @ 1.1.1.2.4.1 log @file TransUnbridgedCasts.cpp was added on branch yamt-pagecache on 2014-05-22 16:18:25 +0000 @ text @d1 468 @ 1.1.1.2.4.2 log @sync with head. for a reference, the tree before this commit was tagged as yamt-pagecache-tag8. this commit was splitted into small chunks to avoid a limitation of cvs. ("Protocol error: too many arguments") @ text @a0 468 //===--- TransUnbridgedCasts.cpp - Transformations to ARC mode ------------===// // // The LLVM Compiler Infrastructure // // This file is distributed under the University of Illinois Open Source // License. See LICENSE.TXT for details. // //===----------------------------------------------------------------------===// // // rewriteUnbridgedCasts: // // A cast of non-objc pointer to an objc one is checked. If the non-objc pointer // is from a file-level variable, __bridge cast is used to convert it. // For the result of a function call that we know is +1/+0, // __bridge/CFBridgingRelease is used. // // NSString *str = (NSString *)kUTTypePlainText; // str = b ? kUTTypeRTF : kUTTypePlainText; // NSString *_uuidString = (NSString *)CFUUIDCreateString(kCFAllocatorDefault, // _uuid); // ----> // NSString *str = (__bridge NSString *)kUTTypePlainText; // str = (__bridge NSString *)(b ? kUTTypeRTF : kUTTypePlainText); // NSString *_uuidString = (NSString *) // CFBridgingRelease(CFUUIDCreateString(kCFAllocatorDefault, _uuid)); // // For a C pointer to ObjC, for casting 'self', __bridge is used. // // CFStringRef str = (CFStringRef)self; // ----> // CFStringRef str = (__bridge CFStringRef)self; // // Uses of Block_copy/Block_release macros are rewritten: // // c = Block_copy(b); // Block_release(c); // ----> // c = [b copy]; // // //===----------------------------------------------------------------------===// #include "Transforms.h" #include "Internals.h" #include "clang/AST/ASTContext.h" #include "clang/AST/Attr.h" #include "clang/AST/ParentMap.h" #include "clang/Analysis/DomainSpecific/CocoaConventions.h" #include "clang/Basic/SourceManager.h" #include "clang/Lex/Lexer.h" #include "clang/Sema/SemaDiagnostic.h" #include "llvm/ADT/SmallString.h" using namespace clang; using namespace arcmt; using namespace trans; namespace { class UnbridgedCastRewriter : public RecursiveASTVisitor{ MigrationPass &Pass; IdentifierInfo *SelfII; OwningPtr StmtMap; Decl *ParentD; Stmt *Body; mutable OwningPtr Removables; public: UnbridgedCastRewriter(MigrationPass &pass) : Pass(pass), ParentD(0), Body(0) { SelfII = &Pass.Ctx.Idents.get("self"); } void transformBody(Stmt *body, Decl *ParentD) { this->ParentD = ParentD; Body = body; StmtMap.reset(new ParentMap(body)); TraverseStmt(body); } bool TraverseBlockDecl(BlockDecl *D) { // ParentMap does not enter into a BlockDecl to record its stmts, so use a // new UnbridgedCastRewriter to handle the block. UnbridgedCastRewriter(Pass).transformBody(D->getBody(), D); return true; } bool VisitCastExpr(CastExpr *E) { if (E->getCastKind() != CK_CPointerToObjCPointerCast && E->getCastKind() != CK_BitCast && E->getCastKind() != CK_AnyPointerToBlockPointerCast) return true; QualType castType = E->getType(); Expr *castExpr = E->getSubExpr(); QualType castExprType = castExpr->getType(); if (castType->isObjCRetainableType() == castExprType->isObjCRetainableType()) return true; bool exprRetainable = castExprType->isObjCIndirectLifetimeType(); bool castRetainable = castType->isObjCIndirectLifetimeType(); if (exprRetainable == castRetainable) return true; if (castExpr->isNullPointerConstant(Pass.Ctx, Expr::NPC_ValueDependentIsNull)) return true; SourceLocation loc = castExpr->getExprLoc(); if (loc.isValid() && Pass.Ctx.getSourceManager().isInSystemHeader(loc)) return true; if (castType->isObjCRetainableType()) transformNonObjCToObjCCast(E); else transformObjCToNonObjCCast(E); return true; } private: void transformNonObjCToObjCCast(CastExpr *E) { if (!E) return; // Global vars are assumed that are cast as unretained. if (isGlobalVar(E)) if (E->getSubExpr()->getType()->isPointerType()) { castToObjCObject(E, /*retained=*/false); return; } // If the cast is directly over the result of a Core Foundation function // try to figure out whether it should be cast as retained or unretained. Expr *inner = E->IgnoreParenCasts(); if (CallExpr *callE = dyn_cast(inner)) { if (FunctionDecl *FD = callE->getDirectCallee()) { if (FD->hasAttr()) { castToObjCObject(E, /*retained=*/true); return; } if (FD->hasAttr()) { castToObjCObject(E, /*retained=*/false); return; } if (FD->isGlobal() && FD->getIdentifier() && ento::cocoa::isRefType(E->getSubExpr()->getType(), "CF", FD->getIdentifier()->getName())) { StringRef fname = FD->getIdentifier()->getName(); if (fname.endswith("Retain") || fname.find("Create") != StringRef::npos || fname.find("Copy") != StringRef::npos) { // Do not migrate to couple of bridge transfer casts which // cancel each other out. Leave it unchanged so error gets user // attention instead. if (FD->getName() == "CFRetain" && FD->getNumParams() == 1 && FD->getParent()->isTranslationUnit() && FD->isExternallyVisible()) { Expr *Arg = callE->getArg(0); if (const ImplicitCastExpr *ICE = dyn_cast(Arg)) { const Expr *sub = ICE->getSubExpr(); QualType T = sub->getType(); if (T->isObjCObjectPointerType()) return; } } castToObjCObject(E, /*retained=*/true); return; } if (fname.find("Get") != StringRef::npos) { castToObjCObject(E, /*retained=*/false); return; } } } } // If returning an ivar or a member of an ivar from a +0 method, use // a __bridge cast. Expr *base = inner->IgnoreParenImpCasts(); while (isa(base)) base = cast(base)->getBase()->IgnoreParenImpCasts(); if (isa(base) && isa(StmtMap->getParentIgnoreParenCasts(E))) { if (ObjCMethodDecl *method = dyn_cast_or_null(ParentD)) { if (!method->hasAttr()) { castToObjCObject(E, /*retained=*/false); return; } } } } void castToObjCObject(CastExpr *E, bool retained) { rewriteToBridgedCast(E, retained ? OBC_BridgeTransfer : OBC_Bridge); } void rewriteToBridgedCast(CastExpr *E, ObjCBridgeCastKind Kind) { Transaction Trans(Pass.TA); rewriteToBridgedCast(E, Kind, Trans); } void rewriteToBridgedCast(CastExpr *E, ObjCBridgeCastKind Kind, Transaction &Trans) { TransformActions &TA = Pass.TA; // We will remove the compiler diagnostic. if (!TA.hasDiagnostic(diag::err_arc_mismatched_cast, diag::err_arc_cast_requires_bridge, E->getLocStart())) { Trans.abort(); return; } StringRef bridge; switch(Kind) { case OBC_Bridge: bridge = "__bridge "; break; case OBC_BridgeTransfer: bridge = "__bridge_transfer "; break; case OBC_BridgeRetained: bridge = "__bridge_retained "; break; } TA.clearDiagnostic(diag::err_arc_mismatched_cast, diag::err_arc_cast_requires_bridge, E->getLocStart()); if (Kind == OBC_Bridge || !Pass.CFBridgingFunctionsDefined()) { if (CStyleCastExpr *CCE = dyn_cast(E)) { TA.insertAfterToken(CCE->getLParenLoc(), bridge); } else { SourceLocation insertLoc = E->getSubExpr()->getLocStart(); SmallString<128> newCast; newCast += '('; newCast += bridge; newCast += E->getType().getAsString(Pass.Ctx.getPrintingPolicy()); newCast += ')'; if (isa(E->getSubExpr())) { TA.insert(insertLoc, newCast.str()); } else { newCast += '('; TA.insert(insertLoc, newCast.str()); TA.insertAfterToken(E->getLocEnd(), ")"); } } } else { assert(Kind == OBC_BridgeTransfer || Kind == OBC_BridgeRetained); SmallString<32> BridgeCall; Expr *WrapE = E->getSubExpr(); SourceLocation InsertLoc = WrapE->getLocStart(); SourceManager &SM = Pass.Ctx.getSourceManager(); char PrevChar = *SM.getCharacterData(InsertLoc.getLocWithOffset(-1)); if (Lexer::isIdentifierBodyChar(PrevChar, Pass.Ctx.getLangOpts())) BridgeCall += ' '; if (Kind == OBC_BridgeTransfer) BridgeCall += "CFBridgingRelease"; else BridgeCall += "CFBridgingRetain"; if (isa(WrapE)) { TA.insert(InsertLoc, BridgeCall); } else { BridgeCall += '('; TA.insert(InsertLoc, BridgeCall); TA.insertAfterToken(WrapE->getLocEnd(), ")"); } } } void rewriteCastForCFRetain(CastExpr *castE, CallExpr *callE) { Transaction Trans(Pass.TA); Pass.TA.replace(callE->getSourceRange(), callE->getArg(0)->getSourceRange()); rewriteToBridgedCast(castE, OBC_BridgeRetained, Trans); } void getBlockMacroRanges(CastExpr *E, SourceRange &Outer, SourceRange &Inner) { SourceManager &SM = Pass.Ctx.getSourceManager(); SourceLocation Loc = E->getExprLoc(); assert(Loc.isMacroID()); SourceLocation MacroBegin, MacroEnd; llvm::tie(MacroBegin, MacroEnd) = SM.getImmediateExpansionRange(Loc); SourceRange SubRange = E->getSubExpr()->IgnoreParenImpCasts()->getSourceRange(); SourceLocation InnerBegin = SM.getImmediateMacroCallerLoc(SubRange.getBegin()); SourceLocation InnerEnd = SM.getImmediateMacroCallerLoc(SubRange.getEnd()); Outer = SourceRange(MacroBegin, MacroEnd); Inner = SourceRange(InnerBegin, InnerEnd); } void rewriteBlockCopyMacro(CastExpr *E) { SourceRange OuterRange, InnerRange; getBlockMacroRanges(E, OuterRange, InnerRange); Transaction Trans(Pass.TA); Pass.TA.replace(OuterRange, InnerRange); Pass.TA.insert(InnerRange.getBegin(), "["); Pass.TA.insertAfterToken(InnerRange.getEnd(), " copy]"); Pass.TA.clearDiagnostic(diag::err_arc_mismatched_cast, diag::err_arc_cast_requires_bridge, OuterRange); } void removeBlockReleaseMacro(CastExpr *E) { SourceRange OuterRange, InnerRange; getBlockMacroRanges(E, OuterRange, InnerRange); Transaction Trans(Pass.TA); Pass.TA.clearDiagnostic(diag::err_arc_mismatched_cast, diag::err_arc_cast_requires_bridge, OuterRange); if (!hasSideEffects(E, Pass.Ctx)) { if (tryRemoving(cast(StmtMap->getParentIgnoreParenCasts(E)))) return; } Pass.TA.replace(OuterRange, InnerRange); } bool tryRemoving(Expr *E) const { if (!Removables) { Removables.reset(new ExprSet); collectRemovables(Body, *Removables); } if (Removables->count(E)) { Pass.TA.removeStmt(E); return true; } return false; } void transformObjCToNonObjCCast(CastExpr *E) { SourceLocation CastLoc = E->getExprLoc(); if (CastLoc.isMacroID()) { StringRef MacroName = Lexer::getImmediateMacroName(CastLoc, Pass.Ctx.getSourceManager(), Pass.Ctx.getLangOpts()); if (MacroName == "Block_copy") { rewriteBlockCopyMacro(E); return; } if (MacroName == "Block_release") { removeBlockReleaseMacro(E); return; } } if (isSelf(E->getSubExpr())) return rewriteToBridgedCast(E, OBC_Bridge); CallExpr *callE; if (isPassedToCFRetain(E, callE)) return rewriteCastForCFRetain(E, callE); ObjCMethodFamily family = getFamilyOfMessage(E->getSubExpr()); if (family == OMF_retain) return rewriteToBridgedCast(E, OBC_BridgeRetained); if (family == OMF_autorelease || family == OMF_release) { std::string err = "it is not safe to cast to '"; err += E->getType().getAsString(Pass.Ctx.getPrintingPolicy()); err += "' the result of '"; err += family == OMF_autorelease ? "autorelease" : "release"; err += "' message; a __bridge cast may result in a pointer to a " "destroyed object and a __bridge_retained may leak the object"; Pass.TA.reportError(err, E->getLocStart(), E->getSubExpr()->getSourceRange()); Stmt *parent = E; do { parent = StmtMap->getParentIgnoreParenImpCasts(parent); } while (parent && isa(parent)); if (ReturnStmt *retS = dyn_cast_or_null(parent)) { std::string note = "remove the cast and change return type of function " "to '"; note += E->getSubExpr()->getType().getAsString(Pass.Ctx.getPrintingPolicy()); note += "' to have the object automatically autoreleased"; Pass.TA.reportNote(note, retS->getLocStart()); } } Expr *subExpr = E->getSubExpr(); // Look through pseudo-object expressions. if (PseudoObjectExpr *pseudo = dyn_cast(subExpr)) { subExpr = pseudo->getResultExpr(); assert(subExpr && "no result for pseudo-object of non-void type?"); } if (ImplicitCastExpr *implCE = dyn_cast(subExpr)) { if (implCE->getCastKind() == CK_ARCConsumeObject) return rewriteToBridgedCast(E, OBC_BridgeRetained); if (implCE->getCastKind() == CK_ARCReclaimReturnedObject) return rewriteToBridgedCast(E, OBC_Bridge); } bool isConsumed = false; if (isPassedToCParamWithKnownOwnership(E, isConsumed)) return rewriteToBridgedCast(E, isConsumed ? OBC_BridgeRetained : OBC_Bridge); } static ObjCMethodFamily getFamilyOfMessage(Expr *E) { E = E->IgnoreParenCasts(); if (ObjCMessageExpr *ME = dyn_cast(E)) return ME->getMethodFamily(); return OMF_None; } bool isPassedToCFRetain(Expr *E, CallExpr *&callE) const { if ((callE = dyn_cast_or_null( StmtMap->getParentIgnoreParenImpCasts(E)))) if (FunctionDecl * FD = dyn_cast_or_null(callE->getCalleeDecl())) if (FD->getName() == "CFRetain" && FD->getNumParams() == 1 && FD->getParent()->isTranslationUnit() && FD->isExternallyVisible()) return true; return false; } bool isPassedToCParamWithKnownOwnership(Expr *E, bool &isConsumed) const { if (CallExpr *callE = dyn_cast_or_null( StmtMap->getParentIgnoreParenImpCasts(E))) if (FunctionDecl * FD = dyn_cast_or_null(callE->getCalleeDecl())) { unsigned i = 0; for (unsigned e = callE->getNumArgs(); i != e; ++i) { Expr *arg = callE->getArg(i); if (arg == E || arg->IgnoreParenImpCasts() == E) break; } if (i < callE->getNumArgs() && i < FD->getNumParams()) { ParmVarDecl *PD = FD->getParamDecl(i); if (PD->hasAttr()) { isConsumed = true; return true; } } } return false; } bool isSelf(Expr *E) const { E = E->IgnoreParenLValueCasts(); if (DeclRefExpr *DRE = dyn_cast(E)) if (ImplicitParamDecl *IPD = dyn_cast(DRE->getDecl())) if (IPD->getIdentifier() == SelfII) return true; return false; } }; } // end anonymous namespace void trans::rewriteUnbridgedCasts(MigrationPass &pass) { BodyTransform trans(pass); trans.TraverseDecl(pass.Ctx.getTranslationUnitDecl()); } @