head 1.1; branch 1.1.1; access; symbols netbsd-11-0-RC4:1.1.1.3 netbsd-11-0-RC3:1.1.1.3 netbsd-11-0-RC2:1.1.1.3 netbsd-11-0-RC1:1.1.1.3 perseant-exfatfs-base-20250801:1.1.1.3 netbsd-11:1.1.1.3.0.10 netbsd-11-base:1.1.1.3 netbsd-10-1-RELEASE:1.1.1.3 perseant-exfatfs-base-20240630:1.1.1.3 perseant-exfatfs:1.1.1.3.0.8 perseant-exfatfs-base:1.1.1.3 netbsd-8-3-RELEASE:1.1.1.2 netbsd-9-4-RELEASE:1.1.1.2 netbsd-10-0-RELEASE:1.1.1.3 netbsd-10-0-RC6:1.1.1.3 netbsd-10-0-RC5:1.1.1.3 netbsd-10-0-RC4:1.1.1.3 netbsd-10-0-RC3:1.1.1.3 netbsd-10-0-RC2:1.1.1.3 netbsd-10-0-RC1:1.1.1.3 netbsd-10:1.1.1.3.0.6 netbsd-10-base:1.1.1.3 netbsd-9-3-RELEASE:1.1.1.2 cjep_sun2x:1.1.1.3.0.4 cjep_sun2x-base:1.1.1.3 cjep_staticlib_x-base1:1.1.1.3 netbsd-9-2-RELEASE:1.1.1.2 cjep_staticlib_x:1.1.1.3.0.2 cjep_staticlib_x-base:1.1.1.3 netbsd-9-1-RELEASE:1.1.1.2 phil-wifi-20200421:1.1.1.3 phil-wifi-20200411:1.1.1.3 phil-wifi-20200406:1.1.1.3 netbsd-8-2-RELEASE:1.1.1.2 netbsd-9-0-RELEASE:1.1.1.2 netbsd-9-0-RC2:1.1.1.2 netbsd-9-0-RC1:1.1.1.2 netbsd-9:1.1.1.2.0.28 netbsd-9-base:1.1.1.2 phil-wifi-20190609:1.1.1.2 netbsd-8-1-RELEASE:1.1.1.2 netbsd-8-1-RC1:1.1.1.2 pgoyette-compat-merge-20190127:1.1.1.2 pgoyette-compat-20190127:1.1.1.2 pgoyette-compat-20190118:1.1.1.2 pgoyette-compat-1226:1.1.1.2 pgoyette-compat-1126:1.1.1.2 pgoyette-compat-1020:1.1.1.2 pgoyette-compat-0930:1.1.1.2 pgoyette-compat-0906:1.1.1.2 netbsd-7-2-RELEASE:1.1.1.2 pgoyette-compat-0728:1.1.1.2 clang-337282:1.1.1.2 netbsd-8-0-RELEASE:1.1.1.2 phil-wifi:1.1.1.2.0.26 phil-wifi-base:1.1.1.2 pgoyette-compat-0625:1.1.1.2 netbsd-8-0-RC2:1.1.1.2 pgoyette-compat-0521:1.1.1.2 pgoyette-compat-0502:1.1.1.2 pgoyette-compat-0422:1.1.1.2 netbsd-8-0-RC1:1.1.1.2 pgoyette-compat-0415:1.1.1.2 pgoyette-compat-0407:1.1.1.2 pgoyette-compat-0330:1.1.1.2 pgoyette-compat-0322:1.1.1.2 pgoyette-compat-0315:1.1.1.2 netbsd-7-1-2-RELEASE:1.1.1.2 pgoyette-compat:1.1.1.2.0.24 pgoyette-compat-base:1.1.1.2 netbsd-7-1-1-RELEASE:1.1.1.2 clang-319952:1.1.1.2 matt-nb8-mediatek:1.1.1.2.0.22 matt-nb8-mediatek-base:1.1.1.2 clang-309604:1.1.1.2 perseant-stdc-iso10646:1.1.1.2.0.20 perseant-stdc-iso10646-base:1.1.1.2 netbsd-8:1.1.1.2.0.18 netbsd-8-base:1.1.1.2 prg-localcount2-base3:1.1.1.2 prg-localcount2-base2:1.1.1.2 prg-localcount2-base1:1.1.1.2 prg-localcount2:1.1.1.2.0.16 prg-localcount2-base:1.1.1.2 pgoyette-localcount-20170426:1.1.1.2 bouyer-socketcan-base1:1.1.1.2 pgoyette-localcount-20170320:1.1.1.2 netbsd-7-1:1.1.1.2.0.14 netbsd-7-1-RELEASE:1.1.1.2 netbsd-7-1-RC2:1.1.1.2 clang-294123:1.1.1.2 netbsd-7-nhusb-base-20170116:1.1.1.2 bouyer-socketcan:1.1.1.2.0.12 bouyer-socketcan-base:1.1.1.2 clang-291444:1.1.1.2 pgoyette-localcount-20170107:1.1.1.2 netbsd-7-1-RC1:1.1.1.2 pgoyette-localcount-20161104:1.1.1.2 netbsd-7-0-2-RELEASE:1.1.1.2 localcount-20160914:1.1.1.2 netbsd-7-nhusb:1.1.1.2.0.10 netbsd-7-nhusb-base:1.1.1.2 clang-280599:1.1.1.2 pgoyette-localcount-20160806:1.1.1.2 pgoyette-localcount-20160726:1.1.1.2 pgoyette-localcount:1.1.1.2.0.8 pgoyette-localcount-base:1.1.1.2 netbsd-7-0-1-RELEASE:1.1.1.2 clang-261930:1.1.1.2 netbsd-7-0:1.1.1.2.0.6 netbsd-7-0-RELEASE:1.1.1.2 netbsd-7-0-RC3:1.1.1.2 netbsd-7-0-RC2:1.1.1.2 netbsd-7-0-RC1:1.1.1.2 clang-237755:1.1.1.2 clang-232565:1.1.1.2 clang-227398:1.1.1.2 tls-maxphys-base:1.1.1.2 tls-maxphys:1.1.1.2.0.4 netbsd-7:1.1.1.2.0.2 netbsd-7-base:1.1.1.2 clang-215315:1.1.1.2 clang-209886:1.1.1.2 yamt-pagecache:1.1.1.1.0.4 yamt-pagecache-base9:1.1.1.1 tls-earlyentropy:1.1.1.1.0.2 tls-earlyentropy-base:1.1.1.2 riastradh-xf86-video-intel-2-7-1-pre-2-21-15:1.1.1.1 riastradh-drm2-base3:1.1.1.1 clang-202566:1.1.1.1 clang-201163:1.1.1.1 clang-199312:1.1.1.1 clang-198450:1.1.1.1 clang-196603:1.1.1.1 clang-195771:1.1.1.1 LLVM:1.1.1; locks; strict; comment @// @; 1.1 date 2013.11.28.14.14.49; author joerg; state Exp; branches 1.1.1.1; next ; commitid ow8OybrawrB1f3fx; 1.1.1.1 date 2013.11.28.14.14.49; author joerg; state Exp; branches 1.1.1.1.2.1 1.1.1.1.4.1; next 1.1.1.2; commitid ow8OybrawrB1f3fx; 1.1.1.2 date 2014.05.30.18.14.39; author joerg; state Exp; branches 1.1.1.2.4.1 1.1.1.2.26.1; next 1.1.1.3; commitid 8q0kdlBlCn09GACx; 1.1.1.3 date 2019.11.13.22.19.19; author joerg; state dead; branches; next ; commitid QD8YATxuNG34YJKB; 1.1.1.1.2.1 date 2014.08.10.07.08.06; author tls; state Exp; branches; next ; commitid t01A1TLTYxkpGMLx; 1.1.1.1.4.1 date 2013.11.28.14.14.49; author yamt; state dead; branches; next 1.1.1.1.4.2; commitid WSrDtL5nYAUyiyBx; 1.1.1.1.4.2 date 2014.05.22.16.18.25; author yamt; state Exp; branches; next ; commitid WSrDtL5nYAUyiyBx; 1.1.1.2.4.1 date 2014.05.30.18.14.39; author tls; state dead; branches; next 1.1.1.2.4.2; commitid jTnpym9Qu0o4R1Nx; 1.1.1.2.4.2 date 2014.08.19.23.47.25; author tls; state Exp; branches; next ; commitid jTnpym9Qu0o4R1Nx; 1.1.1.2.26.1 date 2020.04.13.07.46.29; author martin; state dead; branches; next ; commitid X01YhRUPVUDaec4C; desc @@ 1.1 log @Initial revision @ text @//===--- TransZeroOutPropsInDealloc.cpp - Transformations to ARC mode -----===// // // The LLVM Compiler Infrastructure // // This file is distributed under the University of Illinois Open Source // License. See LICENSE.TXT for details. // //===----------------------------------------------------------------------===// // // removeZeroOutPropsInDealloc: // // Removes zero'ing out "strong" @@synthesized properties in a -dealloc method. // //===----------------------------------------------------------------------===// #include "Transforms.h" #include "Internals.h" #include "clang/AST/ASTContext.h" using namespace clang; using namespace arcmt; using namespace trans; namespace { class ZeroOutInDeallocRemover : public RecursiveASTVisitor { typedef RecursiveASTVisitor base; MigrationPass &Pass; llvm::DenseMap SynthesizedProperties; ImplicitParamDecl *SelfD; ExprSet Removables; Selector FinalizeSel; public: ZeroOutInDeallocRemover(MigrationPass &pass) : Pass(pass), SelfD(0) { FinalizeSel = Pass.Ctx.Selectors.getNullarySelector(&Pass.Ctx.Idents.get("finalize")); } bool VisitObjCMessageExpr(ObjCMessageExpr *ME) { ASTContext &Ctx = Pass.Ctx; TransformActions &TA = Pass.TA; if (ME->getReceiverKind() != ObjCMessageExpr::Instance) return true; Expr *receiver = ME->getInstanceReceiver(); if (!receiver) return true; DeclRefExpr *refE = dyn_cast(receiver->IgnoreParenCasts()); if (!refE || refE->getDecl() != SelfD) return true; bool BackedBySynthesizeSetter = false; for (llvm::DenseMap::iterator P = SynthesizedProperties.begin(), E = SynthesizedProperties.end(); P != E; ++P) { ObjCPropertyDecl *PropDecl = P->first; if (PropDecl->getSetterName() == ME->getSelector()) { BackedBySynthesizeSetter = true; break; } } if (!BackedBySynthesizeSetter) return true; // Remove the setter message if RHS is null Transaction Trans(TA); Expr *RHS = ME->getArg(0); bool RHSIsNull = RHS->isNullPointerConstant(Ctx, Expr::NPC_ValueDependentIsNull); if (RHSIsNull && isRemovable(ME)) TA.removeStmt(ME); return true; } bool VisitPseudoObjectExpr(PseudoObjectExpr *POE) { if (isZeroingPropIvar(POE) && isRemovable(POE)) { Transaction Trans(Pass.TA); Pass.TA.removeStmt(POE); } return true; } bool VisitBinaryOperator(BinaryOperator *BOE) { if (isZeroingPropIvar(BOE) && isRemovable(BOE)) { Transaction Trans(Pass.TA); Pass.TA.removeStmt(BOE); } return true; } bool TraverseObjCMethodDecl(ObjCMethodDecl *D) { if (D->getMethodFamily() != OMF_dealloc && !(D->isInstanceMethod() && D->getSelector() == FinalizeSel)) return true; if (!D->hasBody()) return true; ObjCImplDecl *IMD = dyn_cast(D->getDeclContext()); if (!IMD) return true; SelfD = D->getSelfDecl(); collectRemovables(D->getBody(), Removables); // For a 'dealloc' method use, find all property implementations in // this class implementation. for (ObjCImplDecl::propimpl_iterator I = IMD->propimpl_begin(), EI = IMD->propimpl_end(); I != EI; ++I) { ObjCPropertyImplDecl *PID = *I; if (PID->getPropertyImplementation() == ObjCPropertyImplDecl::Synthesize) { ObjCPropertyDecl *PD = PID->getPropertyDecl(); ObjCMethodDecl *setterM = PD->getSetterMethodDecl(); if (!(setterM && setterM->isDefined())) { ObjCPropertyDecl::PropertyAttributeKind AttrKind = PD->getPropertyAttributes(); if (AttrKind & (ObjCPropertyDecl::OBJC_PR_retain | ObjCPropertyDecl::OBJC_PR_copy | ObjCPropertyDecl::OBJC_PR_strong)) SynthesizedProperties[PD] = PID; } } } // Now, remove all zeroing of ivars etc. base::TraverseObjCMethodDecl(D); // clear out for next method. SynthesizedProperties.clear(); SelfD = 0; Removables.clear(); return true; } bool TraverseFunctionDecl(FunctionDecl *D) { return true; } bool TraverseBlockDecl(BlockDecl *block) { return true; } bool TraverseBlockExpr(BlockExpr *block) { return true; } private: bool isRemovable(Expr *E) const { return Removables.count(E); } bool isZeroingPropIvar(Expr *E) { E = E->IgnoreParens(); if (BinaryOperator *BO = dyn_cast(E)) return isZeroingPropIvar(BO); if (PseudoObjectExpr *PO = dyn_cast(E)) return isZeroingPropIvar(PO); return false; } bool isZeroingPropIvar(BinaryOperator *BOE) { if (BOE->getOpcode() == BO_Comma) return isZeroingPropIvar(BOE->getLHS()) && isZeroingPropIvar(BOE->getRHS()); if (BOE->getOpcode() != BO_Assign) return false; Expr *LHS = BOE->getLHS(); if (ObjCIvarRefExpr *IV = dyn_cast(LHS)) { ObjCIvarDecl *IVDecl = IV->getDecl(); if (!IVDecl->getType()->isObjCObjectPointerType()) return false; bool IvarBacksPropertySynthesis = false; for (llvm::DenseMap::iterator P = SynthesizedProperties.begin(), E = SynthesizedProperties.end(); P != E; ++P) { ObjCPropertyImplDecl *PropImpDecl = P->second; if (PropImpDecl && PropImpDecl->getPropertyIvarDecl() == IVDecl) { IvarBacksPropertySynthesis = true; break; } } if (!IvarBacksPropertySynthesis) return false; } else return false; return isZero(BOE->getRHS()); } bool isZeroingPropIvar(PseudoObjectExpr *PO) { BinaryOperator *BO = dyn_cast(PO->getSyntacticForm()); if (!BO) return false; if (BO->getOpcode() != BO_Assign) return false; ObjCPropertyRefExpr *PropRefExp = dyn_cast(BO->getLHS()->IgnoreParens()); if (!PropRefExp) return false; // TODO: Using implicit property decl. if (PropRefExp->isImplicitProperty()) return false; if (ObjCPropertyDecl *PDecl = PropRefExp->getExplicitProperty()) { if (!SynthesizedProperties.count(PDecl)) return false; } return isZero(cast(BO->getRHS())->getSourceExpr()); } bool isZero(Expr *E) { if (E->isNullPointerConstant(Pass.Ctx, Expr::NPC_ValueDependentIsNull)) return true; return isZeroingPropIvar(E); } }; } // anonymous namespace void trans::removeZeroOutPropsInDeallocFinalize(MigrationPass &pass) { ZeroOutInDeallocRemover trans(pass); trans.TraverseDecl(pass.Ctx.getTranslationUnitDecl()); } @ 1.1.1.1 log @Import Clang 3.4rc1 r195771. @ text @@ 1.1.1.1.2.1 log @Rebase. @ text @d38 1 a38 1 ZeroOutInDeallocRemover(MigrationPass &pass) : Pass(pass), SelfD(nullptr) { d116 16 a131 13 for (auto *PID : IMD->property_impls()) { if (PID->getPropertyImplementation() == ObjCPropertyImplDecl::Synthesize) { ObjCPropertyDecl *PD = PID->getPropertyDecl(); ObjCMethodDecl *setterM = PD->getSetterMethodDecl(); if (!(setterM && setterM->isDefined())) { ObjCPropertyDecl::PropertyAttributeKind AttrKind = PD->getPropertyAttributes(); if (AttrKind & (ObjCPropertyDecl::OBJC_PR_retain | ObjCPropertyDecl::OBJC_PR_copy | ObjCPropertyDecl::OBJC_PR_strong)) SynthesizedProperties[PD] = PID; a132 1 } d140 1 a140 1 SelfD = nullptr; @ 1.1.1.2 log @Import Clang 3.5svn r209886. @ text @d38 1 a38 1 ZeroOutInDeallocRemover(MigrationPass &pass) : Pass(pass), SelfD(nullptr) { d116 16 a131 13 for (auto *PID : IMD->property_impls()) { if (PID->getPropertyImplementation() == ObjCPropertyImplDecl::Synthesize) { ObjCPropertyDecl *PD = PID->getPropertyDecl(); ObjCMethodDecl *setterM = PD->getSetterMethodDecl(); if (!(setterM && setterM->isDefined())) { ObjCPropertyDecl::PropertyAttributeKind AttrKind = PD->getPropertyAttributes(); if (AttrKind & (ObjCPropertyDecl::OBJC_PR_retain | ObjCPropertyDecl::OBJC_PR_copy | ObjCPropertyDecl::OBJC_PR_strong)) SynthesizedProperties[PD] = PID; a132 1 } d140 1 a140 1 SelfD = nullptr; @ 1.1.1.2.26.1 log @Mostly merge changes from HEAD upto 20200411 @ text @@ 1.1.1.3 log @Mark old LLVM instance as dead. @ text @@ 1.1.1.2.4.1 log @file TransZeroOutPropsInDealloc.cpp was added on branch tls-maxphys on 2014-08-19 23:47:25 +0000 @ text @d1 227 @ 1.1.1.2.4.2 log @Rebase to HEAD as of a few days ago. @ text @a0 227 //===--- TransZeroOutPropsInDealloc.cpp - Transformations to ARC mode -----===// // // The LLVM Compiler Infrastructure // // This file is distributed under the University of Illinois Open Source // License. See LICENSE.TXT for details. // //===----------------------------------------------------------------------===// // // removeZeroOutPropsInDealloc: // // Removes zero'ing out "strong" @@synthesized properties in a -dealloc method. // //===----------------------------------------------------------------------===// #include "Transforms.h" #include "Internals.h" #include "clang/AST/ASTContext.h" using namespace clang; using namespace arcmt; using namespace trans; namespace { class ZeroOutInDeallocRemover : public RecursiveASTVisitor { typedef RecursiveASTVisitor base; MigrationPass &Pass; llvm::DenseMap SynthesizedProperties; ImplicitParamDecl *SelfD; ExprSet Removables; Selector FinalizeSel; public: ZeroOutInDeallocRemover(MigrationPass &pass) : Pass(pass), SelfD(nullptr) { FinalizeSel = Pass.Ctx.Selectors.getNullarySelector(&Pass.Ctx.Idents.get("finalize")); } bool VisitObjCMessageExpr(ObjCMessageExpr *ME) { ASTContext &Ctx = Pass.Ctx; TransformActions &TA = Pass.TA; if (ME->getReceiverKind() != ObjCMessageExpr::Instance) return true; Expr *receiver = ME->getInstanceReceiver(); if (!receiver) return true; DeclRefExpr *refE = dyn_cast(receiver->IgnoreParenCasts()); if (!refE || refE->getDecl() != SelfD) return true; bool BackedBySynthesizeSetter = false; for (llvm::DenseMap::iterator P = SynthesizedProperties.begin(), E = SynthesizedProperties.end(); P != E; ++P) { ObjCPropertyDecl *PropDecl = P->first; if (PropDecl->getSetterName() == ME->getSelector()) { BackedBySynthesizeSetter = true; break; } } if (!BackedBySynthesizeSetter) return true; // Remove the setter message if RHS is null Transaction Trans(TA); Expr *RHS = ME->getArg(0); bool RHSIsNull = RHS->isNullPointerConstant(Ctx, Expr::NPC_ValueDependentIsNull); if (RHSIsNull && isRemovable(ME)) TA.removeStmt(ME); return true; } bool VisitPseudoObjectExpr(PseudoObjectExpr *POE) { if (isZeroingPropIvar(POE) && isRemovable(POE)) { Transaction Trans(Pass.TA); Pass.TA.removeStmt(POE); } return true; } bool VisitBinaryOperator(BinaryOperator *BOE) { if (isZeroingPropIvar(BOE) && isRemovable(BOE)) { Transaction Trans(Pass.TA); Pass.TA.removeStmt(BOE); } return true; } bool TraverseObjCMethodDecl(ObjCMethodDecl *D) { if (D->getMethodFamily() != OMF_dealloc && !(D->isInstanceMethod() && D->getSelector() == FinalizeSel)) return true; if (!D->hasBody()) return true; ObjCImplDecl *IMD = dyn_cast(D->getDeclContext()); if (!IMD) return true; SelfD = D->getSelfDecl(); collectRemovables(D->getBody(), Removables); // For a 'dealloc' method use, find all property implementations in // this class implementation. for (auto *PID : IMD->property_impls()) { if (PID->getPropertyImplementation() == ObjCPropertyImplDecl::Synthesize) { ObjCPropertyDecl *PD = PID->getPropertyDecl(); ObjCMethodDecl *setterM = PD->getSetterMethodDecl(); if (!(setterM && setterM->isDefined())) { ObjCPropertyDecl::PropertyAttributeKind AttrKind = PD->getPropertyAttributes(); if (AttrKind & (ObjCPropertyDecl::OBJC_PR_retain | ObjCPropertyDecl::OBJC_PR_copy | ObjCPropertyDecl::OBJC_PR_strong)) SynthesizedProperties[PD] = PID; } } } // Now, remove all zeroing of ivars etc. base::TraverseObjCMethodDecl(D); // clear out for next method. SynthesizedProperties.clear(); SelfD = nullptr; Removables.clear(); return true; } bool TraverseFunctionDecl(FunctionDecl *D) { return true; } bool TraverseBlockDecl(BlockDecl *block) { return true; } bool TraverseBlockExpr(BlockExpr *block) { return true; } private: bool isRemovable(Expr *E) const { return Removables.count(E); } bool isZeroingPropIvar(Expr *E) { E = E->IgnoreParens(); if (BinaryOperator *BO = dyn_cast(E)) return isZeroingPropIvar(BO); if (PseudoObjectExpr *PO = dyn_cast(E)) return isZeroingPropIvar(PO); return false; } bool isZeroingPropIvar(BinaryOperator *BOE) { if (BOE->getOpcode() == BO_Comma) return isZeroingPropIvar(BOE->getLHS()) && isZeroingPropIvar(BOE->getRHS()); if (BOE->getOpcode() != BO_Assign) return false; Expr *LHS = BOE->getLHS(); if (ObjCIvarRefExpr *IV = dyn_cast(LHS)) { ObjCIvarDecl *IVDecl = IV->getDecl(); if (!IVDecl->getType()->isObjCObjectPointerType()) return false; bool IvarBacksPropertySynthesis = false; for (llvm::DenseMap::iterator P = SynthesizedProperties.begin(), E = SynthesizedProperties.end(); P != E; ++P) { ObjCPropertyImplDecl *PropImpDecl = P->second; if (PropImpDecl && PropImpDecl->getPropertyIvarDecl() == IVDecl) { IvarBacksPropertySynthesis = true; break; } } if (!IvarBacksPropertySynthesis) return false; } else return false; return isZero(BOE->getRHS()); } bool isZeroingPropIvar(PseudoObjectExpr *PO) { BinaryOperator *BO = dyn_cast(PO->getSyntacticForm()); if (!BO) return false; if (BO->getOpcode() != BO_Assign) return false; ObjCPropertyRefExpr *PropRefExp = dyn_cast(BO->getLHS()->IgnoreParens()); if (!PropRefExp) return false; // TODO: Using implicit property decl. if (PropRefExp->isImplicitProperty()) return false; if (ObjCPropertyDecl *PDecl = PropRefExp->getExplicitProperty()) { if (!SynthesizedProperties.count(PDecl)) return false; } return isZero(cast(BO->getRHS())->getSourceExpr()); } bool isZero(Expr *E) { if (E->isNullPointerConstant(Pass.Ctx, Expr::NPC_ValueDependentIsNull)) return true; return isZeroingPropIvar(E); } }; } // anonymous namespace void trans::removeZeroOutPropsInDeallocFinalize(MigrationPass &pass) { ZeroOutInDeallocRemover trans(pass); trans.TraverseDecl(pass.Ctx.getTranslationUnitDecl()); } @ 1.1.1.1.4.1 log @file TransZeroOutPropsInDealloc.cpp was added on branch yamt-pagecache on 2014-05-22 16:18:25 +0000 @ text @d1 229 @ 1.1.1.1.4.2 log @sync with head. for a reference, the tree before this commit was tagged as yamt-pagecache-tag8. this commit was splitted into small chunks to avoid a limitation of cvs. ("Protocol error: too many arguments") @ text @a0 229 //===--- TransZeroOutPropsInDealloc.cpp - Transformations to ARC mode -----===// // // The LLVM Compiler Infrastructure // // This file is distributed under the University of Illinois Open Source // License. See LICENSE.TXT for details. // //===----------------------------------------------------------------------===// // // removeZeroOutPropsInDealloc: // // Removes zero'ing out "strong" @@synthesized properties in a -dealloc method. // //===----------------------------------------------------------------------===// #include "Transforms.h" #include "Internals.h" #include "clang/AST/ASTContext.h" using namespace clang; using namespace arcmt; using namespace trans; namespace { class ZeroOutInDeallocRemover : public RecursiveASTVisitor { typedef RecursiveASTVisitor base; MigrationPass &Pass; llvm::DenseMap SynthesizedProperties; ImplicitParamDecl *SelfD; ExprSet Removables; Selector FinalizeSel; public: ZeroOutInDeallocRemover(MigrationPass &pass) : Pass(pass), SelfD(0) { FinalizeSel = Pass.Ctx.Selectors.getNullarySelector(&Pass.Ctx.Idents.get("finalize")); } bool VisitObjCMessageExpr(ObjCMessageExpr *ME) { ASTContext &Ctx = Pass.Ctx; TransformActions &TA = Pass.TA; if (ME->getReceiverKind() != ObjCMessageExpr::Instance) return true; Expr *receiver = ME->getInstanceReceiver(); if (!receiver) return true; DeclRefExpr *refE = dyn_cast(receiver->IgnoreParenCasts()); if (!refE || refE->getDecl() != SelfD) return true; bool BackedBySynthesizeSetter = false; for (llvm::DenseMap::iterator P = SynthesizedProperties.begin(), E = SynthesizedProperties.end(); P != E; ++P) { ObjCPropertyDecl *PropDecl = P->first; if (PropDecl->getSetterName() == ME->getSelector()) { BackedBySynthesizeSetter = true; break; } } if (!BackedBySynthesizeSetter) return true; // Remove the setter message if RHS is null Transaction Trans(TA); Expr *RHS = ME->getArg(0); bool RHSIsNull = RHS->isNullPointerConstant(Ctx, Expr::NPC_ValueDependentIsNull); if (RHSIsNull && isRemovable(ME)) TA.removeStmt(ME); return true; } bool VisitPseudoObjectExpr(PseudoObjectExpr *POE) { if (isZeroingPropIvar(POE) && isRemovable(POE)) { Transaction Trans(Pass.TA); Pass.TA.removeStmt(POE); } return true; } bool VisitBinaryOperator(BinaryOperator *BOE) { if (isZeroingPropIvar(BOE) && isRemovable(BOE)) { Transaction Trans(Pass.TA); Pass.TA.removeStmt(BOE); } return true; } bool TraverseObjCMethodDecl(ObjCMethodDecl *D) { if (D->getMethodFamily() != OMF_dealloc && !(D->isInstanceMethod() && D->getSelector() == FinalizeSel)) return true; if (!D->hasBody()) return true; ObjCImplDecl *IMD = dyn_cast(D->getDeclContext()); if (!IMD) return true; SelfD = D->getSelfDecl(); collectRemovables(D->getBody(), Removables); // For a 'dealloc' method use, find all property implementations in // this class implementation. for (ObjCImplDecl::propimpl_iterator I = IMD->propimpl_begin(), EI = IMD->propimpl_end(); I != EI; ++I) { ObjCPropertyImplDecl *PID = *I; if (PID->getPropertyImplementation() == ObjCPropertyImplDecl::Synthesize) { ObjCPropertyDecl *PD = PID->getPropertyDecl(); ObjCMethodDecl *setterM = PD->getSetterMethodDecl(); if (!(setterM && setterM->isDefined())) { ObjCPropertyDecl::PropertyAttributeKind AttrKind = PD->getPropertyAttributes(); if (AttrKind & (ObjCPropertyDecl::OBJC_PR_retain | ObjCPropertyDecl::OBJC_PR_copy | ObjCPropertyDecl::OBJC_PR_strong)) SynthesizedProperties[PD] = PID; } } } // Now, remove all zeroing of ivars etc. base::TraverseObjCMethodDecl(D); // clear out for next method. SynthesizedProperties.clear(); SelfD = 0; Removables.clear(); return true; } bool TraverseFunctionDecl(FunctionDecl *D) { return true; } bool TraverseBlockDecl(BlockDecl *block) { return true; } bool TraverseBlockExpr(BlockExpr *block) { return true; } private: bool isRemovable(Expr *E) const { return Removables.count(E); } bool isZeroingPropIvar(Expr *E) { E = E->IgnoreParens(); if (BinaryOperator *BO = dyn_cast(E)) return isZeroingPropIvar(BO); if (PseudoObjectExpr *PO = dyn_cast(E)) return isZeroingPropIvar(PO); return false; } bool isZeroingPropIvar(BinaryOperator *BOE) { if (BOE->getOpcode() == BO_Comma) return isZeroingPropIvar(BOE->getLHS()) && isZeroingPropIvar(BOE->getRHS()); if (BOE->getOpcode() != BO_Assign) return false; Expr *LHS = BOE->getLHS(); if (ObjCIvarRefExpr *IV = dyn_cast(LHS)) { ObjCIvarDecl *IVDecl = IV->getDecl(); if (!IVDecl->getType()->isObjCObjectPointerType()) return false; bool IvarBacksPropertySynthesis = false; for (llvm::DenseMap::iterator P = SynthesizedProperties.begin(), E = SynthesizedProperties.end(); P != E; ++P) { ObjCPropertyImplDecl *PropImpDecl = P->second; if (PropImpDecl && PropImpDecl->getPropertyIvarDecl() == IVDecl) { IvarBacksPropertySynthesis = true; break; } } if (!IvarBacksPropertySynthesis) return false; } else return false; return isZero(BOE->getRHS()); } bool isZeroingPropIvar(PseudoObjectExpr *PO) { BinaryOperator *BO = dyn_cast(PO->getSyntacticForm()); if (!BO) return false; if (BO->getOpcode() != BO_Assign) return false; ObjCPropertyRefExpr *PropRefExp = dyn_cast(BO->getLHS()->IgnoreParens()); if (!PropRefExp) return false; // TODO: Using implicit property decl. if (PropRefExp->isImplicitProperty()) return false; if (ObjCPropertyDecl *PDecl = PropRefExp->getExplicitProperty()) { if (!SynthesizedProperties.count(PDecl)) return false; } return isZero(cast(BO->getRHS())->getSourceExpr()); } bool isZero(Expr *E) { if (E->isNullPointerConstant(Pass.Ctx, Expr::NPC_ValueDependentIsNull)) return true; return isZeroingPropIvar(E); } }; } // anonymous namespace void trans::removeZeroOutPropsInDeallocFinalize(MigrationPass &pass) { ZeroOutInDeallocRemover trans(pass); trans.TraverseDecl(pass.Ctx.getTranslationUnitDecl()); } @