head 1.1; branch 1.1.1; access; symbols netbsd-11-0-RC4:1.1.1.2 netbsd-11-0-RC3:1.1.1.2 netbsd-11-0-RC2:1.1.1.2 netbsd-11-0-RC1:1.1.1.2 perseant-exfatfs-base-20250801:1.1.1.2 netbsd-11:1.1.1.2.0.10 netbsd-11-base:1.1.1.2 netbsd-10-1-RELEASE:1.1.1.2 perseant-exfatfs-base-20240630:1.1.1.2 perseant-exfatfs:1.1.1.2.0.8 perseant-exfatfs-base:1.1.1.2 netbsd-9-4-RELEASE:1.1.1.1 netbsd-10-0-RELEASE:1.1.1.2 netbsd-10-0-RC6:1.1.1.2 netbsd-10-0-RC5:1.1.1.2 netbsd-10-0-RC4:1.1.1.2 netbsd-10-0-RC3:1.1.1.2 netbsd-10-0-RC2:1.1.1.2 netbsd-10-0-RC1:1.1.1.2 netbsd-10:1.1.1.2.0.6 netbsd-10-base:1.1.1.2 netbsd-9-3-RELEASE:1.1.1.1 cjep_sun2x:1.1.1.2.0.4 cjep_sun2x-base:1.1.1.2 cjep_staticlib_x-base1:1.1.1.2 netbsd-9-2-RELEASE:1.1.1.1 cjep_staticlib_x:1.1.1.2.0.2 cjep_staticlib_x-base:1.1.1.2 netbsd-9-1-RELEASE:1.1.1.1 phil-wifi-20200421:1.1.1.2 phil-wifi-20200411:1.1.1.2 phil-wifi-20200406:1.1.1.2 netbsd-9-0-RELEASE:1.1.1.1 netbsd-9-0-RC2:1.1.1.1 netbsd-9-0-RC1:1.1.1.1 netbsd-9:1.1.1.1.0.6 netbsd-9-base:1.1.1.1 phil-wifi:1.1.1.1.0.4 phil-wifi-20190609:1.1.1.1 pgoyette-compat-merge-20190127:1.1.1.1.2.2 pgoyette-compat-20190127:1.1.1.1 pgoyette-compat-20190118:1.1.1.1 pgoyette-compat-1226:1.1.1.1 pgoyette-compat-1126:1.1.1.1 pgoyette-compat-1020:1.1.1.1 pgoyette-compat-0930:1.1.1.1 pgoyette-compat-0906:1.1.1.1 pgoyette-compat:1.1.1.1.0.2 pgoyette-compat-0728:1.1.1.1 clang-337282:1.1.1.1 LLVM:1.1.1; locks; strict; comment @// @; 1.1 date 2018.07.17.18.31.07; author joerg; state Exp; branches 1.1.1.1; next ; commitid wDzL46ALjrCZgwKA; 1.1.1.1 date 2018.07.17.18.31.07; author joerg; state Exp; branches 1.1.1.1.2.1 1.1.1.1.4.1; next 1.1.1.2; commitid wDzL46ALjrCZgwKA; 1.1.1.2 date 2019.11.13.22.19.28; author joerg; state dead; branches; next ; commitid QD8YATxuNG34YJKB; 1.1.1.1.2.1 date 2018.07.17.18.31.07; author pgoyette; state dead; branches; next 1.1.1.1.2.2; commitid 1UP1xAIUxv1ZgRLA; 1.1.1.1.2.2 date 2018.07.28.04.33.23; author pgoyette; state Exp; branches; next ; commitid 1UP1xAIUxv1ZgRLA; 1.1.1.1.4.1 date 2018.07.17.18.31.07; author christos; state dead; branches; next 1.1.1.1.4.2; commitid jtc8rnCzWiEEHGqB; 1.1.1.1.4.2 date 2019.06.10.21.45.28; author christos; state Exp; branches; next 1.1.1.1.4.3; commitid jtc8rnCzWiEEHGqB; 1.1.1.1.4.3 date 2020.04.13.07.46.39; author martin; state dead; branches; next ; commitid X01YhRUPVUDaec4C; desc @@ 1.1 log @Initial revision @ text @//==- NonnullGlobalConstantsChecker.cpp ---------------------------*- C++ -*--// // // The LLVM Compiler Infrastructure // // This file is distributed under the University of Illinois Open Source // License. See LICENSE.TXT for details. // //===----------------------------------------------------------------------===// // // This checker adds an assumption that constant globals of certain types* are // non-null, as otherwise they generally do not convey any useful information. // The assumption is useful, as many framework use e. g. global const strings, // and the analyzer might not be able to infer the global value if the // definition is in a separate translation unit. // The following types (and their typedef aliases) are considered to be // non-null: // - `char* const` // - `const CFStringRef` from CoreFoundation // - `NSString* const` from Foundation // - `CFBooleanRef` from Foundation // //===----------------------------------------------------------------------===// #include "ClangSACheckers.h" #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h" #include "clang/StaticAnalyzer/Core/Checker.h" #include "clang/StaticAnalyzer/Core/CheckerManager.h" #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h" #include "clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h" using namespace clang; using namespace ento; namespace { class NonnullGlobalConstantsChecker : public Checker { mutable IdentifierInfo *NSStringII = nullptr; mutable IdentifierInfo *CFStringRefII = nullptr; mutable IdentifierInfo *CFBooleanRefII = nullptr; public: NonnullGlobalConstantsChecker() {} void checkLocation(SVal l, bool isLoad, const Stmt *S, CheckerContext &C) const; private: void initIdentifierInfo(ASTContext &Ctx) const; bool isGlobalConstString(SVal V) const; bool isNonnullType(QualType Ty) const; }; } // namespace /// Lazily initialize cache for required identifier information. void NonnullGlobalConstantsChecker::initIdentifierInfo(ASTContext &Ctx) const { if (NSStringII) return; NSStringII = &Ctx.Idents.get("NSString"); CFStringRefII = &Ctx.Idents.get("CFStringRef"); CFBooleanRefII = &Ctx.Idents.get("CFBooleanRef"); } /// Add an assumption that const string-like globals are non-null. void NonnullGlobalConstantsChecker::checkLocation(SVal location, bool isLoad, const Stmt *S, CheckerContext &C) const { initIdentifierInfo(C.getASTContext()); if (!isLoad || !location.isValid()) return; ProgramStateRef State = C.getState(); if (isGlobalConstString(location)) { SVal V = State->getSVal(location.castAs()); Optional Constr = V.getAs(); if (Constr) { // Assume that the variable is non-null. ProgramStateRef OutputState = State->assume(*Constr, true); C.addTransition(OutputState); } } } /// \param V loaded lvalue. /// \return whether {@@code val} is a string-like const global. bool NonnullGlobalConstantsChecker::isGlobalConstString(SVal V) const { Optional RegionVal = V.getAs(); if (!RegionVal) return false; auto *Region = dyn_cast(RegionVal->getAsRegion()); if (!Region) return false; const VarDecl *Decl = Region->getDecl(); if (!Decl->hasGlobalStorage()) return false; QualType Ty = Decl->getType(); bool HasConst = Ty.isConstQualified(); if (isNonnullType(Ty) && HasConst) return true; // Look through the typedefs. while (auto *T = dyn_cast(Ty)) { Ty = T->getDecl()->getUnderlyingType(); // It is sufficient for any intermediate typedef // to be classified const. HasConst = HasConst || Ty.isConstQualified(); if (isNonnullType(Ty) && HasConst) return true; } return false; } /// \return whether {@@code type} is extremely unlikely to be null bool NonnullGlobalConstantsChecker::isNonnullType(QualType Ty) const { if (Ty->isPointerType() && Ty->getPointeeType()->isCharType()) return true; if (auto *T = dyn_cast(Ty)) { return T->getInterfaceDecl() && T->getInterfaceDecl()->getIdentifier() == NSStringII; } else if (auto *T = dyn_cast(Ty)) { IdentifierInfo* II = T->getDecl()->getIdentifier(); return II == CFStringRefII || II == CFBooleanRefII; } return false; } void ento::registerNonnullGlobalConstantsChecker(CheckerManager &Mgr) { Mgr.registerChecker(); } @ 1.1.1.1 log @Import clang r337282 from trunk @ text @@ 1.1.1.2 log @Mark old LLVM instance as dead. @ text @@ 1.1.1.1.4.1 log @file NonnullGlobalConstantsChecker.cpp was added on branch phil-wifi on 2019-06-10 21:45:28 +0000 @ text @d1 140 @ 1.1.1.1.4.2 log @Sync with HEAD @ text @a0 140 //==- NonnullGlobalConstantsChecker.cpp ---------------------------*- C++ -*--// // // The LLVM Compiler Infrastructure // // This file is distributed under the University of Illinois Open Source // License. See LICENSE.TXT for details. // //===----------------------------------------------------------------------===// // // This checker adds an assumption that constant globals of certain types* are // non-null, as otherwise they generally do not convey any useful information. // The assumption is useful, as many framework use e. g. global const strings, // and the analyzer might not be able to infer the global value if the // definition is in a separate translation unit. // The following types (and their typedef aliases) are considered to be // non-null: // - `char* const` // - `const CFStringRef` from CoreFoundation // - `NSString* const` from Foundation // - `CFBooleanRef` from Foundation // //===----------------------------------------------------------------------===// #include "ClangSACheckers.h" #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h" #include "clang/StaticAnalyzer/Core/Checker.h" #include "clang/StaticAnalyzer/Core/CheckerManager.h" #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h" #include "clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h" using namespace clang; using namespace ento; namespace { class NonnullGlobalConstantsChecker : public Checker { mutable IdentifierInfo *NSStringII = nullptr; mutable IdentifierInfo *CFStringRefII = nullptr; mutable IdentifierInfo *CFBooleanRefII = nullptr; public: NonnullGlobalConstantsChecker() {} void checkLocation(SVal l, bool isLoad, const Stmt *S, CheckerContext &C) const; private: void initIdentifierInfo(ASTContext &Ctx) const; bool isGlobalConstString(SVal V) const; bool isNonnullType(QualType Ty) const; }; } // namespace /// Lazily initialize cache for required identifier information. void NonnullGlobalConstantsChecker::initIdentifierInfo(ASTContext &Ctx) const { if (NSStringII) return; NSStringII = &Ctx.Idents.get("NSString"); CFStringRefII = &Ctx.Idents.get("CFStringRef"); CFBooleanRefII = &Ctx.Idents.get("CFBooleanRef"); } /// Add an assumption that const string-like globals are non-null. void NonnullGlobalConstantsChecker::checkLocation(SVal location, bool isLoad, const Stmt *S, CheckerContext &C) const { initIdentifierInfo(C.getASTContext()); if (!isLoad || !location.isValid()) return; ProgramStateRef State = C.getState(); if (isGlobalConstString(location)) { SVal V = State->getSVal(location.castAs()); Optional Constr = V.getAs(); if (Constr) { // Assume that the variable is non-null. ProgramStateRef OutputState = State->assume(*Constr, true); C.addTransition(OutputState); } } } /// \param V loaded lvalue. /// \return whether {@@code val} is a string-like const global. bool NonnullGlobalConstantsChecker::isGlobalConstString(SVal V) const { Optional RegionVal = V.getAs(); if (!RegionVal) return false; auto *Region = dyn_cast(RegionVal->getAsRegion()); if (!Region) return false; const VarDecl *Decl = Region->getDecl(); if (!Decl->hasGlobalStorage()) return false; QualType Ty = Decl->getType(); bool HasConst = Ty.isConstQualified(); if (isNonnullType(Ty) && HasConst) return true; // Look through the typedefs. while (auto *T = dyn_cast(Ty)) { Ty = T->getDecl()->getUnderlyingType(); // It is sufficient for any intermediate typedef // to be classified const. HasConst = HasConst || Ty.isConstQualified(); if (isNonnullType(Ty) && HasConst) return true; } return false; } /// \return whether {@@code type} is extremely unlikely to be null bool NonnullGlobalConstantsChecker::isNonnullType(QualType Ty) const { if (Ty->isPointerType() && Ty->getPointeeType()->isCharType()) return true; if (auto *T = dyn_cast(Ty)) { return T->getInterfaceDecl() && T->getInterfaceDecl()->getIdentifier() == NSStringII; } else if (auto *T = dyn_cast(Ty)) { IdentifierInfo* II = T->getDecl()->getIdentifier(); return II == CFStringRefII || II == CFBooleanRefII; } return false; } void ento::registerNonnullGlobalConstantsChecker(CheckerManager &Mgr) { Mgr.registerChecker(); } @ 1.1.1.1.4.3 log @Mostly merge changes from HEAD upto 20200411 @ text @@ 1.1.1.1.2.1 log @file NonnullGlobalConstantsChecker.cpp was added on branch pgoyette-compat on 2018-07-28 04:33:23 +0000 @ text @d1 140 @ 1.1.1.1.2.2 log @Sync with HEAD @ text @a0 140 //==- NonnullGlobalConstantsChecker.cpp ---------------------------*- C++ -*--// // // The LLVM Compiler Infrastructure // // This file is distributed under the University of Illinois Open Source // License. See LICENSE.TXT for details. // //===----------------------------------------------------------------------===// // // This checker adds an assumption that constant globals of certain types* are // non-null, as otherwise they generally do not convey any useful information. // The assumption is useful, as many framework use e. g. global const strings, // and the analyzer might not be able to infer the global value if the // definition is in a separate translation unit. // The following types (and their typedef aliases) are considered to be // non-null: // - `char* const` // - `const CFStringRef` from CoreFoundation // - `NSString* const` from Foundation // - `CFBooleanRef` from Foundation // //===----------------------------------------------------------------------===// #include "ClangSACheckers.h" #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h" #include "clang/StaticAnalyzer/Core/Checker.h" #include "clang/StaticAnalyzer/Core/CheckerManager.h" #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h" #include "clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h" using namespace clang; using namespace ento; namespace { class NonnullGlobalConstantsChecker : public Checker { mutable IdentifierInfo *NSStringII = nullptr; mutable IdentifierInfo *CFStringRefII = nullptr; mutable IdentifierInfo *CFBooleanRefII = nullptr; public: NonnullGlobalConstantsChecker() {} void checkLocation(SVal l, bool isLoad, const Stmt *S, CheckerContext &C) const; private: void initIdentifierInfo(ASTContext &Ctx) const; bool isGlobalConstString(SVal V) const; bool isNonnullType(QualType Ty) const; }; } // namespace /// Lazily initialize cache for required identifier information. void NonnullGlobalConstantsChecker::initIdentifierInfo(ASTContext &Ctx) const { if (NSStringII) return; NSStringII = &Ctx.Idents.get("NSString"); CFStringRefII = &Ctx.Idents.get("CFStringRef"); CFBooleanRefII = &Ctx.Idents.get("CFBooleanRef"); } /// Add an assumption that const string-like globals are non-null. void NonnullGlobalConstantsChecker::checkLocation(SVal location, bool isLoad, const Stmt *S, CheckerContext &C) const { initIdentifierInfo(C.getASTContext()); if (!isLoad || !location.isValid()) return; ProgramStateRef State = C.getState(); if (isGlobalConstString(location)) { SVal V = State->getSVal(location.castAs()); Optional Constr = V.getAs(); if (Constr) { // Assume that the variable is non-null. ProgramStateRef OutputState = State->assume(*Constr, true); C.addTransition(OutputState); } } } /// \param V loaded lvalue. /// \return whether {@@code val} is a string-like const global. bool NonnullGlobalConstantsChecker::isGlobalConstString(SVal V) const { Optional RegionVal = V.getAs(); if (!RegionVal) return false; auto *Region = dyn_cast(RegionVal->getAsRegion()); if (!Region) return false; const VarDecl *Decl = Region->getDecl(); if (!Decl->hasGlobalStorage()) return false; QualType Ty = Decl->getType(); bool HasConst = Ty.isConstQualified(); if (isNonnullType(Ty) && HasConst) return true; // Look through the typedefs. while (auto *T = dyn_cast(Ty)) { Ty = T->getDecl()->getUnderlyingType(); // It is sufficient for any intermediate typedef // to be classified const. HasConst = HasConst || Ty.isConstQualified(); if (isNonnullType(Ty) && HasConst) return true; } return false; } /// \return whether {@@code type} is extremely unlikely to be null bool NonnullGlobalConstantsChecker::isNonnullType(QualType Ty) const { if (Ty->isPointerType() && Ty->getPointeeType()->isCharType()) return true; if (auto *T = dyn_cast(Ty)) { return T->getInterfaceDecl() && T->getInterfaceDecl()->getIdentifier() == NSStringII; } else if (auto *T = dyn_cast(Ty)) { IdentifierInfo* II = T->getDecl()->getIdentifier(); return II == CFStringRefII || II == CFBooleanRefII; } return false; } void ento::registerNonnullGlobalConstantsChecker(CheckerManager &Mgr) { Mgr.registerChecker(); } @