head 1.1; branch 1.1.1; access; symbols netbsd-11-0-RC4:1.1.1.3 netbsd-11-0-RC3:1.1.1.3 netbsd-11-0-RC2:1.1.1.3 netbsd-11-0-RC1:1.1.1.3 perseant-exfatfs-base-20250801:1.1.1.3 netbsd-11:1.1.1.3.0.10 netbsd-11-base:1.1.1.3 netbsd-10-1-RELEASE:1.1.1.3 perseant-exfatfs-base-20240630:1.1.1.3 perseant-exfatfs:1.1.1.3.0.8 perseant-exfatfs-base:1.1.1.3 netbsd-8-3-RELEASE:1.1.1.1 netbsd-9-4-RELEASE:1.1.1.2 netbsd-10-0-RELEASE:1.1.1.3 netbsd-10-0-RC6:1.1.1.3 netbsd-10-0-RC5:1.1.1.3 netbsd-10-0-RC4:1.1.1.3 netbsd-10-0-RC3:1.1.1.3 netbsd-10-0-RC2:1.1.1.3 netbsd-10-0-RC1:1.1.1.3 netbsd-10:1.1.1.3.0.6 netbsd-10-base:1.1.1.3 netbsd-9-3-RELEASE:1.1.1.2 cjep_sun2x:1.1.1.3.0.4 cjep_sun2x-base:1.1.1.3 cjep_staticlib_x-base1:1.1.1.3 netbsd-9-2-RELEASE:1.1.1.2 cjep_staticlib_x:1.1.1.3.0.2 cjep_staticlib_x-base:1.1.1.3 netbsd-9-1-RELEASE:1.1.1.2 phil-wifi-20200421:1.1.1.3 phil-wifi-20200411:1.1.1.3 phil-wifi-20200406:1.1.1.3 netbsd-8-2-RELEASE:1.1.1.1 netbsd-9-0-RELEASE:1.1.1.2 netbsd-9-0-RC2:1.1.1.2 netbsd-9-0-RC1:1.1.1.2 netbsd-9:1.1.1.2.0.6 netbsd-9-base:1.1.1.2 phil-wifi-20190609:1.1.1.2 netbsd-8-1-RELEASE:1.1.1.1 netbsd-8-1-RC1:1.1.1.1 pgoyette-compat-merge-20190127:1.1.1.2 pgoyette-compat-20190127:1.1.1.2 pgoyette-compat-20190118:1.1.1.2 pgoyette-compat-1226:1.1.1.2 pgoyette-compat-1126:1.1.1.2 pgoyette-compat-1020:1.1.1.2 pgoyette-compat-0930:1.1.1.2 pgoyette-compat-0906:1.1.1.2 pgoyette-compat-0728:1.1.1.2 clang-337282:1.1.1.2 netbsd-8-0-RELEASE:1.1.1.1 phil-wifi:1.1.1.2.0.4 phil-wifi-base:1.1.1.2 pgoyette-compat-0625:1.1.1.2 netbsd-8-0-RC2:1.1.1.1 pgoyette-compat-0521:1.1.1.2 pgoyette-compat-0502:1.1.1.2 pgoyette-compat-0422:1.1.1.2 netbsd-8-0-RC1:1.1.1.1 pgoyette-compat-0415:1.1.1.2 pgoyette-compat-0407:1.1.1.2 pgoyette-compat-0330:1.1.1.2 pgoyette-compat-0322:1.1.1.2 pgoyette-compat-0315:1.1.1.2 pgoyette-compat:1.1.1.2.0.2 pgoyette-compat-base:1.1.1.2 clang-319952:1.1.1.2 matt-nb8-mediatek:1.1.1.1.0.12 matt-nb8-mediatek-base:1.1.1.1 clang-309604:1.1.1.2 perseant-stdc-iso10646:1.1.1.1.0.10 perseant-stdc-iso10646-base:1.1.1.1 netbsd-8:1.1.1.1.0.8 netbsd-8-base:1.1.1.1 prg-localcount2-base3:1.1.1.1 prg-localcount2-base2:1.1.1.1 prg-localcount2-base1:1.1.1.1 prg-localcount2:1.1.1.1.0.6 prg-localcount2-base:1.1.1.1 pgoyette-localcount-20170426:1.1.1.1 bouyer-socketcan-base1:1.1.1.1 pgoyette-localcount:1.1.1.1.0.4 pgoyette-localcount-20170320:1.1.1.1 clang-294123:1.1.1.1 bouyer-socketcan:1.1.1.1.0.2 bouyer-socketcan-base:1.1.1.1 clang-291444:1.1.1.1 LLVM:1.1.1; locks; strict; comment @// @; 1.1 date 2017.01.11.10.35.37; author joerg; state Exp; branches 1.1.1.1; next ; commitid CNnUNfII1jgNmxBz; 1.1.1.1 date 2017.01.11.10.35.37; author joerg; state Exp; branches 1.1.1.1.4.1; next 1.1.1.2; commitid CNnUNfII1jgNmxBz; 1.1.1.2 date 2017.08.01.19.35.16; author joerg; state Exp; branches 1.1.1.2.4.1; next 1.1.1.3; commitid pMuDy65V0VicSx1A; 1.1.1.3 date 2019.11.13.22.19.28; author joerg; state dead; branches; next ; commitid QD8YATxuNG34YJKB; 1.1.1.1.4.1 date 2017.01.11.10.35.37; author pgoyette; state dead; branches; next 1.1.1.1.4.2; commitid jjw7cAwgyKq7RfKz; 1.1.1.1.4.2 date 2017.03.20.06.52.42; author pgoyette; state Exp; branches; next ; commitid jjw7cAwgyKq7RfKz; 1.1.1.2.4.1 date 2020.04.13.07.46.39; author martin; state dead; branches; next ; commitid X01YhRUPVUDaec4C; desc @@ 1.1 log @Initial revision @ text @//==- ObjCPropertyChecker.cpp - Check ObjC properties ------------*- C++ -*-==// // // The LLVM Compiler Infrastructure // // This file is distributed under the University of Illinois Open Source // License. See LICENSE.TXT for details. // //===----------------------------------------------------------------------===// // // This checker finds issues with Objective-C properties. // Currently finds only one kind of issue: // - Find synthesized properties with copy attribute of mutable NS collection // types. Calling -copy on such collections produces an immutable copy, // which contradicts the type of the property. // //===----------------------------------------------------------------------===// #include "ClangSACheckers.h" #include "clang/StaticAnalyzer/Core/BugReporter/BugReporter.h" #include "clang/StaticAnalyzer/Core/Checker.h" using namespace clang; using namespace ento; namespace { class ObjCPropertyChecker : public Checker> { void checkCopyMutable(const ObjCPropertyDecl *D, BugReporter &BR) const; public: void checkASTDecl(const ObjCPropertyDecl *D, AnalysisManager &Mgr, BugReporter &BR) const; }; } // end anonymous namespace. void ObjCPropertyChecker::checkASTDecl(const ObjCPropertyDecl *D, AnalysisManager &Mgr, BugReporter &BR) const { checkCopyMutable(D, BR); } void ObjCPropertyChecker::checkCopyMutable(const ObjCPropertyDecl *D, BugReporter &BR) const { if (D->isReadOnly() || D->getSetterKind() != ObjCPropertyDecl::Copy) return; QualType T = D->getType(); if (!T->isObjCObjectPointerType()) return; const std::string &PropTypeName(T->getPointeeType().getCanonicalType() .getUnqualifiedType() .getAsString()); if (!StringRef(PropTypeName).startswith("NSMutable")) return; const ObjCImplDecl *ImplD = nullptr; if (const ObjCInterfaceDecl *IntD = dyn_cast(D->getDeclContext())) { ImplD = IntD->getImplementation(); } else { const ObjCCategoryDecl *CatD = cast(D->getDeclContext()); ImplD = CatD->getClassInterface()->getImplementation(); } if (!ImplD || ImplD->HasUserDeclaredSetterMethod(D)) return; SmallString<128> Str; llvm::raw_svector_ostream OS(Str); OS << "Property of mutable type '" << PropTypeName << "' has 'copy' attribute; an immutable object will be stored instead"; BR.EmitBasicReport( D, this, "Objective-C property misuse", "Logic error", OS.str(), PathDiagnosticLocation::createBegin(D, BR.getSourceManager()), D->getSourceRange()); } void ento::registerObjCPropertyChecker(CheckerManager &Mgr) { Mgr.registerChecker(); } @ 1.1.1.1 log @Import Clang pre-4.0.0 r291444. @ text @@ 1.1.1.2 log @Import clang r309604 from branches/release_50 @ text @d61 2 a62 1 } else if (auto *CatD = dyn_cast(D->getDeclContext())) { @ 1.1.1.2.4.1 log @Mostly merge changes from HEAD upto 20200411 @ text @@ 1.1.1.3 log @Mark old LLVM instance as dead. @ text @@ 1.1.1.1.4.1 log @file ObjCPropertyChecker.cpp was added on branch pgoyette-localcount on 2017-03-20 06:52:42 +0000 @ text @d1 82 @ 1.1.1.1.4.2 log @Sync with HEAD @ text @a0 82 //==- ObjCPropertyChecker.cpp - Check ObjC properties ------------*- C++ -*-==// // // The LLVM Compiler Infrastructure // // This file is distributed under the University of Illinois Open Source // License. See LICENSE.TXT for details. // //===----------------------------------------------------------------------===// // // This checker finds issues with Objective-C properties. // Currently finds only one kind of issue: // - Find synthesized properties with copy attribute of mutable NS collection // types. Calling -copy on such collections produces an immutable copy, // which contradicts the type of the property. // //===----------------------------------------------------------------------===// #include "ClangSACheckers.h" #include "clang/StaticAnalyzer/Core/BugReporter/BugReporter.h" #include "clang/StaticAnalyzer/Core/Checker.h" using namespace clang; using namespace ento; namespace { class ObjCPropertyChecker : public Checker> { void checkCopyMutable(const ObjCPropertyDecl *D, BugReporter &BR) const; public: void checkASTDecl(const ObjCPropertyDecl *D, AnalysisManager &Mgr, BugReporter &BR) const; }; } // end anonymous namespace. void ObjCPropertyChecker::checkASTDecl(const ObjCPropertyDecl *D, AnalysisManager &Mgr, BugReporter &BR) const { checkCopyMutable(D, BR); } void ObjCPropertyChecker::checkCopyMutable(const ObjCPropertyDecl *D, BugReporter &BR) const { if (D->isReadOnly() || D->getSetterKind() != ObjCPropertyDecl::Copy) return; QualType T = D->getType(); if (!T->isObjCObjectPointerType()) return; const std::string &PropTypeName(T->getPointeeType().getCanonicalType() .getUnqualifiedType() .getAsString()); if (!StringRef(PropTypeName).startswith("NSMutable")) return; const ObjCImplDecl *ImplD = nullptr; if (const ObjCInterfaceDecl *IntD = dyn_cast(D->getDeclContext())) { ImplD = IntD->getImplementation(); } else { const ObjCCategoryDecl *CatD = cast(D->getDeclContext()); ImplD = CatD->getClassInterface()->getImplementation(); } if (!ImplD || ImplD->HasUserDeclaredSetterMethod(D)) return; SmallString<128> Str; llvm::raw_svector_ostream OS(Str); OS << "Property of mutable type '" << PropTypeName << "' has 'copy' attribute; an immutable object will be stored instead"; BR.EmitBasicReport( D, this, "Objective-C property misuse", "Logic error", OS.str(), PathDiagnosticLocation::createBegin(D, BR.getSourceManager()), D->getSourceRange()); } void ento::registerObjCPropertyChecker(CheckerManager &Mgr) { Mgr.registerChecker(); } @