head 1.1; branch 1.1.1; access; symbols netbsd-11-0-RC4:1.1.1.4 netbsd-11-0-RC3:1.1.1.4 netbsd-11-0-RC2:1.1.1.4 netbsd-11-0-RC1:1.1.1.4 perseant-exfatfs-base-20250801:1.1.1.4 netbsd-11:1.1.1.4.0.10 netbsd-11-base:1.1.1.4 netbsd-10-1-RELEASE:1.1.1.4 perseant-exfatfs-base-20240630:1.1.1.4 perseant-exfatfs:1.1.1.4.0.8 perseant-exfatfs-base:1.1.1.4 netbsd-8-3-RELEASE:1.1.1.1 netbsd-9-4-RELEASE:1.1.1.3 netbsd-10-0-RELEASE:1.1.1.4 netbsd-10-0-RC6:1.1.1.4 netbsd-10-0-RC5:1.1.1.4 netbsd-10-0-RC4:1.1.1.4 netbsd-10-0-RC3:1.1.1.4 netbsd-10-0-RC2:1.1.1.4 netbsd-10-0-RC1:1.1.1.4 netbsd-10:1.1.1.4.0.6 netbsd-10-base:1.1.1.4 netbsd-9-3-RELEASE:1.1.1.3 cjep_sun2x:1.1.1.4.0.4 cjep_sun2x-base:1.1.1.4 cjep_staticlib_x-base1:1.1.1.4 netbsd-9-2-RELEASE:1.1.1.3 cjep_staticlib_x:1.1.1.4.0.2 cjep_staticlib_x-base:1.1.1.4 netbsd-9-1-RELEASE:1.1.1.3 phil-wifi-20200421:1.1.1.4 phil-wifi-20200411:1.1.1.4 phil-wifi-20200406:1.1.1.4 netbsd-8-2-RELEASE:1.1.1.1 netbsd-9-0-RELEASE:1.1.1.3 netbsd-9-0-RC2:1.1.1.3 netbsd-9-0-RC1:1.1.1.3 netbsd-9:1.1.1.3.0.2 netbsd-9-base:1.1.1.3 phil-wifi-20190609:1.1.1.3 netbsd-8-1-RELEASE:1.1.1.1 netbsd-8-1-RC1:1.1.1.1 pgoyette-compat-merge-20190127:1.1.1.2.2.1 pgoyette-compat-20190127:1.1.1.3 pgoyette-compat-20190118:1.1.1.3 pgoyette-compat-1226:1.1.1.3 pgoyette-compat-1126:1.1.1.3 pgoyette-compat-1020:1.1.1.3 pgoyette-compat-0930:1.1.1.3 pgoyette-compat-0906:1.1.1.3 pgoyette-compat-0728:1.1.1.3 clang-337282:1.1.1.3 netbsd-8-0-RELEASE:1.1.1.1 phil-wifi:1.1.1.2.0.4 phil-wifi-base:1.1.1.2 pgoyette-compat-0625:1.1.1.2 netbsd-8-0-RC2:1.1.1.1 pgoyette-compat-0521:1.1.1.2 pgoyette-compat-0502:1.1.1.2 pgoyette-compat-0422:1.1.1.2 netbsd-8-0-RC1:1.1.1.1 pgoyette-compat-0415:1.1.1.2 pgoyette-compat-0407:1.1.1.2 pgoyette-compat-0330:1.1.1.2 pgoyette-compat-0322:1.1.1.2 pgoyette-compat-0315:1.1.1.2 pgoyette-compat:1.1.1.2.0.2 pgoyette-compat-base:1.1.1.2 clang-319952:1.1.1.2 matt-nb8-mediatek:1.1.1.1.0.12 matt-nb8-mediatek-base:1.1.1.1 clang-309604:1.1.1.2 perseant-stdc-iso10646:1.1.1.1.0.10 perseant-stdc-iso10646-base:1.1.1.1 netbsd-8:1.1.1.1.0.8 netbsd-8-base:1.1.1.1 prg-localcount2-base3:1.1.1.1 prg-localcount2-base2:1.1.1.1 prg-localcount2-base1:1.1.1.1 prg-localcount2:1.1.1.1.0.6 prg-localcount2-base:1.1.1.1 pgoyette-localcount-20170426:1.1.1.1 bouyer-socketcan-base1:1.1.1.1 pgoyette-localcount:1.1.1.1.0.4 pgoyette-localcount-20170320:1.1.1.1 clang-294123:1.1.1.1 bouyer-socketcan:1.1.1.1.0.2 bouyer-socketcan-base:1.1.1.1 clang-291444:1.1.1.1 LLVM:1.1.1; locks; strict; comment @// @; 1.1 date 2017.01.11.10.33.05; author joerg; state Exp; branches 1.1.1.1; next ; commitid CNnUNfII1jgNmxBz; 1.1.1.1 date 2017.01.11.10.33.05; author joerg; state Exp; branches 1.1.1.1.4.1; next 1.1.1.2; commitid CNnUNfII1jgNmxBz; 1.1.1.2 date 2017.08.01.19.34.41; author joerg; state Exp; branches 1.1.1.2.2.1 1.1.1.2.4.1; next 1.1.1.3; commitid pMuDy65V0VicSx1A; 1.1.1.3 date 2018.07.17.18.32.12; author joerg; state Exp; branches; next 1.1.1.4; commitid wDzL46ALjrCZgwKA; 1.1.1.4 date 2019.11.13.22.23.10; author joerg; state dead; branches; next ; commitid QD8YATxuNG34YJKB; 1.1.1.1.4.1 date 2017.01.11.10.33.05; author pgoyette; state dead; branches; next 1.1.1.1.4.2; commitid jjw7cAwgyKq7RfKz; 1.1.1.1.4.2 date 2017.03.20.06.53.39; author pgoyette; state Exp; branches; next ; commitid jjw7cAwgyKq7RfKz; 1.1.1.2.2.1 date 2018.07.28.04.34.18; author pgoyette; state Exp; branches; next ; commitid 1UP1xAIUxv1ZgRLA; 1.1.1.2.4.1 date 2019.06.10.21.46.46; author christos; state Exp; branches; next 1.1.1.2.4.2; commitid jtc8rnCzWiEEHGqB; 1.1.1.2.4.2 date 2020.04.13.07.50.38; author martin; state dead; branches; next ; commitid X01YhRUPVUDaec4C; desc @@ 1.1 log @Initial revision @ text @//===- unittest/Format/FormatTestObjC.cpp - Formatting unit tests----------===// // // The LLVM Compiler Infrastructure // // This file is distributed under the University of Illinois Open Source // License. See LICENSE.TXT for details. // //===----------------------------------------------------------------------===// #include "clang/Format/Format.h" #include "../Tooling/ReplacementTest.h" #include "FormatTestUtils.h" #include "clang/Frontend/TextDiagnosticPrinter.h" #include "llvm/Support/Debug.h" #include "llvm/Support/MemoryBuffer.h" #include "gtest/gtest.h" #define DEBUG_TYPE "format-test" using clang::tooling::ReplacementTest; using clang::tooling::toReplacements; namespace clang { namespace format { namespace { class FormatTestObjC : public ::testing::Test { protected: FormatTestObjC() { Style = getLLVMStyle(); Style.Language = FormatStyle::LK_ObjC; } enum IncompleteCheck { IC_ExpectComplete, IC_ExpectIncomplete, IC_DoNotCheck }; std::string format(llvm::StringRef Code, IncompleteCheck CheckIncomplete = IC_ExpectComplete) { DEBUG(llvm::errs() << "---\n"); DEBUG(llvm::errs() << Code << "\n\n"); std::vector Ranges(1, tooling::Range(0, Code.size())); bool IncompleteFormat = false; tooling::Replacements Replaces = reformat(Style, Code, Ranges, "", &IncompleteFormat); if (CheckIncomplete != IC_DoNotCheck) { bool ExpectedIncompleteFormat = CheckIncomplete == IC_ExpectIncomplete; EXPECT_EQ(ExpectedIncompleteFormat, IncompleteFormat) << Code << "\n\n"; } auto Result = applyAllReplacements(Code, Replaces); EXPECT_TRUE(static_cast(Result)); DEBUG(llvm::errs() << "\n" << *Result << "\n\n"); return *Result; } void verifyFormat(StringRef Code) { EXPECT_EQ(Code.str(), format(test::messUp(Code))); } void verifyIncompleteFormat(StringRef Code) { EXPECT_EQ(Code.str(), format(test::messUp(Code), IC_ExpectIncomplete)); } FormatStyle Style; }; TEST_F(FormatTestObjC, DetectsObjCInHeaders) { Style = getStyle("LLVM", "a.h", "none", "@@interface\n" "- (id)init;"); EXPECT_EQ(FormatStyle::LK_ObjC, Style.Language); Style = getStyle("LLVM", "a.h", "none", "@@interface\n" "+ (id)init;"); EXPECT_EQ(FormatStyle::LK_ObjC, Style.Language); // No recognizable ObjC. Style = getStyle("LLVM", "a.h", "none", "void f() {}"); EXPECT_EQ(FormatStyle::LK_Cpp, Style.Language); } TEST_F(FormatTestObjC, FormatObjCTryCatch) { verifyFormat("@@try {\n" " f();\n" "} @@catch (NSException e) {\n" " @@throw;\n" "} @@finally {\n" " exit(42);\n" "}"); verifyFormat("DEBUG({\n" " @@try {\n" " } @@finally {\n" " }\n" "});\n"); } TEST_F(FormatTestObjC, FormatObjCAutoreleasepool) { verifyFormat("@@autoreleasepool {\n" " f();\n" "}\n" "@@autoreleasepool {\n" " f();\n" "}\n"); Style.BreakBeforeBraces = FormatStyle::BS_Allman; verifyFormat("@@autoreleasepool\n" "{\n" " f();\n" "}\n" "@@autoreleasepool\n" "{\n" " f();\n" "}\n"); } TEST_F(FormatTestObjC, FormatObjCInterface) { verifyFormat("@@interface Foo : NSObject {\n" "@@public\n" " int field1;\n" "@@protected\n" " int field2;\n" "@@private\n" " int field3;\n" "@@package\n" " int field4;\n" "}\n" "+ (id)init;\n" "@@end"); verifyFormat("@@interface /* wait for it */ Foo\n" "+ (id)init;\n" "// Look, a comment!\n" "- (int)answerWith:(int)i;\n" "@@end"); verifyFormat("@@interface Foo\n" "@@end\n" "@@interface Bar\n" "@@end"); verifyFormat("@@interface Foo : Bar\n" "+ (id)init;\n" "@@end"); verifyFormat("@@interface Foo : /**/ Bar /**/ \n" "+ (id)init;\n" "@@end"); verifyFormat("@@interface Foo (HackStuff)\n" "+ (id)init;\n" "@@end"); verifyFormat("@@interface Foo ()\n" "+ (id)init;\n" "@@end"); verifyFormat("@@interface Foo (HackStuff) \n" "+ (id)init;\n" "@@end"); verifyFormat("@@interface Foo {\n" " int _i;\n" "}\n" "+ (id)init;\n" "@@end"); verifyFormat("@@interface Foo : Bar {\n" " int _i;\n" "}\n" "+ (id)init;\n" "@@end"); verifyFormat("@@interface Foo : Bar {\n" " int _i;\n" "}\n" "+ (id)init;\n" "@@end"); verifyFormat("@@interface Foo (HackStuff) {\n" " int _i;\n" "}\n" "+ (id)init;\n" "@@end"); verifyFormat("@@interface Foo () {\n" " int _i;\n" "}\n" "+ (id)init;\n" "@@end"); verifyFormat("@@interface Foo (HackStuff) {\n" " int _i;\n" "}\n" "+ (id)init;\n" "@@end"); Style = getGoogleStyle(FormatStyle::LK_ObjC); verifyFormat("@@interface Foo : NSObject {\n" " @@public\n" " int field1;\n" " @@protected\n" " int field2;\n" " @@private\n" " int field3;\n" " @@package\n" " int field4;\n" "}\n" "+ (id)init;\n" "@@end"); verifyFormat("@@interface Foo : Bar\n" "+ (id)init;\n" "@@end"); verifyFormat("@@interface Foo (HackStuff)\n" "+ (id)init;\n" "@@end"); Style.BinPackParameters = false; Style.ColumnLimit = 80; verifyFormat("@@interface aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ()<\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa> {\n" "}"); } TEST_F(FormatTestObjC, FormatObjCImplementation) { verifyFormat("@@implementation Foo : NSObject {\n" "@@public\n" " int field1;\n" "@@protected\n" " int field2;\n" "@@private\n" " int field3;\n" "@@package\n" " int field4;\n" "}\n" "+ (id)init {\n}\n" "@@end"); verifyFormat("@@implementation Foo\n" "+ (id)init {\n" " if (true)\n" " return nil;\n" "}\n" "// Look, a comment!\n" "- (int)answerWith:(int)i {\n" " return i;\n" "}\n" "+ (int)answerWith:(int)i {\n" " return i;\n" "}\n" "@@end"); verifyFormat("@@implementation Foo\n" "@@end\n" "@@implementation Bar\n" "@@end"); EXPECT_EQ("@@implementation Foo : Bar\n" "+ (id)init {\n}\n" "- (void)foo {\n}\n" "@@end", format("@@implementation Foo : Bar\n" "+(id)init{}\n" "-(void)foo{}\n" "@@end")); verifyFormat("@@implementation Foo {\n" " int _i;\n" "}\n" "+ (id)init {\n}\n" "@@end"); verifyFormat("@@implementation Foo : Bar {\n" " int _i;\n" "}\n" "+ (id)init {\n}\n" "@@end"); verifyFormat("@@implementation Foo (HackStuff)\n" "+ (id)init {\n}\n" "@@end"); verifyFormat("@@implementation ObjcClass\n" "- (void)method;\n" "{}\n" "@@end"); Style = getGoogleStyle(FormatStyle::LK_ObjC); verifyFormat("@@implementation Foo : NSObject {\n" " @@public\n" " int field1;\n" " @@protected\n" " int field2;\n" " @@private\n" " int field3;\n" " @@package\n" " int field4;\n" "}\n" "+ (id)init {\n}\n" "@@end"); } TEST_F(FormatTestObjC, FormatObjCProtocol) { verifyFormat("@@protocol Foo\n" "@@property(weak) id delegate;\n" "- (NSUInteger)numberOfThings;\n" "@@end"); verifyFormat("@@protocol MyProtocol \n" "- (NSUInteger)numberOfThings;\n" "@@end"); verifyFormat("@@protocol Foo;\n" "@@protocol Bar;\n"); verifyFormat("@@protocol Foo\n" "@@end\n" "@@protocol Bar\n" "@@end"); verifyFormat("@@protocol myProtocol\n" "- (void)mandatoryWithInt:(int)i;\n" "@@optional\n" "- (void)optional;\n" "@@required\n" "- (void)required;\n" "@@optional\n" "@@property(assign) int madProp;\n" "@@end\n"); verifyFormat("@@property(nonatomic, assign, readonly)\n" " int *looooooooooooooooooooooooooooongNumber;\n" "@@property(nonatomic, assign, readonly)\n" " NSString *looooooooooooooooooooooooooooongName;"); verifyFormat("@@implementation PR18406\n" "}\n" "@@end"); Style = getGoogleStyle(FormatStyle::LK_ObjC); verifyFormat("@@protocol MyProtocol\n" "- (NSUInteger)numberOfThings;\n" "@@end"); } TEST_F(FormatTestObjC, FormatObjCMethodDeclarations) { verifyFormat("- (void)doSomethingWith:(GTMFoo *)theFoo\n" " rect:(NSRect)theRect\n" " interval:(float)theInterval {\n" "}"); verifyFormat("- (void)shortf:(GTMFoo *)theFoo\n" " longKeyword:(NSRect)theRect\n" " longerKeyword:(float)theInterval\n" " error:(NSError **)theError {\n" "}"); verifyFormat("- (void)shortf:(GTMFoo *)theFoo\n" " longKeyword:(NSRect)theRect\n" " evenLongerKeyword:(float)theInterval\n" " error:(NSError **)theError {\n" "}"); Style.ColumnLimit = 60; verifyFormat("- (instancetype)initXxxxxx:(id)x\n" " y:(id)y\n" " NS_DESIGNATED_INITIALIZER;"); verifyFormat("- (void)drawRectOn:(id)surface\n" " ofSize:(size_t)height\n" " :(size_t)width;"); // Continuation indent width should win over aligning colons if the function // name is long. Style = getGoogleStyle(FormatStyle::LK_ObjC); Style.ColumnLimit = 40; Style.IndentWrappedFunctionNames = true; verifyFormat("- (void)shortf:(GTMFoo *)theFoo\n" " dontAlignNamef:(NSRect)theRect {\n" "}"); // Make sure we don't break aligning for short parameter names. verifyFormat("- (void)shortf:(GTMFoo *)theFoo\n" " aShortf:(NSRect)theRect {\n" "}"); // Format pairs correctly. Style.ColumnLimit = 80; verifyFormat("- (void)drawRectOn:(id)surface\n" " ofSize:(aaaaaaaa)height\n" " :(size_t)width\n" " atOrigin:(size_t)x\n" " :(size_t)y\n" " aaaaa:(a)yyy\n" " bbb:(d)cccc;"); verifyFormat("- (void)drawRectOn:(id)surface ofSize:(aaa)height:(bbb)width;"); } TEST_F(FormatTestObjC, FormatObjCMethodExpr) { verifyFormat("[foo bar:baz];"); verifyFormat("return [foo bar:baz];"); verifyFormat("return (a)[foo bar:baz];"); verifyFormat("f([foo bar:baz]);"); verifyFormat("f(2, [foo bar:baz]);"); verifyFormat("f(2, a ? b : c);"); verifyFormat("[[self initWithInt:4] bar:[baz quux:arrrr]];"); // Unary operators. verifyFormat("int a = +[foo bar:baz];"); verifyFormat("int a = -[foo bar:baz];"); verifyFormat("int a = ![foo bar:baz];"); verifyFormat("int a = ~[foo bar:baz];"); verifyFormat("int a = ++[foo bar:baz];"); verifyFormat("int a = --[foo bar:baz];"); verifyFormat("int a = sizeof [foo bar:baz];"); verifyFormat("int a = alignof [foo bar:baz];"); verifyFormat("int a = &[foo bar:baz];"); verifyFormat("int a = *[foo bar:baz];"); // FIXME: Make casts work, without breaking f()[4]. // verifyFormat("int a = (int)[foo bar:baz];"); // verifyFormat("return (int)[foo bar:baz];"); // verifyFormat("(void)[foo bar:baz];"); verifyFormat("return (MyType *)[self.tableView cellForRowAtIndexPath:cell];"); // Binary operators. verifyFormat("[foo bar:baz], [foo bar:baz];"); verifyFormat("[foo bar:baz] = [foo bar:baz];"); verifyFormat("[foo bar:baz] *= [foo bar:baz];"); verifyFormat("[foo bar:baz] /= [foo bar:baz];"); verifyFormat("[foo bar:baz] %= [foo bar:baz];"); verifyFormat("[foo bar:baz] += [foo bar:baz];"); verifyFormat("[foo bar:baz] -= [foo bar:baz];"); verifyFormat("[foo bar:baz] <<= [foo bar:baz];"); verifyFormat("[foo bar:baz] >>= [foo bar:baz];"); verifyFormat("[foo bar:baz] &= [foo bar:baz];"); verifyFormat("[foo bar:baz] ^= [foo bar:baz];"); verifyFormat("[foo bar:baz] |= [foo bar:baz];"); verifyFormat("[foo bar:baz] ? [foo bar:baz] : [foo bar:baz];"); verifyFormat("[foo bar:baz] || [foo bar:baz];"); verifyFormat("[foo bar:baz] && [foo bar:baz];"); verifyFormat("[foo bar:baz] | [foo bar:baz];"); verifyFormat("[foo bar:baz] ^ [foo bar:baz];"); verifyFormat("[foo bar:baz] & [foo bar:baz];"); verifyFormat("[foo bar:baz] == [foo bar:baz];"); verifyFormat("[foo bar:baz] != [foo bar:baz];"); verifyFormat("[foo bar:baz] >= [foo bar:baz];"); verifyFormat("[foo bar:baz] <= [foo bar:baz];"); verifyFormat("[foo bar:baz] > [foo bar:baz];"); verifyFormat("[foo bar:baz] < [foo bar:baz];"); verifyFormat("[foo bar:baz] >> [foo bar:baz];"); verifyFormat("[foo bar:baz] << [foo bar:baz];"); verifyFormat("[foo bar:baz] - [foo bar:baz];"); verifyFormat("[foo bar:baz] + [foo bar:baz];"); verifyFormat("[foo bar:baz] * [foo bar:baz];"); verifyFormat("[foo bar:baz] / [foo bar:baz];"); verifyFormat("[foo bar:baz] % [foo bar:baz];"); // Whew! verifyFormat("return in[42];"); verifyFormat("for (auto v : in[1]) {\n}"); verifyFormat("for (int i = 0; i < in[a]; ++i) {\n}"); verifyFormat("for (int i = 0; in[a] < i; ++i) {\n}"); verifyFormat("for (int i = 0; i < n; ++i, ++in[a]) {\n}"); verifyFormat("for (int i = 0; i < n; ++i, in[a]++) {\n}"); verifyFormat("for (int i = 0; i < f(in[a]); ++i, in[a]++) {\n}"); verifyFormat("for (id foo in [self getStuffFor:bla]) {\n" "}"); verifyFormat("[self aaaaa:MACRO(a, b:, c:)];"); verifyFormat("[self aaaaa:(1 + 2) bbbbb:3];"); verifyFormat("[self aaaaa:(Type)a bbbbb:3];"); verifyFormat("[self stuffWithInt:(4 + 2) float:4.5];"); verifyFormat("[self stuffWithInt:a ? b : c float:4.5];"); verifyFormat("[self stuffWithInt:a ? [self foo:bar] : c];"); verifyFormat("[self stuffWithInt:a ? (e ? f : g) : c];"); verifyFormat("[cond ? obj1 : obj2 methodWithParam:param]"); verifyFormat("[button setAction:@@selector(zoomOut:)];"); verifyFormat("[color getRed:&r green:&g blue:&b alpha:&a];"); verifyFormat("arr[[self indexForFoo:a]];"); verifyFormat("throw [self errorFor:a];"); verifyFormat("@@throw [self errorFor:a];"); verifyFormat("[(id)foo bar:(id)baz quux:(id)snorf];"); verifyFormat("[(id)foo bar:(id) ? baz : quux];"); verifyFormat("4 > 4 ? (id)a : (id)baz;"); // This tests that the formatter doesn't break after "backing" but before ":", // which would be at 80 columns. verifyFormat( "void f() {\n" " if ((self = [super initWithContentRect:contentRect\n" " styleMask:styleMask ?: otherMask\n" " backing:NSBackingStoreBuffered\n" " defer:YES]))"); verifyFormat( "[foo checkThatBreakingAfterColonWorksOk:\n" " [bar ifItDoes:reduceOverallLineLengthLikeInThisCase]];"); verifyFormat("[myObj short:arg1 // Force line break\n" " longKeyword:arg2 != nil ? arg2 : @@\"longKeyword\"\n" " evenLongerKeyword:arg3 ?: @@\"evenLongerKeyword\"\n" " error:arg4];"); verifyFormat( "void f() {\n" " popup_window_.reset([[RenderWidgetPopupWindow alloc]\n" " initWithContentRect:NSMakeRect(origin_global.x, origin_global.y,\n" " pos.width(), pos.height())\n" " styleMask:NSBorderlessWindowMask\n" " backing:NSBackingStoreBuffered\n" " defer:NO]);\n" "}"); verifyFormat("[contentsContainer replaceSubview:[subviews objectAtIndex:0]\n" " with:contentsNativeView];"); verifyFormat( "[pboard addTypes:[NSArray arrayWithObject:kBookmarkButtonDragType]\n" " owner:nillllll];"); verifyFormat( "[pboard setData:[NSData dataWithBytes:&button length:sizeof(button)]\n" " forType:kBookmarkButtonDragType];"); verifyFormat("[defaultCenter addObserver:self\n" " selector:@@selector(willEnterFullscreen)\n" " name:kWillEnterFullscreenNotification\n" " object:nil];"); verifyFormat("[image_rep drawInRect:drawRect\n" " fromRect:NSZeroRect\n" " operation:NSCompositeCopy\n" " fraction:1.0\n" " respectFlipped:NO\n" " hints:nil];"); verifyFormat("[aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa];"); verifyFormat("[aaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaa)\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa];"); verifyFormat("[aaaaaaaaaaaaaaaaaaaaaaa.aaaaaaaa[aaaaaaaaaaaaaaaaaaaaa]\n" " aaaaaaaaaaaaaaaaaaaaaa];"); verifyFormat( "scoped_nsobject message(\n" " // The frame will be fixed up when |-setMessageText:| is called.\n" " [[NSTextField alloc] initWithFrame:NSMakeRect(0, 0, 0, 0)]);"); verifyFormat("[self aaaaaa:bbbbbbbbbbbbb\n" " aaaaaaaaaa:bbbbbbbbbbbbbbbbb\n" " aaaaa:bbbbbbbbbbb + bbbbbbbbbbbb\n" " aaaa:bbb];"); verifyFormat("[self param:function( //\n" " parameter)]"); verifyFormat( "[self aaaaaaaaaa:aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa |\n" " aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa |\n" " aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa];"); // Variadic parameters. verifyFormat( "NSArray *myStrings = [NSArray stringarray:@@\"a\", @@\"b\", nil];"); verifyFormat( "[self aaaaaaaaaaaaa:aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa,\n" " aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa,\n" " aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa];"); verifyFormat("[self // break\n" " a:a\n" " aaa:aaa];"); verifyFormat("bool a = ([aaaaaaaa aaaaa] == aaaaaaaaaaaaaaaaa ||\n" " [aaaaaaaa aaaaa] == aaaaaaaaaaaaaaaaaaaa);"); // Formats pair-parameters. verifyFormat("[I drawRectOn:surface ofSize:aa:bbb atOrigin:cc:dd];"); verifyFormat("[I drawRectOn:surface //\n" " ofSize:aa:bbb\n" " atOrigin:cc:dd];"); Style.ColumnLimit = 70; verifyFormat( "void f() {\n" " popup_wdow_.reset([[RenderWidgetPopupWindow alloc]\n" " iniithContentRect:NSMakRet(origin_global.x, origin_global.y,\n" " pos.width(), pos.height())\n" " syeMask:NSBorderlessWindowMask\n" " bking:NSBackingStoreBuffered\n" " der:NO]);\n" "}"); Style.ColumnLimit = 60; verifyFormat("[call aaaaaaaa.aaaaaa.aaaaaaaa.aaaaaaaa.aaaaaaaa.aaaaaaaa\n" " .aaaaaaaa];"); // FIXME: Indentation seems off. // FIXME: This violates the column limit. verifyFormat( "[aaaaaaaaaaaaaaaaaaaaaaaaa\n" " aaaaaaaaaaaaaaaaa:aaaaaaaa\n" " aaa:aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa];"); Style = getChromiumStyle(FormatStyle::LK_ObjC); Style.ColumnLimit = 80; verifyFormat( "void f() {\n" " popup_window_.reset([[RenderWidgetPopupWindow alloc]\n" " initWithContentRect:NSMakeRect(origin_global.x, origin_global.y,\n" " pos.width(), pos.height())\n" " styleMask:NSBorderlessWindowMask\n" " backing:NSBackingStoreBuffered\n" " defer:NO]);\n" "}"); } TEST_F(FormatTestObjC, ObjCAt) { verifyFormat("@@autoreleasepool"); verifyFormat("@@catch"); verifyFormat("@@class"); verifyFormat("@@compatibility_alias"); verifyFormat("@@defs"); verifyFormat("@@dynamic"); verifyFormat("@@encode"); verifyFormat("@@end"); verifyFormat("@@finally"); verifyFormat("@@implementation"); verifyFormat("@@import"); verifyFormat("@@interface"); verifyFormat("@@optional"); verifyFormat("@@package"); verifyFormat("@@private"); verifyFormat("@@property"); verifyFormat("@@protected"); verifyFormat("@@protocol"); verifyFormat("@@public"); verifyFormat("@@required"); verifyFormat("@@selector"); verifyFormat("@@synchronized"); verifyFormat("@@synthesize"); verifyFormat("@@throw"); verifyFormat("@@try"); EXPECT_EQ("@@interface", format("@@ interface")); // The precise formatting of this doesn't matter, nobody writes code like // this. verifyFormat("@@ /*foo*/ interface"); } TEST_F(FormatTestObjC, ObjCSnippets) { verifyFormat("@@autoreleasepool {\n" " foo();\n" "}"); verifyFormat("@@class Foo, Bar;"); verifyFormat("@@compatibility_alias AliasName ExistingClass;"); verifyFormat("@@dynamic textColor;"); verifyFormat("char *buf1 = @@encode(int *);"); verifyFormat("char *buf1 = @@encode(typeof(4 * 5));"); verifyFormat("char *buf1 = @@encode(int **);"); verifyFormat("Protocol *proto = @@protocol(p1);"); verifyFormat("SEL s = @@selector(foo:);"); verifyFormat("@@synchronized(self) {\n" " f();\n" "}"); verifyFormat("@@import foo.bar;\n" "@@import baz;"); verifyFormat("@@synthesize dropArrowPosition = dropArrowPosition_;"); verifyFormat("@@property(assign, nonatomic) CGFloat hoverAlpha;"); verifyFormat("@@property(assign, getter=isEditable) BOOL editable;"); Style = getMozillaStyle(); verifyFormat("@@property (assign, getter=isEditable) BOOL editable;"); verifyFormat("@@property BOOL editable;"); Style = getWebKitStyle(); verifyFormat("@@property (assign, getter=isEditable) BOOL editable;"); verifyFormat("@@property BOOL editable;"); Style = getGoogleStyle(FormatStyle::LK_ObjC); verifyFormat("@@synthesize dropArrowPosition = dropArrowPosition_;"); verifyFormat("@@property(assign, getter=isEditable) BOOL editable;"); } TEST_F(FormatTestObjC, ObjCForIn) { verifyFormat("- (void)test {\n" " for (NSString *n in arrayOfStrings) {\n" " foo(n);\n" " }\n" "}"); verifyFormat("- (void)test {\n" " for (NSString *n in (__bridge NSArray *)arrayOfStrings) {\n" " foo(n);\n" " }\n" "}"); } TEST_F(FormatTestObjC, ObjCLiterals) { verifyFormat("@@\"String\""); verifyFormat("@@1"); verifyFormat("@@+4.8"); verifyFormat("@@-4"); verifyFormat("@@1LL"); verifyFormat("@@.5"); verifyFormat("@@'c'"); verifyFormat("@@true"); verifyFormat("NSNumber *smallestInt = @@(-INT_MAX - 1);"); verifyFormat("NSNumber *piOverTwo = @@(M_PI / 2);"); verifyFormat("NSNumber *favoriteColor = @@(Green);"); verifyFormat("NSString *path = @@(getenv(\"PATH\"));"); verifyFormat("[dictionary setObject:@@(1) forKey:@@\"number\"];"); } TEST_F(FormatTestObjC, ObjCDictLiterals) { verifyFormat("@@{"); verifyFormat("@@{}"); verifyFormat("@@{@@\"one\" : @@1}"); verifyFormat("return @@{@@\"one\" : @@1;"); verifyFormat("@@{@@\"one\" : @@1}"); verifyFormat("@@{@@\"one\" : @@{@@2 : @@1}}"); verifyFormat("@@{\n" " @@\"one\" : @@{@@2 : @@1},\n" "}"); verifyFormat("@@{1 > 2 ? @@\"one\" : @@\"two\" : 1 > 2 ? @@1 : @@2}"); verifyIncompleteFormat("[self setDict:@@{}"); verifyIncompleteFormat("[self setDict:@@{@@1 : @@2}"); verifyFormat("NSLog(@@\"%@@\", @@{@@1 : @@2, @@2 : @@3}[@@1]);"); verifyFormat( "NSDictionary *masses = @@{@@\"H\" : @@1.0078, @@\"He\" : @@4.0026};"); verifyFormat( "NSDictionary *settings = @@{AVEncoderKey : @@(AVAudioQualityMax)};"); verifyFormat("NSDictionary *d = @@{\n" " @@\"nam\" : NSUserNam(),\n" " @@\"dte\" : [NSDate date],\n" " @@\"processInfo\" : [NSProcessInfo processInfo]\n" "};"); verifyFormat( "@@{\n" " NSFontAttributeNameeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee : " "regularFont,\n" "};"); verifyFormat( "@@{\n" " NSFontAttributeNameeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee :\n" " reeeeeeeeeeeeeeeeeeeeeeeegularFont,\n" "};"); // We should try to be robust in case someone forgets the "@@". verifyFormat("NSDictionary *d = {\n" " @@\"nam\" : NSUserNam(),\n" " @@\"dte\" : [NSDate date],\n" " @@\"processInfo\" : [NSProcessInfo processInfo]\n" "};"); verifyFormat("NSMutableDictionary *dictionary =\n" " [NSMutableDictionary dictionaryWithDictionary:@@{\n" " aaaaaaaaaaaaaaaaaaaaa : aaaaaaaaaaaaa,\n" " bbbbbbbbbbbbbbbbbb : bbbbb,\n" " cccccccccccccccc : ccccccccccccccc\n" " }];"); // Ensure that casts before the key are kept on the same line as the key. verifyFormat( "NSDictionary *d = @@{\n" " (aaaaaaaa id)aaaaaaaaa : (aaaaaaaa id)aaaaaaaaaaaaaaaaaaaaaaaa,\n" " (aaaaaaaa id)aaaaaaaaaaaaaa : (aaaaaaaa id)aaaaaaaaaaaaaa,\n" "};"); Style = getGoogleStyle(FormatStyle::LK_ObjC); verifyFormat( "@@{\n" " NSFontAttributeNameeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee : " "regularFont,\n" "};"); } TEST_F(FormatTestObjC, ObjCArrayLiterals) { verifyIncompleteFormat("@@["); verifyFormat("@@[]"); verifyFormat( "NSArray *array = @@[ @@\" Hey \", NSApp, [NSNumber numberWithInt:42] ];"); verifyFormat("return @@[ @@3, @@[], @@[ @@4, @@5 ] ];"); verifyFormat("NSArray *array = @@[ [foo description] ];"); verifyFormat( "NSArray *some_variable = @@[\n" " aaaa == bbbbbbbbbbb ? @@\"aaaaaaaaaaaa\" : @@\"aaaaaaaaaaaaaa\",\n" " @@\"aaaaaaaaaaaaaaaaa\",\n" " @@\"aaaaaaaaaaaaaaaaa\",\n" " @@\"aaaaaaaaaaaaaaaaa\",\n" "];"); verifyFormat( "NSArray *some_variable = @@[\n" " aaaa == bbbbbbbbbbb ? @@\"aaaaaaaaaaaa\" : @@\"aaaaaaaaaaaaaa\",\n" " @@\"aaaaaaaaaaaaaaaa\", @@\"aaaaaaaaaaaaaaaa\", @@\"aaaaaaaaaaaaaaaa\"\n" "];"); verifyFormat("NSArray *some_variable = @@[\n" " @@\"aaaaaaaaaaaaaaaaa\",\n" " @@\"aaaaaaaaaaaaaaaaa\",\n" " @@\"aaaaaaaaaaaaaaaaa\",\n" " @@\"aaaaaaaaaaaaaaaaa\",\n" "];"); verifyFormat("NSArray *array = @@[\n" " @@\"a\",\n" " @@\"a\",\n" // Trailing comma -> one per line. "];"); // We should try to be robust in case someone forgets the "@@". verifyFormat("NSArray *some_variable = [\n" " @@\"aaaaaaaaaaaaaaaaa\",\n" " @@\"aaaaaaaaaaaaaaaaa\",\n" " @@\"aaaaaaaaaaaaaaaaa\",\n" " @@\"aaaaaaaaaaaaaaaaa\",\n" "];"); verifyFormat( "- (NSAttributedString *)attributedStringForSegment:(NSUInteger)segment\n" " index:(NSUInteger)index\n" " nonDigitAttributes:\n" " (NSDictionary *)noDigitAttributes;"); verifyFormat("[someFunction someLooooooooooooongParameter:@@[\n" " NSBundle.mainBundle.infoDictionary[@@\"a\"]\n" "]];"); } } // end namespace } // end namespace format } // end namespace clang @ 1.1.1.1 log @Import Clang pre-4.0.0 r291444. @ text @@ 1.1.1.2 log @Import clang r309604 from branches/release_50 @ text @d23 1 d36 4 a39 4 enum StatusCheck { SC_ExpectComplete, SC_ExpectIncomplete, SC_DoNotCheck d43 1 a43 1 StatusCheck CheckComplete = SC_ExpectComplete) { d47 1 a47 1 FormattingAttemptStatus Status; d49 4 a52 5 reformat(Style, Code, Ranges, "", &Status); if (CheckComplete != SC_DoNotCheck) { bool ExpectedCompleteFormat = CheckComplete == SC_ExpectComplete; EXPECT_EQ(ExpectedCompleteFormat, Status.FormatComplete) << Code << "\n\n"; d65 1 a65 1 EXPECT_EQ(Code.str(), format(test::messUp(Code), SC_ExpectIncomplete)); d71 4 a74 6 TEST(FormatTestObjCStyle, DetectsObjCInHeaders) { auto Style = getStyle("LLVM", "a.h", "none", "@@interface\n" "- (id)init;"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); d77 1 a77 2 ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); d81 1 a81 2 ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_Cpp, Style->Language); @ 1.1.1.2.4.1 log @Sync with HEAD @ text @d43 2 a44 2 LLVM_DEBUG(llvm::errs() << "---\n"); LLVM_DEBUG(llvm::errs() << Code << "\n\n"); d56 1 a56 1 LLVM_DEBUG(llvm::errs() << "\n" << *Result << "\n\n"); a60 1 EXPECT_EQ(Code.str(), format(Code)) << "Expected code is not stable"; a81 11 Style = getStyle("LLVM", "a.h", "none", "@@interface\n" "@@end\n" "//comment"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); Style = getStyle("LLVM", "a.h", "none", "@@interface\n" "@@end //comment"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); a85 69 Style = getStyle("{}", "a.h", "none", "@@interface Foo\n@@end\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); Style = getStyle("{}", "a.h", "none", "const int interface = 1;\nconst int end = 2;\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_Cpp, Style->Language); Style = getStyle("{}", "a.h", "none", "@@protocol Foo\n@@end\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); Style = getStyle("{}", "a.h", "none", "const int protocol = 1;\nconst int end = 2;\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_Cpp, Style->Language); Style = getStyle("{}", "a.h", "none", "typedef NS_ENUM(NSInteger, Foo) {};\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); Style = getStyle("{}", "a.h", "none", "enum Foo {};"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_Cpp, Style->Language); Style = getStyle("{}", "a.h", "none", "inline void Foo() { Log(@@\"Foo\"); }\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); Style = getStyle("{}", "a.h", "none", "inline void Foo() { Log(\"Foo\"); }\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_Cpp, Style->Language); Style = getStyle("{}", "a.h", "none", "inline void Foo() { id = @@[1, 2, 3]; }\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); Style = getStyle("{}", "a.h", "none", "inline void Foo() { id foo = @@{1: 2, 3: 4, 5: 6}; }\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); Style = getStyle("{}", "a.h", "none", "inline void Foo() { int foo[] = {1, 2, 3}; }\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_Cpp, Style->Language); // ObjC characteristic types. Style = getStyle("{}", "a.h", "none", "extern NSString *kFoo;\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); Style = getStyle("{}", "a.h", "none", "extern NSInteger Foo();\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); Style = getStyle("{}", "a.h", "none", "NSObject *Foo();\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); Style = getStyle("{}", "a.h", "none", "NSSet *Foo();\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); d110 1 a110 2 Style.BreakBeforeBraces = FormatStyle::BS_Custom; Style.BraceWrapping.AfterControlStatement = true; a120 30 TEST_F(FormatTestObjC, FormatObjCGenerics) { Style.ColumnLimit = 40; verifyFormat("int aaaaaaaaaaaaaaaa(\n" " NSArray\n" " aaaaaaaaaaaaaaaaa);\n"); verifyFormat("int aaaaaaaaaaaaaaaa(\n" " NSArray *>\n" " aaaaaaaaaaaaaaaaa);\n"); } TEST_F(FormatTestObjC, FormatObjCSynchronized) { verifyFormat("@@synchronized(self) {\n" " f();\n" "}\n" "@@synchronized(self) {\n" " f();\n" "}\n"); Style.BreakBeforeBraces = FormatStyle::BS_Custom; Style.BraceWrapping.AfterControlStatement = true; verifyFormat("@@synchronized(self)\n" "{\n" " f();\n" "}\n" "@@synchronized(self)\n" "{\n" " f();\n" "}\n"); } a146 6 "@@property(assign, readwrite) NSInteger bar;\n" "+ (id)init;\n" "@@end"); verifyFormat("FOUNDATION_EXPORT NS_AVAILABLE_IOS(10.0) @@interface Foo : Bar\n" "@@property(assign, readwrite) NSInteger bar;\n" a183 12 verifyFormat("@@interface Foo : Bar {\n" " int _i;\n" "}\n" "+ (id)init;\n" "@@end"); verifyFormat("@@interface Foo> : Xyzzy {\n" " int _i;\n" "}\n" "+ (id)init;\n" "@@end"); a200 37 verifyFormat("@@interface Foo\n" "- (void)foo {\n" "}\n" "@@end\n" "@@implementation Bar\n" "- (void)bar {\n" "}\n" "@@end"); Style.ColumnLimit = 40; verifyFormat("@@interface ccccccccccccc () <\n" " ccccccccccccc, ccccccccccccc,\n" " ccccccccccccc, ccccccccccccc> {\n" "}"); verifyFormat("@@interface ccccccccccccc (ccccccccccc) <\n" " ccccccccccccc> {\n" "}"); Style.ObjCBinPackProtocolList = FormatStyle::BPS_Never; verifyFormat("@@interface ddddddddddddd () <\n" " ddddddddddddd,\n" " ddddddddddddd,\n" " ddddddddddddd,\n" " ddddddddddddd> {\n" "}"); Style.BinPackParameters = false; Style.ObjCBinPackProtocolList = FormatStyle::BPS_Auto; verifyFormat("@@interface eeeeeeeeeeeee () <\n" " eeeeeeeeeeeee,\n" " eeeeeeeeeeeee,\n" " eeeeeeeeeeeee,\n" " eeeeeeeeeeeee> {\n" "}"); Style.ObjCBinPackProtocolList = FormatStyle::BPS_Always; verifyFormat("@@interface fffffffffffff () <\n" " fffffffffffff, fffffffffffff,\n" " fffffffffffff, fffffffffffff> {\n" "}"); d203 1 a203 1 verifyFormat("@@interface Foo : NSObject {\n" d215 1 a215 1 verifyFormat("@@interface Foo : Bar \n" d218 1 a218 1 verifyFormat("@@interface Foo (HackStuff) \n" d221 7 a227 10 Style.ColumnLimit = 40; // BinPackParameters should be true by default. verifyFormat("void eeeeeeee(int eeeee, int eeeee,\n" " int eeeee, int eeeee);\n"); // ObjCBinPackProtocolList should be BPS_Never by default. verifyFormat("@@interface fffffffffffff () <\n" " fffffffffffff,\n" " fffffffffffff,\n" " fffffffffffff,\n" " fffffffffffff> {\n" a325 4 verifyFormat("FOUNDATION_EXPORT NS_AVAILABLE_IOS(10.0) @@protocol Foo\n" "@@property(assign, readwrite) NSInteger bar;\n" "@@end"); d346 1 a346 1 verifyFormat("@@protocol MyProtocol \n" a365 1 verifyFormat("+ (instancetype)new;\n"); a372 15 Style.ColumnLimit = 40; // Make sure selectors with 0, 1, or more arguments are indented when wrapped. verifyFormat("- (aaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaaa;\n"); verifyFormat("- (aaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaaa:(int)a;\n"); verifyFormat("- (aaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaaa:(int)a\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaaa:(int)a;\n"); verifyFormat("- (aaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaa:(int)a\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaaa:(int)a;\n"); verifyFormat("- (aaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaaa:(int)a\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaa:(int)a;\n"); d378 1 a469 3 verifyFormat("[self aaaaa:MACRO(a, b:c:, d:e:)];"); verifyFormat("[self aaaaa:MACRO(a, b:c:d:, e:f:g:)];"); verifyFormat("int XYMyFoo(int a, int b) NS_SWIFT_NAME(foo(self:scale:));"); a488 12 unsigned PreviousColumnLimit = Style.ColumnLimit; Style.ColumnLimit = 50; // Instead of: // bool a = // ([object a:42] == 0 || [object a:42 // b:42] == 0); verifyFormat("bool a = ([object a:42] == 0 ||\n" " [object a:42 b:42] == 0);"); Style.ColumnLimit = PreviousColumnLimit; verifyFormat("bool a = ([aaaaaaaa aaaaa] == aaaaaaaaaaaaaaaaa ||\n" " [aaaaaaaa aaaaa] == aaaaaaaaaaaaaaaaaaaa);"); a564 1 d568 2 d574 2 a575 87 " ofSize:aa:bbb\n" " atOrigin:cc:dd];"); // Inline block as a first argument. verifyFormat("[object justBlock:^{\n" " a = 42;\n" "}];"); verifyFormat("[object\n" " justBlock:^{\n" " a = 42;\n" " }\n" " notBlock:42\n" " a:42];"); verifyFormat("[object\n" " firstBlock:^{\n" " a = 42;\n" " }\n" " blockWithLongerName:^{\n" " a = 42;\n" " }];"); verifyFormat("[object\n" " blockWithLongerName:^{\n" " a = 42;\n" " }\n" " secondBlock:^{\n" " a = 42;\n" " }];"); verifyFormat("[object\n" " firstBlock:^{\n" " a = 42;\n" " }\n" " notBlock:42\n" " secondBlock:^{\n" " a = 42;\n" " }];"); // Space between cast rparen and selector name component. verifyFormat("[((Foo *)foo) bar];"); verifyFormat("[((Foo *)foo) bar:1 blech:2];"); Style.ColumnLimit = 20; verifyFormat("aaaaa = [a aa:aa\n" " aa:aa];"); verifyFormat("aaaaaa = [aa aa:aa\n" " aa:aa];"); // Message receiver taking multiple lines. // Non-corner case. verifyFormat("[[object block:^{\n" " return 42;\n" "}] a:42 b:42];"); // Arguments just fit into one line. verifyFormat("[[object block:^{\n" " return 42;\n" "}] aaaaaaa:42 b:42];"); // Arguments just over a column limit. verifyFormat("[[object block:^{\n" " return 42;\n" "}] aaaaaaa:42\n" " bb:42];"); // Arguments just fit into one line. Style.ColumnLimit = 23; verifyFormat("[[obj a:42\n" " b:42\n" " c:42\n" " d:42] e:42 f:42];"); // Arguments do not fit into one line with a receiver. Style.ColumnLimit = 20; verifyFormat("[[obj a:42] a:42\n" " b:42];"); verifyFormat("[[obj a:42] a:42\n" " b:42\n" " c:42];"); verifyFormat("[[obj aaaaaa:42\n" " b:42]\n" " cc:42\n" " d:42];"); // Avoid breaking receiver expression. Style.ColumnLimit = 30; verifyFormat("fooooooo =\n" " [[obj fooo] aaa:42\n" " aaa:42];"); verifyFormat("[[[obj foo] bar] aa:42\n" " bb:42\n" " cc:42];"); a607 20 // Respect continuation indent and colon alignment (e.g. when object name is // short, and first selector is the longest one) Style = getLLVMStyle(); Style.Language = FormatStyle::LK_ObjC; Style.ContinuationIndentWidth = 8; verifyFormat("[self performSelectorOnMainThread:@@selector(loadAccessories)\n" " withObject:nil\n" " waitUntilDone:false];"); verifyFormat("[self performSelector:@@selector(loadAccessories)\n" " withObjectOnMainThread:nil\n" " waitUntilDone:false];"); verifyFormat("[aaaaaaaaaaaaaaaaaaaaaaaaa\n" " performSelectorOnMainThread:@@selector(loadAccessories)\n" " withObject:nil\n" " waitUntilDone:false];"); verifyFormat("[self // force wrapping\n" " performSelectorOnMainThread:@@selector(loadAccessories)\n" " withObject:nil\n" " waitUntilDone:false];"); a643 9 TEST_F(FormatTestObjC, ObjCBlockTypesAndVariables) { verifyFormat("void DoStuffWithBlockType(int (^)(char));"); verifyFormat("int (^foo)(char, float);"); verifyFormat("int (^foo[10])(char, float);"); verifyFormat("int (^foo[kNumEntries])(char, float);"); verifyFormat("int (^foo[kNumEntries + 10])(char, float);"); verifyFormat("int (^foo[(kNumEntries + 10)])(char, float);"); } a667 8 Style.ColumnLimit = 50; verifyFormat("@@interface Foo\n" "- (void)doStuffWithFoo:(id)name\n" " bar:(id)bar\n" " baz:(id)baz\n" " NS_SWIFT_NAME(doStuff(withFoo:bar:baz:));\n" "@@end"); a691 82 verifyFormat("for (Foo *x in bar) {\n}"); verifyFormat("for (Foo *x in [bar baz]) {\n}"); verifyFormat("for (Foo *x in [bar baz:blech]) {\n}"); verifyFormat("for (Foo *x in [bar baz:blech, 1, 2, 3, 0]) {\n}"); verifyFormat("for (Foo *x in [bar baz:^{\n" " [uh oh];\n" " }]) {\n}"); } TEST_F(FormatTestObjC, ObjCCxxKeywords) { verifyFormat("+ (instancetype)new {\n" " return nil;\n" "}\n"); verifyFormat("+ (instancetype)myNew {\n" " return [self new];\n" "}\n"); verifyFormat("SEL NewSelector(void) { return @@selector(new); }\n"); verifyFormat("SEL MacroSelector(void) { return MACRO(new); }\n"); verifyFormat("+ (instancetype)delete {\n" " return nil;\n" "}\n"); verifyFormat("+ (instancetype)myDelete {\n" " return [self delete];\n" "}\n"); verifyFormat("SEL DeleteSelector(void) { return @@selector(delete); }\n"); verifyFormat("SEL MacroSelector(void) { return MACRO(delete); }\n"); verifyFormat("MACRO(new:)\n"); verifyFormat("MACRO(delete:)\n"); verifyFormat("foo = @@{MACRO(new:) : MACRO(delete:)}\n"); verifyFormat("@@implementation Foo\n" "// Testing\n" "- (Class)class {\n" "}\n" "- (void)foo {\n" "}\n" "@@end\n"); verifyFormat("@@implementation Foo\n" "- (Class)class {\n" "}\n" "- (void)foo {\n" "}\n" "@@end"); verifyFormat("@@implementation Foo\n" "+ (Class)class {\n" "}\n" "- (void)foo {\n" "}\n" "@@end"); verifyFormat("@@implementation Foo\n" "- (Class)class:(Class)klass {\n" "}\n" "- (void)foo {\n" "}\n" "@@end"); verifyFormat("@@implementation Foo\n" "+ (Class)class:(Class)klass {\n" "}\n" "- (void)foo {\n" "}\n" "@@end"); verifyFormat("@@interface Foo\n" "// Testing\n" "- (Class)class;\n" "- (void)foo;\n" "@@end\n"); verifyFormat("@@interface Foo\n" "- (Class)class;\n" "- (void)foo;\n" "@@end"); verifyFormat("@@interface Foo\n" "+ (Class)class;\n" "- (void)foo;\n" "@@end"); verifyFormat("@@interface Foo\n" "- (Class)class:(Class)klass;\n" "- (void)foo;\n" "@@end"); verifyFormat("@@interface Foo\n" "+ (Class)class:(Class)klass;\n" "- (void)foo;\n" "@@end"); a767 24 Style.ColumnLimit = 40; verifyFormat("int Foo() {\n" " a12345 = @@{a12345 : a12345};\n" "}"); verifyFormat("int Foo() {\n" " a12345 = @@{a12345 : @@(a12345)};\n" "}"); verifyFormat("int Foo() {\n" " a12345 = @@{(Foo *)a12345 : @@(a12345)};\n" "}"); verifyFormat("int Foo() {\n" " a12345 = @@{@@(a12345) : a12345};\n" "}"); verifyFormat("int Foo() {\n" " a12345 = @@{@@(a12345) : @@YES};\n" "}"); Style.SpacesInContainerLiterals = false; verifyFormat("int Foo() {\n" " b12345 = @@{b12345: b12345};\n" "}"); verifyFormat("int Foo() {\n" " b12345 = @@{(Foo *)b12345: @@(b12345)};\n" "}"); Style.SpacesInContainerLiterals = true; a822 32 Style.ColumnLimit = 40; verifyFormat("int Foo() {\n" " a12345 = @@[ a12345, a12345 ];\n" "}"); verifyFormat("int Foo() {\n" " a123 = @@[ (Foo *)a12345, @@(a12345) ];\n" "}"); Style.SpacesInContainerLiterals = false; verifyFormat("int Foo() {\n" " b12345 = @@[b12345, b12345];\n" "}"); verifyFormat("int Foo() {\n" " b12345 = @@[(Foo *)b12345, @@(b12345)];\n" "}"); Style.SpacesInContainerLiterals = true; Style.ColumnLimit = 20; // We can't break string literals inside NSArray literals // (that raises -Wobjc-string-concatenation). verifyFormat("NSArray *foo = @@[\n" " @@\"aaaaaaaaaaaaaaaaaaaaaaaaaa\"\n" "];\n"); } TEST_F(FormatTestObjC, BreaksCallStatementWhereSemiJustOverTheLimit) { Style.ColumnLimit = 60; // If the statement starting with 'a = ...' is put on a single line, the ';' // is at line 61. verifyFormat("int f(int a) {\n" " a = [self aaaaaaaaaa:bbbbbbbbb\n" " ccccccccc:dddddddd\n" " ee:fddd];\n" "}"); a823 21 TEST_F(FormatTestObjC, AlwaysBreakBeforeMultilineStrings) { Style = getGoogleStyle(FormatStyle::LK_ObjC); Style.ColumnLimit = 40; verifyFormat("aaaa = @@\"bbbb\"\n" " @@\"cccc\";"); verifyFormat("aaaa(@@\"bbbb\"\n" " @@\"cccc\");"); verifyFormat("aaaa(qqq, @@\"bbbb\"\n" " @@\"cccc\");"); verifyFormat("[aaaa qqqq:@@\"bbbb\"\n" " @@\"cccc\"];"); verifyFormat("aaaa = [aaaa qqqq:@@\"bbbb\"\n" " @@\"cccc\"];"); verifyFormat("[aaaa qqqq:@@\"bbbb\"\n" " @@\"cccc\"\n" " rr:42\n" " ssssss:@@\"ee\"\n" " @@\"fffff\"];"); } @ 1.1.1.2.4.2 log @Mostly merge changes from HEAD upto 20200411 @ text @@ 1.1.1.2.2.1 log @Sync with HEAD @ text @d43 2 a44 2 LLVM_DEBUG(llvm::errs() << "---\n"); LLVM_DEBUG(llvm::errs() << Code << "\n\n"); d56 1 a56 1 LLVM_DEBUG(llvm::errs() << "\n" << *Result << "\n\n"); a60 1 EXPECT_EQ(Code.str(), format(Code)) << "Expected code is not stable"; a81 11 Style = getStyle("LLVM", "a.h", "none", "@@interface\n" "@@end\n" "//comment"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); Style = getStyle("LLVM", "a.h", "none", "@@interface\n" "@@end //comment"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); a85 69 Style = getStyle("{}", "a.h", "none", "@@interface Foo\n@@end\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); Style = getStyle("{}", "a.h", "none", "const int interface = 1;\nconst int end = 2;\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_Cpp, Style->Language); Style = getStyle("{}", "a.h", "none", "@@protocol Foo\n@@end\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); Style = getStyle("{}", "a.h", "none", "const int protocol = 1;\nconst int end = 2;\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_Cpp, Style->Language); Style = getStyle("{}", "a.h", "none", "typedef NS_ENUM(NSInteger, Foo) {};\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); Style = getStyle("{}", "a.h", "none", "enum Foo {};"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_Cpp, Style->Language); Style = getStyle("{}", "a.h", "none", "inline void Foo() { Log(@@\"Foo\"); }\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); Style = getStyle("{}", "a.h", "none", "inline void Foo() { Log(\"Foo\"); }\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_Cpp, Style->Language); Style = getStyle("{}", "a.h", "none", "inline void Foo() { id = @@[1, 2, 3]; }\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); Style = getStyle("{}", "a.h", "none", "inline void Foo() { id foo = @@{1: 2, 3: 4, 5: 6}; }\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); Style = getStyle("{}", "a.h", "none", "inline void Foo() { int foo[] = {1, 2, 3}; }\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_Cpp, Style->Language); // ObjC characteristic types. Style = getStyle("{}", "a.h", "none", "extern NSString *kFoo;\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); Style = getStyle("{}", "a.h", "none", "extern NSInteger Foo();\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); Style = getStyle("{}", "a.h", "none", "NSObject *Foo();\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); Style = getStyle("{}", "a.h", "none", "NSSet *Foo();\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); d110 1 a110 2 Style.BreakBeforeBraces = FormatStyle::BS_Custom; Style.BraceWrapping.AfterControlStatement = true; a120 30 TEST_F(FormatTestObjC, FormatObjCGenerics) { Style.ColumnLimit = 40; verifyFormat("int aaaaaaaaaaaaaaaa(\n" " NSArray\n" " aaaaaaaaaaaaaaaaa);\n"); verifyFormat("int aaaaaaaaaaaaaaaa(\n" " NSArray *>\n" " aaaaaaaaaaaaaaaaa);\n"); } TEST_F(FormatTestObjC, FormatObjCSynchronized) { verifyFormat("@@synchronized(self) {\n" " f();\n" "}\n" "@@synchronized(self) {\n" " f();\n" "}\n"); Style.BreakBeforeBraces = FormatStyle::BS_Custom; Style.BraceWrapping.AfterControlStatement = true; verifyFormat("@@synchronized(self)\n" "{\n" " f();\n" "}\n" "@@synchronized(self)\n" "{\n" " f();\n" "}\n"); } a146 6 "@@property(assign, readwrite) NSInteger bar;\n" "+ (id)init;\n" "@@end"); verifyFormat("FOUNDATION_EXPORT NS_AVAILABLE_IOS(10.0) @@interface Foo : Bar\n" "@@property(assign, readwrite) NSInteger bar;\n" a183 12 verifyFormat("@@interface Foo : Bar {\n" " int _i;\n" "}\n" "+ (id)init;\n" "@@end"); verifyFormat("@@interface Foo> : Xyzzy {\n" " int _i;\n" "}\n" "+ (id)init;\n" "@@end"); a200 37 verifyFormat("@@interface Foo\n" "- (void)foo {\n" "}\n" "@@end\n" "@@implementation Bar\n" "- (void)bar {\n" "}\n" "@@end"); Style.ColumnLimit = 40; verifyFormat("@@interface ccccccccccccc () <\n" " ccccccccccccc, ccccccccccccc,\n" " ccccccccccccc, ccccccccccccc> {\n" "}"); verifyFormat("@@interface ccccccccccccc (ccccccccccc) <\n" " ccccccccccccc> {\n" "}"); Style.ObjCBinPackProtocolList = FormatStyle::BPS_Never; verifyFormat("@@interface ddddddddddddd () <\n" " ddddddddddddd,\n" " ddddddddddddd,\n" " ddddddddddddd,\n" " ddddddddddddd> {\n" "}"); Style.BinPackParameters = false; Style.ObjCBinPackProtocolList = FormatStyle::BPS_Auto; verifyFormat("@@interface eeeeeeeeeeeee () <\n" " eeeeeeeeeeeee,\n" " eeeeeeeeeeeee,\n" " eeeeeeeeeeeee,\n" " eeeeeeeeeeeee> {\n" "}"); Style.ObjCBinPackProtocolList = FormatStyle::BPS_Always; verifyFormat("@@interface fffffffffffff () <\n" " fffffffffffff, fffffffffffff,\n" " fffffffffffff, fffffffffffff> {\n" "}"); d203 1 a203 1 verifyFormat("@@interface Foo : NSObject {\n" d215 1 a215 1 verifyFormat("@@interface Foo : Bar \n" d218 1 a218 1 verifyFormat("@@interface Foo (HackStuff) \n" d221 7 a227 10 Style.ColumnLimit = 40; // BinPackParameters should be true by default. verifyFormat("void eeeeeeee(int eeeee, int eeeee,\n" " int eeeee, int eeeee);\n"); // ObjCBinPackProtocolList should be BPS_Never by default. verifyFormat("@@interface fffffffffffff () <\n" " fffffffffffff,\n" " fffffffffffff,\n" " fffffffffffff,\n" " fffffffffffff> {\n" a325 4 verifyFormat("FOUNDATION_EXPORT NS_AVAILABLE_IOS(10.0) @@protocol Foo\n" "@@property(assign, readwrite) NSInteger bar;\n" "@@end"); d346 1 a346 1 verifyFormat("@@protocol MyProtocol \n" a365 1 verifyFormat("+ (instancetype)new;\n"); a372 15 Style.ColumnLimit = 40; // Make sure selectors with 0, 1, or more arguments are indented when wrapped. verifyFormat("- (aaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaaa;\n"); verifyFormat("- (aaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaaa:(int)a;\n"); verifyFormat("- (aaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaaa:(int)a\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaaa:(int)a;\n"); verifyFormat("- (aaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaa:(int)a\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaaa:(int)a;\n"); verifyFormat("- (aaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaaa:(int)a\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaa:(int)a;\n"); d378 1 a469 3 verifyFormat("[self aaaaa:MACRO(a, b:c:, d:e:)];"); verifyFormat("[self aaaaa:MACRO(a, b:c:d:, e:f:g:)];"); verifyFormat("int XYMyFoo(int a, int b) NS_SWIFT_NAME(foo(self:scale:));"); a488 12 unsigned PreviousColumnLimit = Style.ColumnLimit; Style.ColumnLimit = 50; // Instead of: // bool a = // ([object a:42] == 0 || [object a:42 // b:42] == 0); verifyFormat("bool a = ([object a:42] == 0 ||\n" " [object a:42 b:42] == 0);"); Style.ColumnLimit = PreviousColumnLimit; verifyFormat("bool a = ([aaaaaaaa aaaaa] == aaaaaaaaaaaaaaaaa ||\n" " [aaaaaaaa aaaaa] == aaaaaaaaaaaaaaaaaaaa);"); a564 1 d568 2 d574 2 a575 87 " ofSize:aa:bbb\n" " atOrigin:cc:dd];"); // Inline block as a first argument. verifyFormat("[object justBlock:^{\n" " a = 42;\n" "}];"); verifyFormat("[object\n" " justBlock:^{\n" " a = 42;\n" " }\n" " notBlock:42\n" " a:42];"); verifyFormat("[object\n" " firstBlock:^{\n" " a = 42;\n" " }\n" " blockWithLongerName:^{\n" " a = 42;\n" " }];"); verifyFormat("[object\n" " blockWithLongerName:^{\n" " a = 42;\n" " }\n" " secondBlock:^{\n" " a = 42;\n" " }];"); verifyFormat("[object\n" " firstBlock:^{\n" " a = 42;\n" " }\n" " notBlock:42\n" " secondBlock:^{\n" " a = 42;\n" " }];"); // Space between cast rparen and selector name component. verifyFormat("[((Foo *)foo) bar];"); verifyFormat("[((Foo *)foo) bar:1 blech:2];"); Style.ColumnLimit = 20; verifyFormat("aaaaa = [a aa:aa\n" " aa:aa];"); verifyFormat("aaaaaa = [aa aa:aa\n" " aa:aa];"); // Message receiver taking multiple lines. // Non-corner case. verifyFormat("[[object block:^{\n" " return 42;\n" "}] a:42 b:42];"); // Arguments just fit into one line. verifyFormat("[[object block:^{\n" " return 42;\n" "}] aaaaaaa:42 b:42];"); // Arguments just over a column limit. verifyFormat("[[object block:^{\n" " return 42;\n" "}] aaaaaaa:42\n" " bb:42];"); // Arguments just fit into one line. Style.ColumnLimit = 23; verifyFormat("[[obj a:42\n" " b:42\n" " c:42\n" " d:42] e:42 f:42];"); // Arguments do not fit into one line with a receiver. Style.ColumnLimit = 20; verifyFormat("[[obj a:42] a:42\n" " b:42];"); verifyFormat("[[obj a:42] a:42\n" " b:42\n" " c:42];"); verifyFormat("[[obj aaaaaa:42\n" " b:42]\n" " cc:42\n" " d:42];"); // Avoid breaking receiver expression. Style.ColumnLimit = 30; verifyFormat("fooooooo =\n" " [[obj fooo] aaa:42\n" " aaa:42];"); verifyFormat("[[[obj foo] bar] aa:42\n" " bb:42\n" " cc:42];"); a607 20 // Respect continuation indent and colon alignment (e.g. when object name is // short, and first selector is the longest one) Style = getLLVMStyle(); Style.Language = FormatStyle::LK_ObjC; Style.ContinuationIndentWidth = 8; verifyFormat("[self performSelectorOnMainThread:@@selector(loadAccessories)\n" " withObject:nil\n" " waitUntilDone:false];"); verifyFormat("[self performSelector:@@selector(loadAccessories)\n" " withObjectOnMainThread:nil\n" " waitUntilDone:false];"); verifyFormat("[aaaaaaaaaaaaaaaaaaaaaaaaa\n" " performSelectorOnMainThread:@@selector(loadAccessories)\n" " withObject:nil\n" " waitUntilDone:false];"); verifyFormat("[self // force wrapping\n" " performSelectorOnMainThread:@@selector(loadAccessories)\n" " withObject:nil\n" " waitUntilDone:false];"); a643 9 TEST_F(FormatTestObjC, ObjCBlockTypesAndVariables) { verifyFormat("void DoStuffWithBlockType(int (^)(char));"); verifyFormat("int (^foo)(char, float);"); verifyFormat("int (^foo[10])(char, float);"); verifyFormat("int (^foo[kNumEntries])(char, float);"); verifyFormat("int (^foo[kNumEntries + 10])(char, float);"); verifyFormat("int (^foo[(kNumEntries + 10)])(char, float);"); } a667 8 Style.ColumnLimit = 50; verifyFormat("@@interface Foo\n" "- (void)doStuffWithFoo:(id)name\n" " bar:(id)bar\n" " baz:(id)baz\n" " NS_SWIFT_NAME(doStuff(withFoo:bar:baz:));\n" "@@end"); a691 82 verifyFormat("for (Foo *x in bar) {\n}"); verifyFormat("for (Foo *x in [bar baz]) {\n}"); verifyFormat("for (Foo *x in [bar baz:blech]) {\n}"); verifyFormat("for (Foo *x in [bar baz:blech, 1, 2, 3, 0]) {\n}"); verifyFormat("for (Foo *x in [bar baz:^{\n" " [uh oh];\n" " }]) {\n}"); } TEST_F(FormatTestObjC, ObjCCxxKeywords) { verifyFormat("+ (instancetype)new {\n" " return nil;\n" "}\n"); verifyFormat("+ (instancetype)myNew {\n" " return [self new];\n" "}\n"); verifyFormat("SEL NewSelector(void) { return @@selector(new); }\n"); verifyFormat("SEL MacroSelector(void) { return MACRO(new); }\n"); verifyFormat("+ (instancetype)delete {\n" " return nil;\n" "}\n"); verifyFormat("+ (instancetype)myDelete {\n" " return [self delete];\n" "}\n"); verifyFormat("SEL DeleteSelector(void) { return @@selector(delete); }\n"); verifyFormat("SEL MacroSelector(void) { return MACRO(delete); }\n"); verifyFormat("MACRO(new:)\n"); verifyFormat("MACRO(delete:)\n"); verifyFormat("foo = @@{MACRO(new:) : MACRO(delete:)}\n"); verifyFormat("@@implementation Foo\n" "// Testing\n" "- (Class)class {\n" "}\n" "- (void)foo {\n" "}\n" "@@end\n"); verifyFormat("@@implementation Foo\n" "- (Class)class {\n" "}\n" "- (void)foo {\n" "}\n" "@@end"); verifyFormat("@@implementation Foo\n" "+ (Class)class {\n" "}\n" "- (void)foo {\n" "}\n" "@@end"); verifyFormat("@@implementation Foo\n" "- (Class)class:(Class)klass {\n" "}\n" "- (void)foo {\n" "}\n" "@@end"); verifyFormat("@@implementation Foo\n" "+ (Class)class:(Class)klass {\n" "}\n" "- (void)foo {\n" "}\n" "@@end"); verifyFormat("@@interface Foo\n" "// Testing\n" "- (Class)class;\n" "- (void)foo;\n" "@@end\n"); verifyFormat("@@interface Foo\n" "- (Class)class;\n" "- (void)foo;\n" "@@end"); verifyFormat("@@interface Foo\n" "+ (Class)class;\n" "- (void)foo;\n" "@@end"); verifyFormat("@@interface Foo\n" "- (Class)class:(Class)klass;\n" "- (void)foo;\n" "@@end"); verifyFormat("@@interface Foo\n" "+ (Class)class:(Class)klass;\n" "- (void)foo;\n" "@@end"); a767 24 Style.ColumnLimit = 40; verifyFormat("int Foo() {\n" " a12345 = @@{a12345 : a12345};\n" "}"); verifyFormat("int Foo() {\n" " a12345 = @@{a12345 : @@(a12345)};\n" "}"); verifyFormat("int Foo() {\n" " a12345 = @@{(Foo *)a12345 : @@(a12345)};\n" "}"); verifyFormat("int Foo() {\n" " a12345 = @@{@@(a12345) : a12345};\n" "}"); verifyFormat("int Foo() {\n" " a12345 = @@{@@(a12345) : @@YES};\n" "}"); Style.SpacesInContainerLiterals = false; verifyFormat("int Foo() {\n" " b12345 = @@{b12345: b12345};\n" "}"); verifyFormat("int Foo() {\n" " b12345 = @@{(Foo *)b12345: @@(b12345)};\n" "}"); Style.SpacesInContainerLiterals = true; a822 32 Style.ColumnLimit = 40; verifyFormat("int Foo() {\n" " a12345 = @@[ a12345, a12345 ];\n" "}"); verifyFormat("int Foo() {\n" " a123 = @@[ (Foo *)a12345, @@(a12345) ];\n" "}"); Style.SpacesInContainerLiterals = false; verifyFormat("int Foo() {\n" " b12345 = @@[b12345, b12345];\n" "}"); verifyFormat("int Foo() {\n" " b12345 = @@[(Foo *)b12345, @@(b12345)];\n" "}"); Style.SpacesInContainerLiterals = true; Style.ColumnLimit = 20; // We can't break string literals inside NSArray literals // (that raises -Wobjc-string-concatenation). verifyFormat("NSArray *foo = @@[\n" " @@\"aaaaaaaaaaaaaaaaaaaaaaaaaa\"\n" "];\n"); } TEST_F(FormatTestObjC, BreaksCallStatementWhereSemiJustOverTheLimit) { Style.ColumnLimit = 60; // If the statement starting with 'a = ...' is put on a single line, the ';' // is at line 61. verifyFormat("int f(int a) {\n" " a = [self aaaaaaaaaa:bbbbbbbbb\n" " ccccccccc:dddddddd\n" " ee:fddd];\n" "}"); a823 21 TEST_F(FormatTestObjC, AlwaysBreakBeforeMultilineStrings) { Style = getGoogleStyle(FormatStyle::LK_ObjC); Style.ColumnLimit = 40; verifyFormat("aaaa = @@\"bbbb\"\n" " @@\"cccc\";"); verifyFormat("aaaa(@@\"bbbb\"\n" " @@\"cccc\");"); verifyFormat("aaaa(qqq, @@\"bbbb\"\n" " @@\"cccc\");"); verifyFormat("[aaaa qqqq:@@\"bbbb\"\n" " @@\"cccc\"];"); verifyFormat("aaaa = [aaaa qqqq:@@\"bbbb\"\n" " @@\"cccc\"];"); verifyFormat("[aaaa qqqq:@@\"bbbb\"\n" " @@\"cccc\"\n" " rr:42\n" " ssssss:@@\"ee\"\n" " @@\"fffff\"];"); } @ 1.1.1.3 log @Import clang r337282 from trunk @ text @d43 2 a44 2 LLVM_DEBUG(llvm::errs() << "---\n"); LLVM_DEBUG(llvm::errs() << Code << "\n\n"); d56 1 a56 1 LLVM_DEBUG(llvm::errs() << "\n" << *Result << "\n\n"); a60 1 EXPECT_EQ(Code.str(), format(Code)) << "Expected code is not stable"; a81 11 Style = getStyle("LLVM", "a.h", "none", "@@interface\n" "@@end\n" "//comment"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); Style = getStyle("LLVM", "a.h", "none", "@@interface\n" "@@end //comment"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); a85 69 Style = getStyle("{}", "a.h", "none", "@@interface Foo\n@@end\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); Style = getStyle("{}", "a.h", "none", "const int interface = 1;\nconst int end = 2;\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_Cpp, Style->Language); Style = getStyle("{}", "a.h", "none", "@@protocol Foo\n@@end\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); Style = getStyle("{}", "a.h", "none", "const int protocol = 1;\nconst int end = 2;\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_Cpp, Style->Language); Style = getStyle("{}", "a.h", "none", "typedef NS_ENUM(NSInteger, Foo) {};\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); Style = getStyle("{}", "a.h", "none", "enum Foo {};"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_Cpp, Style->Language); Style = getStyle("{}", "a.h", "none", "inline void Foo() { Log(@@\"Foo\"); }\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); Style = getStyle("{}", "a.h", "none", "inline void Foo() { Log(\"Foo\"); }\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_Cpp, Style->Language); Style = getStyle("{}", "a.h", "none", "inline void Foo() { id = @@[1, 2, 3]; }\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); Style = getStyle("{}", "a.h", "none", "inline void Foo() { id foo = @@{1: 2, 3: 4, 5: 6}; }\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); Style = getStyle("{}", "a.h", "none", "inline void Foo() { int foo[] = {1, 2, 3}; }\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_Cpp, Style->Language); // ObjC characteristic types. Style = getStyle("{}", "a.h", "none", "extern NSString *kFoo;\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); Style = getStyle("{}", "a.h", "none", "extern NSInteger Foo();\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); Style = getStyle("{}", "a.h", "none", "NSObject *Foo();\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); Style = getStyle("{}", "a.h", "none", "NSSet *Foo();\n"); ASSERT_TRUE((bool)Style); EXPECT_EQ(FormatStyle::LK_ObjC, Style->Language); d110 1 a110 2 Style.BreakBeforeBraces = FormatStyle::BS_Custom; Style.BraceWrapping.AfterControlStatement = true; a120 30 TEST_F(FormatTestObjC, FormatObjCGenerics) { Style.ColumnLimit = 40; verifyFormat("int aaaaaaaaaaaaaaaa(\n" " NSArray\n" " aaaaaaaaaaaaaaaaa);\n"); verifyFormat("int aaaaaaaaaaaaaaaa(\n" " NSArray *>\n" " aaaaaaaaaaaaaaaaa);\n"); } TEST_F(FormatTestObjC, FormatObjCSynchronized) { verifyFormat("@@synchronized(self) {\n" " f();\n" "}\n" "@@synchronized(self) {\n" " f();\n" "}\n"); Style.BreakBeforeBraces = FormatStyle::BS_Custom; Style.BraceWrapping.AfterControlStatement = true; verifyFormat("@@synchronized(self)\n" "{\n" " f();\n" "}\n" "@@synchronized(self)\n" "{\n" " f();\n" "}\n"); } a146 6 "@@property(assign, readwrite) NSInteger bar;\n" "+ (id)init;\n" "@@end"); verifyFormat("FOUNDATION_EXPORT NS_AVAILABLE_IOS(10.0) @@interface Foo : Bar\n" "@@property(assign, readwrite) NSInteger bar;\n" a183 12 verifyFormat("@@interface Foo : Bar {\n" " int _i;\n" "}\n" "+ (id)init;\n" "@@end"); verifyFormat("@@interface Foo> : Xyzzy {\n" " int _i;\n" "}\n" "+ (id)init;\n" "@@end"); a200 37 verifyFormat("@@interface Foo\n" "- (void)foo {\n" "}\n" "@@end\n" "@@implementation Bar\n" "- (void)bar {\n" "}\n" "@@end"); Style.ColumnLimit = 40; verifyFormat("@@interface ccccccccccccc () <\n" " ccccccccccccc, ccccccccccccc,\n" " ccccccccccccc, ccccccccccccc> {\n" "}"); verifyFormat("@@interface ccccccccccccc (ccccccccccc) <\n" " ccccccccccccc> {\n" "}"); Style.ObjCBinPackProtocolList = FormatStyle::BPS_Never; verifyFormat("@@interface ddddddddddddd () <\n" " ddddddddddddd,\n" " ddddddddddddd,\n" " ddddddddddddd,\n" " ddddddddddddd> {\n" "}"); Style.BinPackParameters = false; Style.ObjCBinPackProtocolList = FormatStyle::BPS_Auto; verifyFormat("@@interface eeeeeeeeeeeee () <\n" " eeeeeeeeeeeee,\n" " eeeeeeeeeeeee,\n" " eeeeeeeeeeeee,\n" " eeeeeeeeeeeee> {\n" "}"); Style.ObjCBinPackProtocolList = FormatStyle::BPS_Always; verifyFormat("@@interface fffffffffffff () <\n" " fffffffffffff, fffffffffffff,\n" " fffffffffffff, fffffffffffff> {\n" "}"); d203 1 a203 1 verifyFormat("@@interface Foo : NSObject {\n" d215 1 a215 1 verifyFormat("@@interface Foo : Bar \n" d218 1 a218 1 verifyFormat("@@interface Foo (HackStuff) \n" d221 7 a227 10 Style.ColumnLimit = 40; // BinPackParameters should be true by default. verifyFormat("void eeeeeeee(int eeeee, int eeeee,\n" " int eeeee, int eeeee);\n"); // ObjCBinPackProtocolList should be BPS_Never by default. verifyFormat("@@interface fffffffffffff () <\n" " fffffffffffff,\n" " fffffffffffff,\n" " fffffffffffff,\n" " fffffffffffff> {\n" a325 4 verifyFormat("FOUNDATION_EXPORT NS_AVAILABLE_IOS(10.0) @@protocol Foo\n" "@@property(assign, readwrite) NSInteger bar;\n" "@@end"); d346 1 a346 1 verifyFormat("@@protocol MyProtocol \n" a365 1 verifyFormat("+ (instancetype)new;\n"); a372 15 Style.ColumnLimit = 40; // Make sure selectors with 0, 1, or more arguments are indented when wrapped. verifyFormat("- (aaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaaa;\n"); verifyFormat("- (aaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaaa:(int)a;\n"); verifyFormat("- (aaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaaa:(int)a\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaaa:(int)a;\n"); verifyFormat("- (aaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaa:(int)a\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaaa:(int)a;\n"); verifyFormat("- (aaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaaa:(int)a\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaa:(int)a;\n"); d378 1 a469 3 verifyFormat("[self aaaaa:MACRO(a, b:c:, d:e:)];"); verifyFormat("[self aaaaa:MACRO(a, b:c:d:, e:f:g:)];"); verifyFormat("int XYMyFoo(int a, int b) NS_SWIFT_NAME(foo(self:scale:));"); a488 12 unsigned PreviousColumnLimit = Style.ColumnLimit; Style.ColumnLimit = 50; // Instead of: // bool a = // ([object a:42] == 0 || [object a:42 // b:42] == 0); verifyFormat("bool a = ([object a:42] == 0 ||\n" " [object a:42 b:42] == 0);"); Style.ColumnLimit = PreviousColumnLimit; verifyFormat("bool a = ([aaaaaaaa aaaaa] == aaaaaaaaaaaaaaaaa ||\n" " [aaaaaaaa aaaaa] == aaaaaaaaaaaaaaaaaaaa);"); a564 1 d568 2 d574 2 a575 87 " ofSize:aa:bbb\n" " atOrigin:cc:dd];"); // Inline block as a first argument. verifyFormat("[object justBlock:^{\n" " a = 42;\n" "}];"); verifyFormat("[object\n" " justBlock:^{\n" " a = 42;\n" " }\n" " notBlock:42\n" " a:42];"); verifyFormat("[object\n" " firstBlock:^{\n" " a = 42;\n" " }\n" " blockWithLongerName:^{\n" " a = 42;\n" " }];"); verifyFormat("[object\n" " blockWithLongerName:^{\n" " a = 42;\n" " }\n" " secondBlock:^{\n" " a = 42;\n" " }];"); verifyFormat("[object\n" " firstBlock:^{\n" " a = 42;\n" " }\n" " notBlock:42\n" " secondBlock:^{\n" " a = 42;\n" " }];"); // Space between cast rparen and selector name component. verifyFormat("[((Foo *)foo) bar];"); verifyFormat("[((Foo *)foo) bar:1 blech:2];"); Style.ColumnLimit = 20; verifyFormat("aaaaa = [a aa:aa\n" " aa:aa];"); verifyFormat("aaaaaa = [aa aa:aa\n" " aa:aa];"); // Message receiver taking multiple lines. // Non-corner case. verifyFormat("[[object block:^{\n" " return 42;\n" "}] a:42 b:42];"); // Arguments just fit into one line. verifyFormat("[[object block:^{\n" " return 42;\n" "}] aaaaaaa:42 b:42];"); // Arguments just over a column limit. verifyFormat("[[object block:^{\n" " return 42;\n" "}] aaaaaaa:42\n" " bb:42];"); // Arguments just fit into one line. Style.ColumnLimit = 23; verifyFormat("[[obj a:42\n" " b:42\n" " c:42\n" " d:42] e:42 f:42];"); // Arguments do not fit into one line with a receiver. Style.ColumnLimit = 20; verifyFormat("[[obj a:42] a:42\n" " b:42];"); verifyFormat("[[obj a:42] a:42\n" " b:42\n" " c:42];"); verifyFormat("[[obj aaaaaa:42\n" " b:42]\n" " cc:42\n" " d:42];"); // Avoid breaking receiver expression. Style.ColumnLimit = 30; verifyFormat("fooooooo =\n" " [[obj fooo] aaa:42\n" " aaa:42];"); verifyFormat("[[[obj foo] bar] aa:42\n" " bb:42\n" " cc:42];"); a607 20 // Respect continuation indent and colon alignment (e.g. when object name is // short, and first selector is the longest one) Style = getLLVMStyle(); Style.Language = FormatStyle::LK_ObjC; Style.ContinuationIndentWidth = 8; verifyFormat("[self performSelectorOnMainThread:@@selector(loadAccessories)\n" " withObject:nil\n" " waitUntilDone:false];"); verifyFormat("[self performSelector:@@selector(loadAccessories)\n" " withObjectOnMainThread:nil\n" " waitUntilDone:false];"); verifyFormat("[aaaaaaaaaaaaaaaaaaaaaaaaa\n" " performSelectorOnMainThread:@@selector(loadAccessories)\n" " withObject:nil\n" " waitUntilDone:false];"); verifyFormat("[self // force wrapping\n" " performSelectorOnMainThread:@@selector(loadAccessories)\n" " withObject:nil\n" " waitUntilDone:false];"); a643 9 TEST_F(FormatTestObjC, ObjCBlockTypesAndVariables) { verifyFormat("void DoStuffWithBlockType(int (^)(char));"); verifyFormat("int (^foo)(char, float);"); verifyFormat("int (^foo[10])(char, float);"); verifyFormat("int (^foo[kNumEntries])(char, float);"); verifyFormat("int (^foo[kNumEntries + 10])(char, float);"); verifyFormat("int (^foo[(kNumEntries + 10)])(char, float);"); } a667 8 Style.ColumnLimit = 50; verifyFormat("@@interface Foo\n" "- (void)doStuffWithFoo:(id)name\n" " bar:(id)bar\n" " baz:(id)baz\n" " NS_SWIFT_NAME(doStuff(withFoo:bar:baz:));\n" "@@end"); a691 82 verifyFormat("for (Foo *x in bar) {\n}"); verifyFormat("for (Foo *x in [bar baz]) {\n}"); verifyFormat("for (Foo *x in [bar baz:blech]) {\n}"); verifyFormat("for (Foo *x in [bar baz:blech, 1, 2, 3, 0]) {\n}"); verifyFormat("for (Foo *x in [bar baz:^{\n" " [uh oh];\n" " }]) {\n}"); } TEST_F(FormatTestObjC, ObjCCxxKeywords) { verifyFormat("+ (instancetype)new {\n" " return nil;\n" "}\n"); verifyFormat("+ (instancetype)myNew {\n" " return [self new];\n" "}\n"); verifyFormat("SEL NewSelector(void) { return @@selector(new); }\n"); verifyFormat("SEL MacroSelector(void) { return MACRO(new); }\n"); verifyFormat("+ (instancetype)delete {\n" " return nil;\n" "}\n"); verifyFormat("+ (instancetype)myDelete {\n" " return [self delete];\n" "}\n"); verifyFormat("SEL DeleteSelector(void) { return @@selector(delete); }\n"); verifyFormat("SEL MacroSelector(void) { return MACRO(delete); }\n"); verifyFormat("MACRO(new:)\n"); verifyFormat("MACRO(delete:)\n"); verifyFormat("foo = @@{MACRO(new:) : MACRO(delete:)}\n"); verifyFormat("@@implementation Foo\n" "// Testing\n" "- (Class)class {\n" "}\n" "- (void)foo {\n" "}\n" "@@end\n"); verifyFormat("@@implementation Foo\n" "- (Class)class {\n" "}\n" "- (void)foo {\n" "}\n" "@@end"); verifyFormat("@@implementation Foo\n" "+ (Class)class {\n" "}\n" "- (void)foo {\n" "}\n" "@@end"); verifyFormat("@@implementation Foo\n" "- (Class)class:(Class)klass {\n" "}\n" "- (void)foo {\n" "}\n" "@@end"); verifyFormat("@@implementation Foo\n" "+ (Class)class:(Class)klass {\n" "}\n" "- (void)foo {\n" "}\n" "@@end"); verifyFormat("@@interface Foo\n" "// Testing\n" "- (Class)class;\n" "- (void)foo;\n" "@@end\n"); verifyFormat("@@interface Foo\n" "- (Class)class;\n" "- (void)foo;\n" "@@end"); verifyFormat("@@interface Foo\n" "+ (Class)class;\n" "- (void)foo;\n" "@@end"); verifyFormat("@@interface Foo\n" "- (Class)class:(Class)klass;\n" "- (void)foo;\n" "@@end"); verifyFormat("@@interface Foo\n" "+ (Class)class:(Class)klass;\n" "- (void)foo;\n" "@@end"); a767 24 Style.ColumnLimit = 40; verifyFormat("int Foo() {\n" " a12345 = @@{a12345 : a12345};\n" "}"); verifyFormat("int Foo() {\n" " a12345 = @@{a12345 : @@(a12345)};\n" "}"); verifyFormat("int Foo() {\n" " a12345 = @@{(Foo *)a12345 : @@(a12345)};\n" "}"); verifyFormat("int Foo() {\n" " a12345 = @@{@@(a12345) : a12345};\n" "}"); verifyFormat("int Foo() {\n" " a12345 = @@{@@(a12345) : @@YES};\n" "}"); Style.SpacesInContainerLiterals = false; verifyFormat("int Foo() {\n" " b12345 = @@{b12345: b12345};\n" "}"); verifyFormat("int Foo() {\n" " b12345 = @@{(Foo *)b12345: @@(b12345)};\n" "}"); Style.SpacesInContainerLiterals = true; a822 32 Style.ColumnLimit = 40; verifyFormat("int Foo() {\n" " a12345 = @@[ a12345, a12345 ];\n" "}"); verifyFormat("int Foo() {\n" " a123 = @@[ (Foo *)a12345, @@(a12345) ];\n" "}"); Style.SpacesInContainerLiterals = false; verifyFormat("int Foo() {\n" " b12345 = @@[b12345, b12345];\n" "}"); verifyFormat("int Foo() {\n" " b12345 = @@[(Foo *)b12345, @@(b12345)];\n" "}"); Style.SpacesInContainerLiterals = true; Style.ColumnLimit = 20; // We can't break string literals inside NSArray literals // (that raises -Wobjc-string-concatenation). verifyFormat("NSArray *foo = @@[\n" " @@\"aaaaaaaaaaaaaaaaaaaaaaaaaa\"\n" "];\n"); } TEST_F(FormatTestObjC, BreaksCallStatementWhereSemiJustOverTheLimit) { Style.ColumnLimit = 60; // If the statement starting with 'a = ...' is put on a single line, the ';' // is at line 61. verifyFormat("int f(int a) {\n" " a = [self aaaaaaaaaa:bbbbbbbbb\n" " ccccccccc:dddddddd\n" " ee:fddd];\n" "}"); a823 21 TEST_F(FormatTestObjC, AlwaysBreakBeforeMultilineStrings) { Style = getGoogleStyle(FormatStyle::LK_ObjC); Style.ColumnLimit = 40; verifyFormat("aaaa = @@\"bbbb\"\n" " @@\"cccc\";"); verifyFormat("aaaa(@@\"bbbb\"\n" " @@\"cccc\");"); verifyFormat("aaaa(qqq, @@\"bbbb\"\n" " @@\"cccc\");"); verifyFormat("[aaaa qqqq:@@\"bbbb\"\n" " @@\"cccc\"];"); verifyFormat("aaaa = [aaaa qqqq:@@\"bbbb\"\n" " @@\"cccc\"];"); verifyFormat("[aaaa qqqq:@@\"bbbb\"\n" " @@\"cccc\"\n" " rr:42\n" " ssssss:@@\"ee\"\n" " @@\"fffff\"];"); } @ 1.1.1.4 log @Mark old LLVM instance as dead. @ text @@ 1.1.1.1.4.1 log @file FormatTestObjC.cpp was added on branch pgoyette-localcount on 2017-03-20 06:53:39 +0000 @ text @d1 822 @ 1.1.1.1.4.2 log @Sync with HEAD @ text @a0 822 //===- unittest/Format/FormatTestObjC.cpp - Formatting unit tests----------===// // // The LLVM Compiler Infrastructure // // This file is distributed under the University of Illinois Open Source // License. See LICENSE.TXT for details. // //===----------------------------------------------------------------------===// #include "clang/Format/Format.h" #include "../Tooling/ReplacementTest.h" #include "FormatTestUtils.h" #include "clang/Frontend/TextDiagnosticPrinter.h" #include "llvm/Support/Debug.h" #include "llvm/Support/MemoryBuffer.h" #include "gtest/gtest.h" #define DEBUG_TYPE "format-test" using clang::tooling::ReplacementTest; using clang::tooling::toReplacements; namespace clang { namespace format { namespace { class FormatTestObjC : public ::testing::Test { protected: FormatTestObjC() { Style = getLLVMStyle(); Style.Language = FormatStyle::LK_ObjC; } enum IncompleteCheck { IC_ExpectComplete, IC_ExpectIncomplete, IC_DoNotCheck }; std::string format(llvm::StringRef Code, IncompleteCheck CheckIncomplete = IC_ExpectComplete) { DEBUG(llvm::errs() << "---\n"); DEBUG(llvm::errs() << Code << "\n\n"); std::vector Ranges(1, tooling::Range(0, Code.size())); bool IncompleteFormat = false; tooling::Replacements Replaces = reformat(Style, Code, Ranges, "", &IncompleteFormat); if (CheckIncomplete != IC_DoNotCheck) { bool ExpectedIncompleteFormat = CheckIncomplete == IC_ExpectIncomplete; EXPECT_EQ(ExpectedIncompleteFormat, IncompleteFormat) << Code << "\n\n"; } auto Result = applyAllReplacements(Code, Replaces); EXPECT_TRUE(static_cast(Result)); DEBUG(llvm::errs() << "\n" << *Result << "\n\n"); return *Result; } void verifyFormat(StringRef Code) { EXPECT_EQ(Code.str(), format(test::messUp(Code))); } void verifyIncompleteFormat(StringRef Code) { EXPECT_EQ(Code.str(), format(test::messUp(Code), IC_ExpectIncomplete)); } FormatStyle Style; }; TEST_F(FormatTestObjC, DetectsObjCInHeaders) { Style = getStyle("LLVM", "a.h", "none", "@@interface\n" "- (id)init;"); EXPECT_EQ(FormatStyle::LK_ObjC, Style.Language); Style = getStyle("LLVM", "a.h", "none", "@@interface\n" "+ (id)init;"); EXPECT_EQ(FormatStyle::LK_ObjC, Style.Language); // No recognizable ObjC. Style = getStyle("LLVM", "a.h", "none", "void f() {}"); EXPECT_EQ(FormatStyle::LK_Cpp, Style.Language); } TEST_F(FormatTestObjC, FormatObjCTryCatch) { verifyFormat("@@try {\n" " f();\n" "} @@catch (NSException e) {\n" " @@throw;\n" "} @@finally {\n" " exit(42);\n" "}"); verifyFormat("DEBUG({\n" " @@try {\n" " } @@finally {\n" " }\n" "});\n"); } TEST_F(FormatTestObjC, FormatObjCAutoreleasepool) { verifyFormat("@@autoreleasepool {\n" " f();\n" "}\n" "@@autoreleasepool {\n" " f();\n" "}\n"); Style.BreakBeforeBraces = FormatStyle::BS_Allman; verifyFormat("@@autoreleasepool\n" "{\n" " f();\n" "}\n" "@@autoreleasepool\n" "{\n" " f();\n" "}\n"); } TEST_F(FormatTestObjC, FormatObjCInterface) { verifyFormat("@@interface Foo : NSObject {\n" "@@public\n" " int field1;\n" "@@protected\n" " int field2;\n" "@@private\n" " int field3;\n" "@@package\n" " int field4;\n" "}\n" "+ (id)init;\n" "@@end"); verifyFormat("@@interface /* wait for it */ Foo\n" "+ (id)init;\n" "// Look, a comment!\n" "- (int)answerWith:(int)i;\n" "@@end"); verifyFormat("@@interface Foo\n" "@@end\n" "@@interface Bar\n" "@@end"); verifyFormat("@@interface Foo : Bar\n" "+ (id)init;\n" "@@end"); verifyFormat("@@interface Foo : /**/ Bar /**/ \n" "+ (id)init;\n" "@@end"); verifyFormat("@@interface Foo (HackStuff)\n" "+ (id)init;\n" "@@end"); verifyFormat("@@interface Foo ()\n" "+ (id)init;\n" "@@end"); verifyFormat("@@interface Foo (HackStuff) \n" "+ (id)init;\n" "@@end"); verifyFormat("@@interface Foo {\n" " int _i;\n" "}\n" "+ (id)init;\n" "@@end"); verifyFormat("@@interface Foo : Bar {\n" " int _i;\n" "}\n" "+ (id)init;\n" "@@end"); verifyFormat("@@interface Foo : Bar {\n" " int _i;\n" "}\n" "+ (id)init;\n" "@@end"); verifyFormat("@@interface Foo (HackStuff) {\n" " int _i;\n" "}\n" "+ (id)init;\n" "@@end"); verifyFormat("@@interface Foo () {\n" " int _i;\n" "}\n" "+ (id)init;\n" "@@end"); verifyFormat("@@interface Foo (HackStuff) {\n" " int _i;\n" "}\n" "+ (id)init;\n" "@@end"); Style = getGoogleStyle(FormatStyle::LK_ObjC); verifyFormat("@@interface Foo : NSObject {\n" " @@public\n" " int field1;\n" " @@protected\n" " int field2;\n" " @@private\n" " int field3;\n" " @@package\n" " int field4;\n" "}\n" "+ (id)init;\n" "@@end"); verifyFormat("@@interface Foo : Bar\n" "+ (id)init;\n" "@@end"); verifyFormat("@@interface Foo (HackStuff)\n" "+ (id)init;\n" "@@end"); Style.BinPackParameters = false; Style.ColumnLimit = 80; verifyFormat("@@interface aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ()<\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa> {\n" "}"); } TEST_F(FormatTestObjC, FormatObjCImplementation) { verifyFormat("@@implementation Foo : NSObject {\n" "@@public\n" " int field1;\n" "@@protected\n" " int field2;\n" "@@private\n" " int field3;\n" "@@package\n" " int field4;\n" "}\n" "+ (id)init {\n}\n" "@@end"); verifyFormat("@@implementation Foo\n" "+ (id)init {\n" " if (true)\n" " return nil;\n" "}\n" "// Look, a comment!\n" "- (int)answerWith:(int)i {\n" " return i;\n" "}\n" "+ (int)answerWith:(int)i {\n" " return i;\n" "}\n" "@@end"); verifyFormat("@@implementation Foo\n" "@@end\n" "@@implementation Bar\n" "@@end"); EXPECT_EQ("@@implementation Foo : Bar\n" "+ (id)init {\n}\n" "- (void)foo {\n}\n" "@@end", format("@@implementation Foo : Bar\n" "+(id)init{}\n" "-(void)foo{}\n" "@@end")); verifyFormat("@@implementation Foo {\n" " int _i;\n" "}\n" "+ (id)init {\n}\n" "@@end"); verifyFormat("@@implementation Foo : Bar {\n" " int _i;\n" "}\n" "+ (id)init {\n}\n" "@@end"); verifyFormat("@@implementation Foo (HackStuff)\n" "+ (id)init {\n}\n" "@@end"); verifyFormat("@@implementation ObjcClass\n" "- (void)method;\n" "{}\n" "@@end"); Style = getGoogleStyle(FormatStyle::LK_ObjC); verifyFormat("@@implementation Foo : NSObject {\n" " @@public\n" " int field1;\n" " @@protected\n" " int field2;\n" " @@private\n" " int field3;\n" " @@package\n" " int field4;\n" "}\n" "+ (id)init {\n}\n" "@@end"); } TEST_F(FormatTestObjC, FormatObjCProtocol) { verifyFormat("@@protocol Foo\n" "@@property(weak) id delegate;\n" "- (NSUInteger)numberOfThings;\n" "@@end"); verifyFormat("@@protocol MyProtocol \n" "- (NSUInteger)numberOfThings;\n" "@@end"); verifyFormat("@@protocol Foo;\n" "@@protocol Bar;\n"); verifyFormat("@@protocol Foo\n" "@@end\n" "@@protocol Bar\n" "@@end"); verifyFormat("@@protocol myProtocol\n" "- (void)mandatoryWithInt:(int)i;\n" "@@optional\n" "- (void)optional;\n" "@@required\n" "- (void)required;\n" "@@optional\n" "@@property(assign) int madProp;\n" "@@end\n"); verifyFormat("@@property(nonatomic, assign, readonly)\n" " int *looooooooooooooooooooooooooooongNumber;\n" "@@property(nonatomic, assign, readonly)\n" " NSString *looooooooooooooooooooooooooooongName;"); verifyFormat("@@implementation PR18406\n" "}\n" "@@end"); Style = getGoogleStyle(FormatStyle::LK_ObjC); verifyFormat("@@protocol MyProtocol\n" "- (NSUInteger)numberOfThings;\n" "@@end"); } TEST_F(FormatTestObjC, FormatObjCMethodDeclarations) { verifyFormat("- (void)doSomethingWith:(GTMFoo *)theFoo\n" " rect:(NSRect)theRect\n" " interval:(float)theInterval {\n" "}"); verifyFormat("- (void)shortf:(GTMFoo *)theFoo\n" " longKeyword:(NSRect)theRect\n" " longerKeyword:(float)theInterval\n" " error:(NSError **)theError {\n" "}"); verifyFormat("- (void)shortf:(GTMFoo *)theFoo\n" " longKeyword:(NSRect)theRect\n" " evenLongerKeyword:(float)theInterval\n" " error:(NSError **)theError {\n" "}"); Style.ColumnLimit = 60; verifyFormat("- (instancetype)initXxxxxx:(id)x\n" " y:(id)y\n" " NS_DESIGNATED_INITIALIZER;"); verifyFormat("- (void)drawRectOn:(id)surface\n" " ofSize:(size_t)height\n" " :(size_t)width;"); // Continuation indent width should win over aligning colons if the function // name is long. Style = getGoogleStyle(FormatStyle::LK_ObjC); Style.ColumnLimit = 40; Style.IndentWrappedFunctionNames = true; verifyFormat("- (void)shortf:(GTMFoo *)theFoo\n" " dontAlignNamef:(NSRect)theRect {\n" "}"); // Make sure we don't break aligning for short parameter names. verifyFormat("- (void)shortf:(GTMFoo *)theFoo\n" " aShortf:(NSRect)theRect {\n" "}"); // Format pairs correctly. Style.ColumnLimit = 80; verifyFormat("- (void)drawRectOn:(id)surface\n" " ofSize:(aaaaaaaa)height\n" " :(size_t)width\n" " atOrigin:(size_t)x\n" " :(size_t)y\n" " aaaaa:(a)yyy\n" " bbb:(d)cccc;"); verifyFormat("- (void)drawRectOn:(id)surface ofSize:(aaa)height:(bbb)width;"); } TEST_F(FormatTestObjC, FormatObjCMethodExpr) { verifyFormat("[foo bar:baz];"); verifyFormat("return [foo bar:baz];"); verifyFormat("return (a)[foo bar:baz];"); verifyFormat("f([foo bar:baz]);"); verifyFormat("f(2, [foo bar:baz]);"); verifyFormat("f(2, a ? b : c);"); verifyFormat("[[self initWithInt:4] bar:[baz quux:arrrr]];"); // Unary operators. verifyFormat("int a = +[foo bar:baz];"); verifyFormat("int a = -[foo bar:baz];"); verifyFormat("int a = ![foo bar:baz];"); verifyFormat("int a = ~[foo bar:baz];"); verifyFormat("int a = ++[foo bar:baz];"); verifyFormat("int a = --[foo bar:baz];"); verifyFormat("int a = sizeof [foo bar:baz];"); verifyFormat("int a = alignof [foo bar:baz];"); verifyFormat("int a = &[foo bar:baz];"); verifyFormat("int a = *[foo bar:baz];"); // FIXME: Make casts work, without breaking f()[4]. // verifyFormat("int a = (int)[foo bar:baz];"); // verifyFormat("return (int)[foo bar:baz];"); // verifyFormat("(void)[foo bar:baz];"); verifyFormat("return (MyType *)[self.tableView cellForRowAtIndexPath:cell];"); // Binary operators. verifyFormat("[foo bar:baz], [foo bar:baz];"); verifyFormat("[foo bar:baz] = [foo bar:baz];"); verifyFormat("[foo bar:baz] *= [foo bar:baz];"); verifyFormat("[foo bar:baz] /= [foo bar:baz];"); verifyFormat("[foo bar:baz] %= [foo bar:baz];"); verifyFormat("[foo bar:baz] += [foo bar:baz];"); verifyFormat("[foo bar:baz] -= [foo bar:baz];"); verifyFormat("[foo bar:baz] <<= [foo bar:baz];"); verifyFormat("[foo bar:baz] >>= [foo bar:baz];"); verifyFormat("[foo bar:baz] &= [foo bar:baz];"); verifyFormat("[foo bar:baz] ^= [foo bar:baz];"); verifyFormat("[foo bar:baz] |= [foo bar:baz];"); verifyFormat("[foo bar:baz] ? [foo bar:baz] : [foo bar:baz];"); verifyFormat("[foo bar:baz] || [foo bar:baz];"); verifyFormat("[foo bar:baz] && [foo bar:baz];"); verifyFormat("[foo bar:baz] | [foo bar:baz];"); verifyFormat("[foo bar:baz] ^ [foo bar:baz];"); verifyFormat("[foo bar:baz] & [foo bar:baz];"); verifyFormat("[foo bar:baz] == [foo bar:baz];"); verifyFormat("[foo bar:baz] != [foo bar:baz];"); verifyFormat("[foo bar:baz] >= [foo bar:baz];"); verifyFormat("[foo bar:baz] <= [foo bar:baz];"); verifyFormat("[foo bar:baz] > [foo bar:baz];"); verifyFormat("[foo bar:baz] < [foo bar:baz];"); verifyFormat("[foo bar:baz] >> [foo bar:baz];"); verifyFormat("[foo bar:baz] << [foo bar:baz];"); verifyFormat("[foo bar:baz] - [foo bar:baz];"); verifyFormat("[foo bar:baz] + [foo bar:baz];"); verifyFormat("[foo bar:baz] * [foo bar:baz];"); verifyFormat("[foo bar:baz] / [foo bar:baz];"); verifyFormat("[foo bar:baz] % [foo bar:baz];"); // Whew! verifyFormat("return in[42];"); verifyFormat("for (auto v : in[1]) {\n}"); verifyFormat("for (int i = 0; i < in[a]; ++i) {\n}"); verifyFormat("for (int i = 0; in[a] < i; ++i) {\n}"); verifyFormat("for (int i = 0; i < n; ++i, ++in[a]) {\n}"); verifyFormat("for (int i = 0; i < n; ++i, in[a]++) {\n}"); verifyFormat("for (int i = 0; i < f(in[a]); ++i, in[a]++) {\n}"); verifyFormat("for (id foo in [self getStuffFor:bla]) {\n" "}"); verifyFormat("[self aaaaa:MACRO(a, b:, c:)];"); verifyFormat("[self aaaaa:(1 + 2) bbbbb:3];"); verifyFormat("[self aaaaa:(Type)a bbbbb:3];"); verifyFormat("[self stuffWithInt:(4 + 2) float:4.5];"); verifyFormat("[self stuffWithInt:a ? b : c float:4.5];"); verifyFormat("[self stuffWithInt:a ? [self foo:bar] : c];"); verifyFormat("[self stuffWithInt:a ? (e ? f : g) : c];"); verifyFormat("[cond ? obj1 : obj2 methodWithParam:param]"); verifyFormat("[button setAction:@@selector(zoomOut:)];"); verifyFormat("[color getRed:&r green:&g blue:&b alpha:&a];"); verifyFormat("arr[[self indexForFoo:a]];"); verifyFormat("throw [self errorFor:a];"); verifyFormat("@@throw [self errorFor:a];"); verifyFormat("[(id)foo bar:(id)baz quux:(id)snorf];"); verifyFormat("[(id)foo bar:(id) ? baz : quux];"); verifyFormat("4 > 4 ? (id)a : (id)baz;"); // This tests that the formatter doesn't break after "backing" but before ":", // which would be at 80 columns. verifyFormat( "void f() {\n" " if ((self = [super initWithContentRect:contentRect\n" " styleMask:styleMask ?: otherMask\n" " backing:NSBackingStoreBuffered\n" " defer:YES]))"); verifyFormat( "[foo checkThatBreakingAfterColonWorksOk:\n" " [bar ifItDoes:reduceOverallLineLengthLikeInThisCase]];"); verifyFormat("[myObj short:arg1 // Force line break\n" " longKeyword:arg2 != nil ? arg2 : @@\"longKeyword\"\n" " evenLongerKeyword:arg3 ?: @@\"evenLongerKeyword\"\n" " error:arg4];"); verifyFormat( "void f() {\n" " popup_window_.reset([[RenderWidgetPopupWindow alloc]\n" " initWithContentRect:NSMakeRect(origin_global.x, origin_global.y,\n" " pos.width(), pos.height())\n" " styleMask:NSBorderlessWindowMask\n" " backing:NSBackingStoreBuffered\n" " defer:NO]);\n" "}"); verifyFormat("[contentsContainer replaceSubview:[subviews objectAtIndex:0]\n" " with:contentsNativeView];"); verifyFormat( "[pboard addTypes:[NSArray arrayWithObject:kBookmarkButtonDragType]\n" " owner:nillllll];"); verifyFormat( "[pboard setData:[NSData dataWithBytes:&button length:sizeof(button)]\n" " forType:kBookmarkButtonDragType];"); verifyFormat("[defaultCenter addObserver:self\n" " selector:@@selector(willEnterFullscreen)\n" " name:kWillEnterFullscreenNotification\n" " object:nil];"); verifyFormat("[image_rep drawInRect:drawRect\n" " fromRect:NSZeroRect\n" " operation:NSCompositeCopy\n" " fraction:1.0\n" " respectFlipped:NO\n" " hints:nil];"); verifyFormat("[aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa];"); verifyFormat("[aaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaa)\n" " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa];"); verifyFormat("[aaaaaaaaaaaaaaaaaaaaaaa.aaaaaaaa[aaaaaaaaaaaaaaaaaaaaa]\n" " aaaaaaaaaaaaaaaaaaaaaa];"); verifyFormat( "scoped_nsobject message(\n" " // The frame will be fixed up when |-setMessageText:| is called.\n" " [[NSTextField alloc] initWithFrame:NSMakeRect(0, 0, 0, 0)]);"); verifyFormat("[self aaaaaa:bbbbbbbbbbbbb\n" " aaaaaaaaaa:bbbbbbbbbbbbbbbbb\n" " aaaaa:bbbbbbbbbbb + bbbbbbbbbbbb\n" " aaaa:bbb];"); verifyFormat("[self param:function( //\n" " parameter)]"); verifyFormat( "[self aaaaaaaaaa:aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa |\n" " aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa |\n" " aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa];"); // Variadic parameters. verifyFormat( "NSArray *myStrings = [NSArray stringarray:@@\"a\", @@\"b\", nil];"); verifyFormat( "[self aaaaaaaaaaaaa:aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa,\n" " aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa,\n" " aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa];"); verifyFormat("[self // break\n" " a:a\n" " aaa:aaa];"); verifyFormat("bool a = ([aaaaaaaa aaaaa] == aaaaaaaaaaaaaaaaa ||\n" " [aaaaaaaa aaaaa] == aaaaaaaaaaaaaaaaaaaa);"); // Formats pair-parameters. verifyFormat("[I drawRectOn:surface ofSize:aa:bbb atOrigin:cc:dd];"); verifyFormat("[I drawRectOn:surface //\n" " ofSize:aa:bbb\n" " atOrigin:cc:dd];"); Style.ColumnLimit = 70; verifyFormat( "void f() {\n" " popup_wdow_.reset([[RenderWidgetPopupWindow alloc]\n" " iniithContentRect:NSMakRet(origin_global.x, origin_global.y,\n" " pos.width(), pos.height())\n" " syeMask:NSBorderlessWindowMask\n" " bking:NSBackingStoreBuffered\n" " der:NO]);\n" "}"); Style.ColumnLimit = 60; verifyFormat("[call aaaaaaaa.aaaaaa.aaaaaaaa.aaaaaaaa.aaaaaaaa.aaaaaaaa\n" " .aaaaaaaa];"); // FIXME: Indentation seems off. // FIXME: This violates the column limit. verifyFormat( "[aaaaaaaaaaaaaaaaaaaaaaaaa\n" " aaaaaaaaaaaaaaaaa:aaaaaaaa\n" " aaa:aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa];"); Style = getChromiumStyle(FormatStyle::LK_ObjC); Style.ColumnLimit = 80; verifyFormat( "void f() {\n" " popup_window_.reset([[RenderWidgetPopupWindow alloc]\n" " initWithContentRect:NSMakeRect(origin_global.x, origin_global.y,\n" " pos.width(), pos.height())\n" " styleMask:NSBorderlessWindowMask\n" " backing:NSBackingStoreBuffered\n" " defer:NO]);\n" "}"); } TEST_F(FormatTestObjC, ObjCAt) { verifyFormat("@@autoreleasepool"); verifyFormat("@@catch"); verifyFormat("@@class"); verifyFormat("@@compatibility_alias"); verifyFormat("@@defs"); verifyFormat("@@dynamic"); verifyFormat("@@encode"); verifyFormat("@@end"); verifyFormat("@@finally"); verifyFormat("@@implementation"); verifyFormat("@@import"); verifyFormat("@@interface"); verifyFormat("@@optional"); verifyFormat("@@package"); verifyFormat("@@private"); verifyFormat("@@property"); verifyFormat("@@protected"); verifyFormat("@@protocol"); verifyFormat("@@public"); verifyFormat("@@required"); verifyFormat("@@selector"); verifyFormat("@@synchronized"); verifyFormat("@@synthesize"); verifyFormat("@@throw"); verifyFormat("@@try"); EXPECT_EQ("@@interface", format("@@ interface")); // The precise formatting of this doesn't matter, nobody writes code like // this. verifyFormat("@@ /*foo*/ interface"); } TEST_F(FormatTestObjC, ObjCSnippets) { verifyFormat("@@autoreleasepool {\n" " foo();\n" "}"); verifyFormat("@@class Foo, Bar;"); verifyFormat("@@compatibility_alias AliasName ExistingClass;"); verifyFormat("@@dynamic textColor;"); verifyFormat("char *buf1 = @@encode(int *);"); verifyFormat("char *buf1 = @@encode(typeof(4 * 5));"); verifyFormat("char *buf1 = @@encode(int **);"); verifyFormat("Protocol *proto = @@protocol(p1);"); verifyFormat("SEL s = @@selector(foo:);"); verifyFormat("@@synchronized(self) {\n" " f();\n" "}"); verifyFormat("@@import foo.bar;\n" "@@import baz;"); verifyFormat("@@synthesize dropArrowPosition = dropArrowPosition_;"); verifyFormat("@@property(assign, nonatomic) CGFloat hoverAlpha;"); verifyFormat("@@property(assign, getter=isEditable) BOOL editable;"); Style = getMozillaStyle(); verifyFormat("@@property (assign, getter=isEditable) BOOL editable;"); verifyFormat("@@property BOOL editable;"); Style = getWebKitStyle(); verifyFormat("@@property (assign, getter=isEditable) BOOL editable;"); verifyFormat("@@property BOOL editable;"); Style = getGoogleStyle(FormatStyle::LK_ObjC); verifyFormat("@@synthesize dropArrowPosition = dropArrowPosition_;"); verifyFormat("@@property(assign, getter=isEditable) BOOL editable;"); } TEST_F(FormatTestObjC, ObjCForIn) { verifyFormat("- (void)test {\n" " for (NSString *n in arrayOfStrings) {\n" " foo(n);\n" " }\n" "}"); verifyFormat("- (void)test {\n" " for (NSString *n in (__bridge NSArray *)arrayOfStrings) {\n" " foo(n);\n" " }\n" "}"); } TEST_F(FormatTestObjC, ObjCLiterals) { verifyFormat("@@\"String\""); verifyFormat("@@1"); verifyFormat("@@+4.8"); verifyFormat("@@-4"); verifyFormat("@@1LL"); verifyFormat("@@.5"); verifyFormat("@@'c'"); verifyFormat("@@true"); verifyFormat("NSNumber *smallestInt = @@(-INT_MAX - 1);"); verifyFormat("NSNumber *piOverTwo = @@(M_PI / 2);"); verifyFormat("NSNumber *favoriteColor = @@(Green);"); verifyFormat("NSString *path = @@(getenv(\"PATH\"));"); verifyFormat("[dictionary setObject:@@(1) forKey:@@\"number\"];"); } TEST_F(FormatTestObjC, ObjCDictLiterals) { verifyFormat("@@{"); verifyFormat("@@{}"); verifyFormat("@@{@@\"one\" : @@1}"); verifyFormat("return @@{@@\"one\" : @@1;"); verifyFormat("@@{@@\"one\" : @@1}"); verifyFormat("@@{@@\"one\" : @@{@@2 : @@1}}"); verifyFormat("@@{\n" " @@\"one\" : @@{@@2 : @@1},\n" "}"); verifyFormat("@@{1 > 2 ? @@\"one\" : @@\"two\" : 1 > 2 ? @@1 : @@2}"); verifyIncompleteFormat("[self setDict:@@{}"); verifyIncompleteFormat("[self setDict:@@{@@1 : @@2}"); verifyFormat("NSLog(@@\"%@@\", @@{@@1 : @@2, @@2 : @@3}[@@1]);"); verifyFormat( "NSDictionary *masses = @@{@@\"H\" : @@1.0078, @@\"He\" : @@4.0026};"); verifyFormat( "NSDictionary *settings = @@{AVEncoderKey : @@(AVAudioQualityMax)};"); verifyFormat("NSDictionary *d = @@{\n" " @@\"nam\" : NSUserNam(),\n" " @@\"dte\" : [NSDate date],\n" " @@\"processInfo\" : [NSProcessInfo processInfo]\n" "};"); verifyFormat( "@@{\n" " NSFontAttributeNameeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee : " "regularFont,\n" "};"); verifyFormat( "@@{\n" " NSFontAttributeNameeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee :\n" " reeeeeeeeeeeeeeeeeeeeeeeegularFont,\n" "};"); // We should try to be robust in case someone forgets the "@@". verifyFormat("NSDictionary *d = {\n" " @@\"nam\" : NSUserNam(),\n" " @@\"dte\" : [NSDate date],\n" " @@\"processInfo\" : [NSProcessInfo processInfo]\n" "};"); verifyFormat("NSMutableDictionary *dictionary =\n" " [NSMutableDictionary dictionaryWithDictionary:@@{\n" " aaaaaaaaaaaaaaaaaaaaa : aaaaaaaaaaaaa,\n" " bbbbbbbbbbbbbbbbbb : bbbbb,\n" " cccccccccccccccc : ccccccccccccccc\n" " }];"); // Ensure that casts before the key are kept on the same line as the key. verifyFormat( "NSDictionary *d = @@{\n" " (aaaaaaaa id)aaaaaaaaa : (aaaaaaaa id)aaaaaaaaaaaaaaaaaaaaaaaa,\n" " (aaaaaaaa id)aaaaaaaaaaaaaa : (aaaaaaaa id)aaaaaaaaaaaaaa,\n" "};"); Style = getGoogleStyle(FormatStyle::LK_ObjC); verifyFormat( "@@{\n" " NSFontAttributeNameeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee : " "regularFont,\n" "};"); } TEST_F(FormatTestObjC, ObjCArrayLiterals) { verifyIncompleteFormat("@@["); verifyFormat("@@[]"); verifyFormat( "NSArray *array = @@[ @@\" Hey \", NSApp, [NSNumber numberWithInt:42] ];"); verifyFormat("return @@[ @@3, @@[], @@[ @@4, @@5 ] ];"); verifyFormat("NSArray *array = @@[ [foo description] ];"); verifyFormat( "NSArray *some_variable = @@[\n" " aaaa == bbbbbbbbbbb ? @@\"aaaaaaaaaaaa\" : @@\"aaaaaaaaaaaaaa\",\n" " @@\"aaaaaaaaaaaaaaaaa\",\n" " @@\"aaaaaaaaaaaaaaaaa\",\n" " @@\"aaaaaaaaaaaaaaaaa\",\n" "];"); verifyFormat( "NSArray *some_variable = @@[\n" " aaaa == bbbbbbbbbbb ? @@\"aaaaaaaaaaaa\" : @@\"aaaaaaaaaaaaaa\",\n" " @@\"aaaaaaaaaaaaaaaa\", @@\"aaaaaaaaaaaaaaaa\", @@\"aaaaaaaaaaaaaaaa\"\n" "];"); verifyFormat("NSArray *some_variable = @@[\n" " @@\"aaaaaaaaaaaaaaaaa\",\n" " @@\"aaaaaaaaaaaaaaaaa\",\n" " @@\"aaaaaaaaaaaaaaaaa\",\n" " @@\"aaaaaaaaaaaaaaaaa\",\n" "];"); verifyFormat("NSArray *array = @@[\n" " @@\"a\",\n" " @@\"a\",\n" // Trailing comma -> one per line. "];"); // We should try to be robust in case someone forgets the "@@". verifyFormat("NSArray *some_variable = [\n" " @@\"aaaaaaaaaaaaaaaaa\",\n" " @@\"aaaaaaaaaaaaaaaaa\",\n" " @@\"aaaaaaaaaaaaaaaaa\",\n" " @@\"aaaaaaaaaaaaaaaaa\",\n" "];"); verifyFormat( "- (NSAttributedString *)attributedStringForSegment:(NSUInteger)segment\n" " index:(NSUInteger)index\n" " nonDigitAttributes:\n" " (NSDictionary *)noDigitAttributes;"); verifyFormat("[someFunction someLooooooooooooongParameter:@@[\n" " NSBundle.mainBundle.infoDictionary[@@\"a\"]\n" "]];"); } } // end namespace } // end namespace format } // end namespace clang @